[Bug 36150] New: Circulation page styling should match Cataloging styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Bug ID: 36150 Summary: Circulation page styling should match Cataloging styling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, oleonard@myacpl.org Compare both: <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl <staff_url>/cgi-bin/koha/circ/circulation-home.pl There's no reason for circulation home to differ and not have side margins. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162331&action=edit Bug 36150: Update circulation-home.tt layout Test plan: Compare both pages: <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl <staff_url>/cgi-bin/koha/circ/circulation-home.pl Apply patch Compare both pages again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- git show -w <patch_hash>: @@ -23,9 +23,11 @@ [% END #/ WRAPPER sub-header.inc %] <div class="main container-fluid"> + <div class="row"> + <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> + [% INCLUDE 'messages.inc' %] <h1>Circulation</h1> - [% INCLUDE 'messages.inc' %] <div class="row"> @@ -180,5 +182,7 @@ </div> </div> </div> + </div> + </div> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Circulation page styling |Circulation home page |should match Cataloging |styling does not match |styling |Cataloging home page | |styling CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m Severity|enhancement |minor Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162331|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 162399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162399&action=edit Bug 36150: Update circulation-home.tt layout Test plan: Compare both pages: <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl <staff_url>/cgi-bin/koha/circ/circulation-home.pl Apply patch Compare both pages again Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- This is much nicer, and more consistent! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162399|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162427&action=edit Bug 36150: Update circulation-home.tt layout Test plan: Compare both pages: <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl <staff_url>/cgi-bin/koha/circ/circulation-home.pl Apply patch Compare both pages again Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great consistency improvement, thanks Pedro. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36164 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 [Bug 36164] Bring more consistency to our module landing pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the styling of release notes| |the circulation home page | |for the staff interface. It | |is now consistent with the | |cataloging home page, and | |includes wider side | |margins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.04 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Does not apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org