[Bug 23889] New: Improve style of menu header in advanced cataloging editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Bug ID: 23889 Summary: Improve style of menu header in advanced cataloging editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 94677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94677&action=edit GIF comparing before and after the patch The "Settings" menu in the advanced cataloging editor has a menu item which is a header (change framework). This should be styled better, matching, for instance, the "Sort" menu on catalog search results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94679&action=edit Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94679|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94977&action=edit Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What I see is different from what you advertised: https://snipboard.io/X4UwbT.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)
What I see is different from what you advertised: https://snipboard.io/X4UwbT.jpg
Hum ignore that, I got an error on `yarn build` that I did not see! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94977|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96337&action=edit Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96338&action=edit Bug 23889: Use same css class on the basic editor view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6)
Created attachment 96338 [details] [review] Bug 23889: Use same css class on the basic editor view
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Owen, can you confirm you agree with this patch please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the styling of dropdown | |menu headers to make them | |apply more consistently | |across the system. CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x. for 19.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #11 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org