https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Ere Maijala <ere.maijala@helsinki.fi> --- The patch provides the following improvements: 1.) Mappings UI now has button that allows one to reset the mappings. 2.) Mappings UI displays the items in alphabetical order. 3.) Indexing script drops and recreates the index right away, which helps prevent ES from autocreating a bad index if someone does something while the first batch of records is being processed. 4.) Indexing script has nicer output. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- I think this should be splited into 2 parts. One for the indexing things and one for what is related to mapping UI. Are you ok? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om --- Comment #5 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- 1.) Mappings UI now has button that allows one to reset the mappings. It works for me. Maybe, we could be a little more specific in the confirm form. Something like "The current mappings you seen on the screen will be erased and relaced by the mappings in the mappings.yaml file" 2.) Mappings UI displays the items in alphabetical order. Ok it works for me. 3.) Indexing script drops and recreates the index right away, which helps prevent ES from autocreating a bad index if someone does something while the first batch of records is being processed. I don't understand this part. 4.) Indexing script has nicer output. Ok for me. I cannot SO with the doubt on 3. Thanks for your patch :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 --- Comment #6 from Ere Maijala <ere.maijala@helsinki.fi> --- 3.) Currently the indexing script, when used with the -d parameter, does the following: 1. Drops the existing index 2. Start collecting records in a buffer 3. Commit the buffer when it's full The ES index will only be recreated at the first commit. This means that there's a time window between steps 1 and 3 during which it's possible that someone/something else saves a record, which causes the index to be automatically created by ES, but without all the settings it should have. That's why it's a good idea to recreate the index right away after dropping the old one. Another possibility is to instruct the ES instance to never autocreate indexes, but that's outside the scope of indexing here, and I believe it's in any case a good practice to at least have an empty but working index in place if the indexing script is interrupted before first commit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71954|0 |1 is obsolete| | --- Comment #7 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- Created attachment 72801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72801&action=edit Bug 20248: Improve Elasticsearch mapppings UI and rebuild_elastic_search.pl. Improvements: 1) Mappings UI now has button that allows one to reset the mappings. 2) Mappings UI displays the items in alphabetical order. 3) Indexing script drops and recreates the index right away, which helps prevent ES from autocreating a bad index if someone does something while the first batch of records is being processed. 4) Indexing script has nicer output. To test: 1) Change mappings.yaml file 2) Reset mappings in UI in mappings.pl 3) Verify the mappings have been changed in UI 4) The field order is alphabetical 5) Rebuild script has an clean output Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 --- Comment #9 from Ere Maijala <ere.maijala@helsinki.fi> --- Thanks for comments. 1) I tried to use the prevalent style in the file, but I'll change the indentation. 2) I'll add a test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72801|0 |1 is obsolete| | --- Comment #10 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 72861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72861&action=edit Bug 20248 - Elasticsearch - Improvements to mappings UI and indexing script Improvements: 1) Mappings UI now has button that allows one to reset the mappings. 2) Mappings UI displays the items in alphabetical order. 3) Indexing script drops and recreates the index right away, which helps prevent ES from autocreating a bad index if someone does something while the first batch of records is being processed. 4) Indexing script has nicer output. To test: 1) Change mappings.yaml file 2) Reset mappings in UI in mappings.pl 3) Verify the mappings have been changed in UI 4) The field order is alphabetical 5) Rebuild script has clean output 6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 --- Comment #13 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Ere Maijala from comment #11)

I think I managed to address the issues.

1) I used correct indentation where it was possible without changing large blocks. 2) Added. Is this how it's supposed to be? Can you change the index name please? biblios => biblios_test for example. biblios is the one we use in real

-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72907|0 |1 is obsolete| | --- Comment #14 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- Created attachment 72921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72921&action=edit Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl. Improvements: 1) Mappings UI now has button that allows one to reset the mappings. 2) Mappings UI displays the items in alphabetical order. 3) Indexing script drops and recreates the index right away, which helps prevent ES from autocreating a bad index if someone does something while the first batch of records is being processed. 4) Indexing script has nicer output. To test: 1) Change mappings.yaml file 2) Reset mappings in UI in mappings.pl 3) Verify the mappings have been changed in UI 4) The field order is alphabetical 5) Rebuild script has clean output 6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72922|0 |1 is obsolete| | --- Comment #17 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72933&action=edit Bug 20248: (follow-up) Improve Elasticsearch mappings UI and rebuild_elastic_search.pl - change index name Signed-off-by: Koha User <support@biblibre.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Alex Arnaud <alex.arnaud@biblibre.com> --- Ok for me. So, passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |ere.maijala@helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 --- Comment #21 from Ere Maijala <ere.maijala@helsinki.fi> --- Alex, please note that the test should already append __test to any index name (see line 71). I don't think 'biblios' in the new() call should be modified. It's always either biblios or authorities (might be better to use the constants, but the string was used in other places so I kept it). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Ere Maijala from comment #22)

Jonathan, thanks, that was indeed bad. Is it ok now? I wasn't quite sure what you meant with "The warning should not be displayed".

I was talking about this warning: "Warning: Any changes to the configuration [...]" I think it does not make sense to display it on the confirmation screen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73798|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 77570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77570&action=edit Bug 20248 - Improve Elasticsearch mappings UI and rebuild_elastic_search.pl. Improvements: 1) Mappings UI now has button that allows one to reset the mappings. 2) Mappings UI displays the items in alphabetical order. 3) Indexing script drops and recreates the index right away, which helps prevent ES from autocreating a bad index if someone does something while the first batch of records is being processed. 4) Indexing script has nicer output. To test: 1) Change mappings.yaml file 2) Reset mappings in UI in mappings.pl 3) Verify the mappings have been changed in UI 4) The field order is alphabetical 5) Rebuild script has clean output 6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 77572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77572&action=edit Bug 20248: Improve Elasticsearch mappings UI and rebuild_elastic_search.pl Improvements: 1) Mappings UI now has button that allows one to reset the mappings. 2) Mappings UI displays the items in alphabetical order. 3) Indexing script drops and recreates the index right away, which helps prevent ES from autocreating a bad index if someone does something while the first batch of records is being processed. 4) Indexing script has nicer output. To test: 1) Change mappings.yaml file 2) Reset mappings in UI in mappings.pl 3) Verify the mappings have been changed in UI 4) The field order is alphabetical 5) Rebuild script has clean output 6) Run test t/db_dependent/Koha_Elasticsearch_Indexer.t Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> ---

...

...

I was talking about this warning: "Warning: Any changes to the configuration [...]"

I think it does not make sense to display it on the confirmation screen.

Why not ? Resetting indexes is a change to the configuration, so the warning is relevant in my opinion.

I guess the important part was "on the confirmation screen".

I've read this part too, and I don't understand why you would want to hide this warning on the confirmation screen. Can you explain why showing it does not make sense to you ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.