[Bug 22278] New: Cannot create report group while editing report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Bug ID: 22278 Summary: Cannot create report group while editing report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- You can fill in the code and name, but when you save the report, nothing is created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot create report group |Cannot link a report group |while editing report |while creating it --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Correction: the group is created, but not linked when you save the report. You have to refresh to even see the group, then select and save the report again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19957 Summary|Cannot link a report group |Newly created report group |while creating it |is not selected after | |saving an SQL report CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the issue might be with the new "save and continue" feature. 0) Start a new report 1) Pick create for the group 2) Enter code and value 3) Save 4) You remain on the page and value and code are now empty (ok) 5) BUT: The pull down for the group remains "None" instead of reflecting the new group 6) Save again - group was created, but lost on the report Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 [Bug 19957] Allow continued editing after saving a report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 84813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84813&action=edit Bug 22278: Clear cache when creating new report groups or subgroups When a user adds a new group we create it, then fetch the groups from the cache. However, we aren't clearing the cache on creation. This patch fixes that To test: 0) Start a new report 1) Pick create for the group 2) Enter code and value 3) Save 4) You remain on the page and value and code are now empty (ok) 5) BUT: The pull down for the group remains "None" instead of reflecting the new group 6) Open a new tab and browse to reports - note the group exists and the report is in it 7) On original tab save report again, the group was not selected so is lost 8) Apply patch 9) Retest with a new report 10) Group is created, saved, and selected upon save 11) Subsequent edits include the new group 12) Test with subgroups as well -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84813|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 84855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84855&action=edit Bug 22278: Clear cache when creating new report groups or subgroups When a user adds a new group we create it, then fetch the groups from the cache. However, we aren't clearing the cache on creation. This patch fixes that To test: 0) Start a new report 1) Pick create for the group 2) Enter code and value 3) Save 4) You remain on the page and value and code are now empty (ok) 5) BUT: The pull down for the group remains "None" instead of reflecting the new group 6) Open a new tab and browse to reports - note the group exists and the report is in it 7) On original tab save report again, the group was not selected so is lost 8) Apply patch 9) Retest with a new report 10) Group is created, saved, and selected upon save 11) Subsequent edits include the new group 12) Test with subgroups as well Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84855|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84858&action=edit Bug 22278: Clear cache when creating new report groups or subgroups When a user adds a new group we create it, then fetch the groups from the cache. However, we aren't clearing the cache on creation. This patch fixes that To test: 0) Start a new report 1) Pick create for the group 2) Enter code and value 3) Save 4) You remain on the page and value and code are now empty (ok) 5) BUT: The pull down for the group remains "None" instead of reflecting the new group 6) Open a new tab and browse to reports - note the group exists and the report is in it 7) On original tab save report again, the group was not selected so is lost 8) Apply patch 9) Retest with a new report 10) Group is created, saved, and selected upon save 11) Subsequent edits include the new group 12) Test with subgroups as well Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18495 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 19957 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org