[Bug 18387] New: 404 errors on page causes SCO user to be logged out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Bug ID: 18387 Summary: 404 errors on page causes SCO user to be logged out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If AutoSelfCheck is enabled but there is a 404 error in fetching resources on an SCO page the user is logged out on each request. This is because a 404 also requests the errorpages.tt which is outside the SCO module. This causes a redirect to the opac-auth page when trying to print receipts after completing SCO transaction To recreate: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Looks like a 304 and others can trigger this as well -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Eugene Espinoza <eugenegf@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf@yahoo.com --- Comment #2 from Eugene Espinoza <eugenegf@yahoo.com> --- Hi! We're experiencing this too in one of our Koha installation, 16.11.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would not consider this as a bug, you hyst need to fix the url ...right? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would not consider this as a bug, you just need to fix the url ...right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
I would not consider this as a bug, you just need to fix the url ...right?
Technically yes, but no visible error is thrown to the user, you are just silently signed out. Why fetch the 404 error template if we aren't displaying it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76797&action=edit Bug 18387: Allow sco-user to access errors templates To test: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in 7 - Apply patch 8 - Restart all the things 9 - Repeat 4 & 5 10 - Sucess, receipt prints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nick, please don't forget to set the assignee on your bugs! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It looks like we can be more precise and use the full path: errors/errorpage.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- This definitely makes the slip show and be printable, but can someone else confirm this weird behaviour I'm seeing, where the SCO slip comes out as uninterpreted HTML instead of nicely formatted? Also the behaviour seems to manifest on master right now with or without an asset going 404. It's all very perplexing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Should add that I was seeing this both with and without Jonathan's proposed modification. Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22641 [Bug 22641] Incorrect filter on SCO printslip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76797|0 |1 is obsolete| | --- Comment #11 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87420&action=edit Bug 18387: Allow sco-user to access errors templates To test: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in 7 - Apply patch 8 - Restart all the things 9 - Repeat 4 & 5 10 - Sucess, receipt prints Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #12 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87421&action=edit Bug 18387: (QA Follow up) adding specificity to error template. Per Jonathan's comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 87421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87421 Bug 18387: (QA Follow up) adding specificity to error template. Review of attachment 87421: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18387&attachment=87421) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +192,5 @@
if ( # If the user logged in is the SCO user and they try to go out of the SCO module, # log the user out removing the CGISESSID cookie + $in->{template_name} !~ m|sco/| && $in->{template_name} !~ m|errors/errorpage.tt| + &r C4::Context->preference('AutoSelfCheckID')
Looks like a typo here.. `&r` ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87421|0 |1 is obsolete| | --- Comment #14 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87657&action=edit Bug 18387: (QA Follow up) adding specificity to error template. (sorry) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No worries, I initially thought it was a new perl operator I hadn't come across. I'll do some testing proper tomorrow morning. Thanks Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87420|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 87845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87845&action=edit Bug 18387: Allow sco-user to access errors templates To test: 1 - Enable AuthoSelfCheck prefs 2 - In opacuserjs or scouserjs add a fetch of an unreachable resources 3 - Visit the SCO 4 - Sign in as a patron then click 'finish' 5 - Say 'yes' to receipt 6 - Note you are directed to log in 7 - Apply patch 8 - Restart all the things 9 - Repeat 4 & 5 10 - Sucess, receipt prints Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87657|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 87846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87846&action=edit Bug 18387: (QA Follow up) adding specificity to error template. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- 18.05.x is currently missing 22641 dependency, im not backporting this to 18.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23102 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102 [Bug 23102] 404 errors on page causes SCI user to be logged out -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org