[Bug 38492] New: Some javascript translatable strings do not get picked up for translation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Bug ID: 38492 Summary: Some javascript translatable strings do not get picked up for translation Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174832&action=edit Bug 38492: Update occurrences of _() to __() Test plan, ktd: 1) Generate translation files $ gulp po:update --lang de-DE 2) Verify that strings using _() do not exist on the pot file: $ cat -n misc/translator/Koha-messages-js.pot | grep "Copied!" $ cat -n misc/translator/Koha-messages-js.pot | grep "Form not submitted because of the following problem" $ cat -n misc/translator/Koha-messages-js.pot | grep "No matches found" 3) Apply patch. Repeat test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Questions: 1) Is function _(s) in staff-global.js and onboarding.js necessary? 2) Should we add this rule to the qa script (need to use double underscore in .js files, not single underscore)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 [Bug 36453] BlockExpiredPatronOpacActions should allow multiple actions options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Treating this one as a "follow-up" and picking it for master. Reviewed changes carefully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #2)
Questions: 1) Is function _(s) in staff-global.js and onboarding.js necessary?
Yes you have to define it, otherwise the calls will fail.
2) Should we add this rule to the qa script (need to use double underscore in .js files, not single underscore)?
yes, there is an issue already. https://gitlab.com/koha-community/qa-test-tools/-/issues/55 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38492 Bug 38492 depends on bug 36453, which changed state. Bug 36453 Summary: BlockExpiredPatronOpacActions should allow multiple actions options https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36453 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org