[Bug 37221] New: No way to turn off Overdrive integrations without removing all syspref values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Bug ID: 37221 Summary: No way to turn off Overdrive integrations without removing all syspref values Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org If the Overdrive API goes down, having this integration on at a busy site can cause backlogs due to timeouts that can only be mitigated by disabling the integration. As it stands to disable the integrations, you have to remove all of the values from the Overdrive preferences. It would be nice to be able to turn this integration on and off with a single syspref, retaining any previously supplied values for the overdrive integration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |Main Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168760&action=edit Bug 37221: Add preference to turn off OPAC Overdrive features This patch adds the preference "OPACOverDrive" to control whether OverDrive features are shown in the OPAC. This allows a library to disable OverDrive features without having to remove one or more of their OverDrive credentials. The patch also adds a check for the OPACOverDrive preference in the OverDrive search results page. If OverDrive is disabled, navigating to that page should give a 404. To test you will need OverDrive credentials to test with. - Apply the patch and run updatedatabase. - If you already had data in the OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret system preferences, the OPACOverDrive preference will be enabled when added. If not it will be disabled by default. - Rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> System preferences -> Enhanced content -> OverDrive. - If necessary, enter valid credentials in the OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret system preferences. - Set OPACOverDrive to "Don't enable." - In the OPAC perform a catalog search. Normally, if your credentials were correct OverDrive search results would automatically appear at the top of Koha's search results. Now there should be none. - Enable the OPACOverDrive preference and repeat your search. Now OverDrive results should appear. - Confirm that the OverDrive search results page works correctly. - Test that OverDrive circulation features are working by logging in to the OPAC as a user who has active OverDrive checkouts. - Enable the OPACOverDrive and OverDriveCirculation system preferences. - On the user's summary page there should be a tab for "OverDrive account." - The tab should not appear if either OPACOverDrive or OverDriveCirculation is disabled. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168760|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 169594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169594&action=edit Bug 37221: Add preference to turn off OPAC Overdrive features This patch adds the preference "OPACOverDrive" to control whether OverDrive features are shown in the OPAC. This allows a library to disable OverDrive features without having to remove one or more of their OverDrive credentials. The patch also adds a check for the OPACOverDrive preference in the OverDrive search results page. If OverDrive is disabled, navigating to that page should give a 404. To test you will need OverDrive credentials to test with. - Apply the patch and run updatedatabase. - If you already had data in the OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret system preferences, the OPACOverDrive preference will be enabled when added. If not it will be disabled by default. - Rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> System preferences -> Enhanced content -> OverDrive. - If necessary, enter valid credentials in the OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret system preferences. - Set OPACOverDrive to "Don't enable." - In the OPAC perform a catalog search. Normally, if your credentials were correct OverDrive search results would automatically appear at the top of Koha's search results. Now there should be none. - Enable the OPACOverDrive preference and repeat your search. Now OverDrive results should appear. - Confirm that the OverDrive search results page works correctly. - Test that OverDrive circulation features are working by logging in to the OPAC as a user who has active OverDrive checkouts. - Enable the OPACOverDrive and OverDriveCirculation system preferences. - On the user's summary page there should be a tab for "OverDrive account." - The tab should not appear if either OPACOverDrive or OverDriveCirculation is disabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169594|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173979&action=edit Bug 37221: Add preference to turn off OPAC Overdrive features This patch adds the preference "OPACOverDrive" to control whether OverDrive features are shown in the OPAC. This allows a library to disable OverDrive features without having to remove one or more of their OverDrive credentials. The patch also adds a check for the OPACOverDrive preference in the OverDrive search results page. If OverDrive is disabled, navigating to that page should give a 404. To test you will need OverDrive credentials to test with. - Apply the patch and run updatedatabase. - If you already had data in the OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret system preferences, the OPACOverDrive preference will be enabled when added. If not it will be disabled by default. - Rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> System preferences -> Enhanced content -> OverDrive. - If necessary, enter valid credentials in the OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret system preferences. - Set OPACOverDrive to "Don't enable." - In the OPAC perform a catalog search. Normally, if your credentials were correct OverDrive search results would automatically appear at the top of Koha's search results. Now there should be none. - Enable the OPACOverDrive preference and repeat your search. Now OverDrive results should appear. - Confirm that the OverDrive search results page works correctly. - Test that OverDrive circulation features are working by logging in to the OPAC as a user who has active OverDrive checkouts. - Enable the OPACOverDrive and OverDriveCirculation system preferences. - On the user's summary page there should be a tab for "OverDrive account." - The tab should not appear if either OPACOverDrive or OverDriveCirculation is disabled. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173979|0 |1 is obsolete| | --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174036&action=edit Bug 37221: Add preference to turn off OPAC Overdrive features This patch adds the preference "OPACOverDrive" to control whether OverDrive features are shown in the OPAC. This allows a library to disable OverDrive features without having to remove one or more of their OverDrive credentials. The patch also adds a check for the OPACOverDrive preference in the OverDrive search results page. If OverDrive is disabled, navigating to that page should give a 404. To test you will need OverDrive credentials to test with. - Apply the patch and run updatedatabase. - If you already had data in the OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret system preferences, the OPACOverDrive preference will be enabled when added. If not it will be disabled by default. - Rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> System preferences -> Enhanced content -> OverDrive. - If necessary, enter valid credentials in the OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret system preferences. - Set OPACOverDrive to "Don't enable." - In the OPAC perform a catalog search. Normally, if your credentials were correct OverDrive search results would automatically appear at the top of Koha's search results. Now there should be none. - Enable the OPACOverDrive preference and repeat your search. Now OverDrive results should appear. - Confirm that the OverDrive search results page works correctly. - Test that OverDrive circulation features are working by logging in to the OPAC as a user who has active OverDrive checkouts. - Enable the OPACOverDrive and OverDriveCirculation system preferences. - On the user's summary page there should be a tab for "OverDrive account." - The tab should not appear if either OPACOverDrive or OverDriveCirculation is disabled. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I like seeing these big on/off switches. Everything looks good here so I am passing QA. Is there a reason I need to Rebuild the staff interface CSS? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass (lukeg) from comment #5)
Is there a reason I need to Rebuild the staff interface CSS?
Obviously my mistake since there are no CSS changes. Perhaps I made a change which I later rejected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #6)
(In reply to Lucas Gass (lukeg) from comment #5)
Is there a reason I need to Rebuild the staff interface CSS?
Obviously my mistake since there are no CSS changes. Perhaps I made a change which I later rejected.
Thanks for confirming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No way to turn off |No way to turn off |Overdrive integrations |OverDrive integrations |without removing all |without removing all system |syspref values |preference values Text to go in the| |This patch adds the new release notes| |system preference | |`OPACOverDrive`. It allows | |a library to disable | |OverDrive features without | |having to remove one or | |more of their OverDrive | |credentials. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1052 Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37221 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Manual updated. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org