https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #1 from Kelly McElligott <kelly@bywatersolutions.com> --- As an enhancement to Koha's Marc Modification Template, it would be extremely helpful to include indicators as part of this process. A lot of libraries would like an easy way to remove their 7 indicators in 650 tags. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hayleymapley@catalyst.net.n |ity.org |z CC| |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #3 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- This would be such a great time saver. Currently we have to create a report to capture the correct bibs, export them, update and import them back in. It would be great to be able to do it in Koha instead. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- +1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Marci <mchen@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mchen@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov --- Comment #7 from Heather <heather_hernandez@nps.gov> --- This would be SO helpful!! There hasn't yet been one instance that I've been able to try using the MARC modification templates because every way they'd be helpful for us involves essential information from the indicators, changes to the indicators, etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Are you working on this one Hayley? Would be lovely to see some code. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #10 from AspenCat Team <aspencatteam@clicweb.org> --- If the field we are adding has indicators that are significant, this would enable user to do this action in Koha. Without it, I would need to use MarcEdit to change the indicators, so I might as well use it to add the field at the same time. If we can do this in Koha rather than outside of Koha, it would vastly streamline the process and allow users without MarcEdit experience to change bibs by simply selecting the correct Marc Modification Template. Another alternative would be if one could add a run a macro as an action in the marc modification template, since we can change indicators using a macro. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #12 from Heather <heather_hernandez@nps.gov> --- Exactly, Laura! We would love to be able to do that, but can't with the templates unable to act based on indicator data. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #13 from AspenCat Team <aspencatteam@clicweb.org> --- Is this a particularly difficult enhancement? It would be super helpful. Bug initially created in 2018. Does it need to be a paid-for development? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Offers of sponsorship always help a bug move forward, else a developer is either trying to justify time working on a bug to their boss for no obvious financial reward or working on the bug in their spare time. As for paxed comment regarding difficulty and C4 vs Koha.. I would say this is an area where you could happily continue in C4 space. It's not a hard requirement to rewrite the whole of Koha to refine an existing feature.. QA would push for Unit tests however, even for a C4 change.. but that's just standard good practice. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Enica Davis <enica@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |enica@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hayleypelham@ownmail.net |koha-bugs@lists.koha-commun | |ity.org CC| |david@davidnind.com Status|ASSIGNED |NEW --- Comment #17 from David Nind <david@davidnind.com> --- (In reply to Mathieu Saby from comment #16)

Hi It would be useful for unimarc users too. I see the bug is assigned. Is someone working on it ?

I don't think it is being worked on at the moment. I have changed to unassigned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #19 from George Williams (NEKLS) <george@nekls.org> --- +1 - This would be a big help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Kati Sillgren <kati.sillgren@porvoo.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kati.sillgren@porvoo.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Mikko Liimatainen <mikko.liimatainen@turku.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikko.liimatainen@turku.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://bywatersolutions.co | |m/crowdsourcing/marc-indica | |tors --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I've added the URL for Bywater's crowdfunding page for this enhancement, where koha-US has pledged half of the cost of this development. ByWater is currently seeking funders for the remaining cost. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Christine Lee <chlee@pascolibraries.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chlee@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu --- Comment #23 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- +1, would love to see this capability! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 ahennig@hotchkiss.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahennig@hotchkiss.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Mark Hofstetter <koha@trust-box.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@trust-box.at --- Comment #26 from Mark Hofstetter <koha@trust-box.at> --- somewhat related if you want to modify a lot of records: https://github.com/HKS3/koha-normalize-marc2db eg removeing all indicators with a certain value eg ind2=7 of all 650 would be a trivial SQL update command. Notwithstanding it would be great if marc modification template could handle indicators -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 John Sterbenz <jsterben@umich.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsterben@umich.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 crosenthal@pwcgov.org <crosenthal@pwcgov.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crosenthal@pwcgov.org --- Comment #29 from crosenthal@pwcgov.org <crosenthal@pwcgov.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Strategic theme|--- |User Experience -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #42 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 203563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203563&action=edit Bug 21860: Add indicator matching to field_exists -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #44 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 203565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203565&action=edit Bug 21860: Store and apply MARC indicator criteria -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #46 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 203567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203567&action=edit Bug 21860: atomicupdate to alter marc_modification_template_actions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #47 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 203568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203568&action=edit Bug 21860: Add indicator matching to field_exists -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #49 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 203570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203570&action=edit Bug 21860: Store and apply MARC indicator criteria -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #51 from catherine.micklethwaite@nhs.net --- Could I be really cheeky and ask for one very specific test? The way we would like to use this with the 650 fields is: Import the 650 only if indicator 2 = 2, delete all other 650 fields. Huge thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #53 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to catherine.micklethwaite from comment #51)

Could I be really cheeky and ask for one very specific test? The way we would like to use this with the 650 fields is:

Import the 650 only if indicator 2 = 2, delete all other 650 fields.

Huge thanks

This works! I was able to create a template to delete those tags and apply it to a file at import. But note the way actions are currently defined doesn't give us any want to say "delete any 650 where the 2nd indicator *isn't* 2." Instead one needs to create several distinct actions: delete 650s where the 2nd indicator is blank, delete 650s where the 2nd indicator is 1, delete 650s where the 2nd indicator is 3, etc. -- this behavior is unrelated to this enhancement, you'd run into the same issue trying to do something like deleting all 650s where the $a isn't "Dogs" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203568|0 |1 is obsolete| | Attachment #203569|0 |1 is obsolete| | Attachment #203570|0 |1 is obsolete| | Attachment #203571|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #55 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 203639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203639&action=edit Bug 21860: Add indicator matching to field_equals -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #57 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 203641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203641&action=edit Bug 21860: Apply MARC indicators in modification templates Test plan 1. Apply the database update for this bug if it has not already been applied. 2. Run the automated tests: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t Both tests should pass. Also run: perl -c C4/MarcModificationTemplates.pm perl -c Koha/SimpleMARC.pm node --check koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js git diff --check The Perl files should report "syntax OK". The JavaScript syntax check and git diff --check should return no errors. MARC modification template UI ----------------------------- 3. Go to: Tools > MARC modification templates 4. Create a new template named: Bug 21860 indicator test 5. Test whole-field copy with source and destination indicators. Add a new action with: Action: Copy Field number: All Source field: 650 Source subfield: blank Check "Use indicators" Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: one blank space Destination indicator 2: 0 Condition: blank Description: Copy 650 ind 1/7 to 651 ind blank/0 6. Save the action. 7. Confirm that the action summary displays the source and destination indicators, for example: Copy field 650 (ind1: 1, ind2: 7) to 651 (ind1: , ind2: 0) 8. Click Edit on the action. 9. Confirm that all saved values are restored: - Use indicators is checked - Source field is 650 - Source indicator 1 is 1 - Source indicator 2 is 7 - Destination field is 651 - Destination indicator 1 is blank - Destination indicator 2 is 0 10. Change destination indicator 2 to another value, save the action, then edit it again. Confirm that the updated indicator value is retained. Conditional indicators ---------------------- 11. Test conditional indicators. Add or edit an action with: Action: Copy Source field: 650 Source indicators: 1 / 7 Destination field: 651 Destination indicators: blank / 0 Condition: if Conditional field: 650 Conditional subfield: blank Conditional indicator 1: 1 Conditional indicator 2: 7 Comparison: exists 12. Save the action. 13. Confirm that the action summary displays the conditional indicators, for example: Copy field 650 (ind1: 1, ind2: 7) to 651 (ind1: , ind2: 0) if 650 (ind1: 1, ind2: 7) exists 14. Edit the action again and confirm that the conditional indicator values are restored. Form reset behavior ------------------- 15. Test form reset behavior. - Edit an existing action containing indicator values. - Click Cancel. - Click New action. - Confirm that "Use indicators" is unchecked. - Check "Use indicators". - Confirm that the source, destination, and conditional indicator fields do not contain values from the previously edited action. Control fields -------------- 16. Test control fields as the source. Create a Copy action and enter 008 as the source field. Check "Use indicators". Confirm that: - the source indicator inputs are not displayed - indicator controls are not offered for the 008 field 17. Enter 650 as the destination field. Confirm that: - destination indicator 1 and indicator 2 inputs are displayed - source indicator inputs remain hidden for 008 18. Test the reverse direction. Source field: 650 Destination field: 008 Use indicators: checked Confirm that: - source indicator inputs are displayed for 650 - destination indicator inputs are not displayed for 008 19. Test a control field as the conditional field. Select a condition such as "if" and enter 008 as the conditional field. Confirm that conditional indicator inputs are not displayed. 20. Change the conditional field to 650. Confirm that conditional indicator 1 and indicator 2 inputs become available. Functional testing against a bibliographic record ------------------------------------------------- 21. Create or edit a test bibliographic record so that it contains at least these two fields: 650 17 $a Dogs 650 _0 $a Cats In the examples above, "_" represents a literal blank MARC indicator. The two fields deliberately use different indicators so that indicator matching can be verified. Source indicator filtering -------------------------- 22. Create a new MARC modification template/action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 23. Apply the template to the test bibliographic record using: Tools > Batch record modification 24. Open the modified bibliographic record. Expected result: 650 17 $a Dogs 650 _0 $a Cats 651 17 $a Dogs There should NOT be a new: 651 _0 $a Cats This confirms that source indicator criteria select only fields whose indicators match 1/7. Explicit blank source indicator ------------------------------- 25. Create another action using: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: one literal blank space Source indicator 2: 0 Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 26. Apply the template to the test record. Expected result: 651 _0 $a Cats The following should NOT be copied by this action: 650 17 $a Dogs This confirms that a literal blank MARC indicator can be explicitly matched and is distinct from leaving an indicator criterion unset. Partial source indicator matching --------------------------------- 27. Create another action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: leave unset Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 28. Apply the template. Expected result: 651 17 $a Dogs The following should NOT be copied: 650 _0 $a Cats This confirms that an unset source indicator does not require a blank indicator. Instead, no restriction is applied for that indicator position. Explicit destination indicators ------------------------------- 29. Create another action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: one literal blank space Destination indicator 2: 0 30. Apply the template. Expected destination field: 651 _0 $a Dogs Confirm in the MARC editor that: - indicator 1 is blank - indicator 2 is 0 - $a contains Dogs This confirms that explicitly supplied destination indicators replace the source indicators on the newly created destination field. Unset destination indicators ---------------------------- 31. Repeat the copy from: 650 17 $a Dogs to field 651, but leave both destination indicators completely unset. Expected destination: 651 17 $a Dogs This confirms that when destination indicators are not supplied, the source field's indicators are preserved. Regression testing ------------------ 32. Create a MARC modification template action without selecting "Use indicators". Configure a normal existing MARC modification operation. 33. Save, edit, and apply the action. Confirm that the action behaves as it did before this enhancement and that indicator criteria are not required. 34. Confirm that existing MARC modification template actions created before this enhancement can still be viewed, edited, and applied without adding indicator criteria. Additional functional coverage ------------------------------ 35. Test Move with indicators against a bibliographic record. Verify that: - only the source field matching the specified indicators is moved - the source field is removed - the destination field is created - explicitly supplied destination indicators are applied - unrelated fields are unchanged 36. Test Copy and replace with indicators against a bibliographic record. Verify that: - only fields matching the source indicator criteria participate in the operation - the destination receives the expected value - explicitly supplied destination indicators are applied - unrelated fields are unchanged 37. Test a conditional indicator criterion against an actual bibliographic record. Use a record containing fields with different indicators. Confirm that the action runs when the conditional field has the requested indicators. 38. Repeat the conditional test using indicators that do not match the record. Confirm that the action does not run. 39. Confirm the resulting MARC record after each functional test and verify that no unrelated fields or indicators have been modified. 40. Sign off and have a wonderful day! :D Sponsored-by: koha-US <https://koha-us.org/> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #59 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Follow-up addresses QA findings: no matching indicator no longer causes the action to run against all matching tags; added regression coverage for that case; conditional indicator values are retained when editing; control fields no longer display indicator summaries; blank indicators are entered/displayed as _, while empty means unset; moved “Use indicators” to clarify that it applies to the entire action. QA tools and both automated test suites pass. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 John Vinke <jvinke@austinseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jvinke@austinseminary.edu | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203638|0 |1 is obsolete| | Attachment #203639|0 |1 is obsolete| | Attachment #203640|0 |1 is obsolete| | Attachment #203641|0 |1 is obsolete| | Attachment #203642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #62 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 203861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203861&action=edit Bug 21860: Add indicator matching to field_equals Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #64 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 203863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203863&action=edit Bug 21860: Apply MARC indicators in modification templates Test plan 1. Apply the database update for this bug if it has not already been applied. 2. Run the automated tests: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t Both tests should pass. Also run: perl -c C4/MarcModificationTemplates.pm perl -c Koha/SimpleMARC.pm node --check koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js git diff --check The Perl files should report "syntax OK". The JavaScript syntax check and git diff --check should return no errors. MARC modification template UI ----------------------------- 3. Go to: Tools > MARC modification templates 4. Create a new template named: Bug 21860 indicator test 5. Test whole-field copy with source and destination indicators. Add a new action with: Action: Copy Field number: All Source field: 650 Source subfield: blank Check "Use indicators" Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: one blank space Destination indicator 2: 0 Condition: blank Description: Copy 650 ind 1/7 to 651 ind blank/0 6. Save the action. 7. Confirm that the action summary displays the source and destination indicators, for example: Copy field 650 (ind1: 1, ind2: 7) to 651 (ind1: , ind2: 0) 8. Click Edit on the action. 9. Confirm that all saved values are restored: - Use indicators is checked - Source field is 650 - Source indicator 1 is 1 - Source indicator 2 is 7 - Destination field is 651 - Destination indicator 1 is blank - Destination indicator 2 is 0 10. Change destination indicator 2 to another value, save the action, then edit it again. Confirm that the updated indicator value is retained. Conditional indicators ---------------------- 11. Test conditional indicators. Add or edit an action with: Action: Copy Source field: 650 Source indicators: 1 / 7 Destination field: 651 Destination indicators: blank / 0 Condition: if Conditional field: 650 Conditional subfield: blank Conditional indicator 1: 1 Conditional indicator 2: 7 Comparison: exists 12. Save the action. 13. Confirm that the action summary displays the conditional indicators, for example: Copy field 650 (ind1: 1, ind2: 7) to 651 (ind1: , ind2: 0) if 650 (ind1: 1, ind2: 7) exists 14. Edit the action again and confirm that the conditional indicator values are restored. Form reset behavior ------------------- 15. Test form reset behavior. - Edit an existing action containing indicator values. - Click Cancel. - Click New action. - Confirm that "Use indicators" is unchecked. - Check "Use indicators". - Confirm that the source, destination, and conditional indicator fields do not contain values from the previously edited action. Control fields -------------- 16. Test control fields as the source. Create a Copy action and enter 008 as the source field. Check "Use indicators". Confirm that: - the source indicator inputs are not displayed - indicator controls are not offered for the 008 field 17. Enter 650 as the destination field. Confirm that: - destination indicator 1 and indicator 2 inputs are displayed - source indicator inputs remain hidden for 008 18. Test the reverse direction. Source field: 650 Destination field: 008 Use indicators: checked Confirm that: - source indicator inputs are displayed for 650 - destination indicator inputs are not displayed for 008 19. Test a control field as the conditional field. Select a condition such as "if" and enter 008 as the conditional field. Confirm that conditional indicator inputs are not displayed. 20. Change the conditional field to 650. Confirm that conditional indicator 1 and indicator 2 inputs become available. Functional testing against a bibliographic record ------------------------------------------------- 21. Create or edit a test bibliographic record so that it contains at least these two fields: 650 17 $a Dogs 650 _0 $a Cats In the examples above, "_" represents a literal blank MARC indicator. The two fields deliberately use different indicators so that indicator matching can be verified. Source indicator filtering -------------------------- 22. Create a new MARC modification template/action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 23. Apply the template to the test bibliographic record using: Tools > Batch record modification 24. Open the modified bibliographic record. Expected result: 650 17 $a Dogs 650 _0 $a Cats 651 17 $a Dogs There should NOT be a new: 651 _0 $a Cats This confirms that source indicator criteria select only fields whose indicators match 1/7. Explicit blank source indicator ------------------------------- 25. Create another action using: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: one literal blank space Source indicator 2: 0 Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 26. Apply the template to the test record. Expected result: 651 _0 $a Cats The following should NOT be copied by this action: 650 17 $a Dogs This confirms that a literal blank MARC indicator can be explicitly matched and is distinct from leaving an indicator criterion unset. Partial source indicator matching --------------------------------- 27. Create another action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: leave unset Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 28. Apply the template. Expected result: 651 17 $a Dogs The following should NOT be copied: 650 _0 $a Cats This confirms that an unset source indicator does not require a blank indicator. Instead, no restriction is applied for that indicator position. Explicit destination indicators ------------------------------- 29. Create another action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: one literal blank space Destination indicator 2: 0 30. Apply the template. Expected destination field: 651 _0 $a Dogs Confirm in the MARC editor that: - indicator 1 is blank - indicator 2 is 0 - $a contains Dogs This confirms that explicitly supplied destination indicators replace the source indicators on the newly created destination field. Unset destination indicators ---------------------------- 31. Repeat the copy from: 650 17 $a Dogs to field 651, but leave both destination indicators completely unset. Expected destination: 651 17 $a Dogs This confirms that when destination indicators are not supplied, the source field's indicators are preserved. Regression testing ------------------ 32. Create a MARC modification template action without selecting "Use indicators". Configure a normal existing MARC modification operation. 33. Save, edit, and apply the action. Confirm that the action behaves as it did before this enhancement and that indicator criteria are not required. 34. Confirm that existing MARC modification template actions created before this enhancement can still be viewed, edited, and applied without adding indicator criteria. Additional functional coverage ------------------------------ 35. Test Move with indicators against a bibliographic record. Verify that: - only the source field matching the specified indicators is moved - the source field is removed - the destination field is created - explicitly supplied destination indicators are applied - unrelated fields are unchanged 36. Test Copy and replace with indicators against a bibliographic record. Verify that: - only fields matching the source indicator criteria participate in the operation - the destination receives the expected value - explicitly supplied destination indicators are applied - unrelated fields are unchanged 37. Test a conditional indicator criterion against an actual bibliographic record. Use a record containing fields with different indicators. Confirm that the action runs when the conditional field has the requested indicators. 38. Repeat the conditional test using indicators that do not match the record. Confirm that the action does not run. 39. Confirm the resulting MARC record after each functional test and verify that no unrelated fields or indicators have been modified. 40. Sign off and have a wonderful day! :D Sponsored-by: koha-US <https://koha-us.org/> Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- QA findings: 1) kohastructure.sql ln 4756 there is an additional ');' which will break fresh installs 2) The indicators aren't being passed if the action is 'update_field' - is this a deliberate design choice or has it been missed? Indicators aren't affected using a template when updating as it stands. (C4::MarcModificationTemplates ln 832) 3) C4::MarcModificationTemplates ln 774 the loop skips to the next iteration if no matching field is found but when the action is update_field the _update_subfield method in Koha::SimpleMARC wants to create the subfield if it doesn't exist. This can't happen as we have already skipped through to the next loop iteration so we silently miss out on creating the new field 4) _copy_move_field is setting the indicators before transferring to the new tag. This could crash if the source was a control field - see https://metacpan.org/dist/MARC-Record/source/lib/MARC/Field.pm#L190. The indicators should be set after $new_field->{_tag} to prevent this 5) There's some duplication of logic between toggleCharacterPositionField and toggleIndicatorFields - could toggleCharacterPositionField not just call toggleIndicatorFields to ensure standard application of the logic? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203860|0 |1 is obsolete| | Attachment #203861|0 |1 is obsolete| | Attachment #203862|0 |1 is obsolete| | Attachment #203863|0 |1 is obsolete| | Attachment #203864|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #68 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 204340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204340&action=edit Bug 21860: Add indicator matching to field_equals Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #70 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 204342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204342&action=edit Bug 21860: Apply MARC indicators in modification templates Test plan 1. Apply the database update for this bug if it has not already been applied. 2. Run the automated tests: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t Both tests should pass. Also run: perl -c C4/MarcModificationTemplates.pm perl -c Koha/SimpleMARC.pm node --check koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js git diff --check The Perl files should report "syntax OK". The JavaScript syntax check and git diff --check should return no errors. MARC modification template UI ----------------------------- 3. Go to: Tools > MARC modification templates 4. Create a new template named: Bug 21860 indicator test 5. Test whole-field copy with source and destination indicators. Add a new action with: Action: Copy Field number: All Source field: 650 Source subfield: blank Check "Use indicators" Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: one blank space Destination indicator 2: 0 Condition: blank Description: Copy 650 ind 1/7 to 651 ind blank/0 6. Save the action. 7. Confirm that the action summary displays the source and destination indicators, for example: Copy field 650 (ind1: 1, ind2: 7) to 651 (ind1: , ind2: 0) 8. Click Edit on the action. 9. Confirm that all saved values are restored: - Use indicators is checked - Source field is 650 - Source indicator 1 is 1 - Source indicator 2 is 7 - Destination field is 651 - Destination indicator 1 is blank - Destination indicator 2 is 0 10. Change destination indicator 2 to another value, save the action, then edit it again. Confirm that the updated indicator value is retained. Conditional indicators ---------------------- 11. Test conditional indicators. Add or edit an action with: Action: Copy Source field: 650 Source indicators: 1 / 7 Destination field: 651 Destination indicators: blank / 0 Condition: if Conditional field: 650 Conditional subfield: blank Conditional indicator 1: 1 Conditional indicator 2: 7 Comparison: exists 12. Save the action. 13. Confirm that the action summary displays the conditional indicators, for example: Copy field 650 (ind1: 1, ind2: 7) to 651 (ind1: , ind2: 0) if 650 (ind1: 1, ind2: 7) exists 14. Edit the action again and confirm that the conditional indicator values are restored. Form reset behavior ------------------- 15. Test form reset behavior. - Edit an existing action containing indicator values. - Click Cancel. - Click New action. - Confirm that "Use indicators" is unchecked. - Check "Use indicators". - Confirm that the source, destination, and conditional indicator fields do not contain values from the previously edited action. Control fields -------------- 16. Test control fields as the source. Create a Copy action and enter 008 as the source field. Check "Use indicators". Confirm that: - the source indicator inputs are not displayed - indicator controls are not offered for the 008 field 17. Enter 650 as the destination field. Confirm that: - destination indicator 1 and indicator 2 inputs are displayed - source indicator inputs remain hidden for 008 18. Test the reverse direction. Source field: 650 Destination field: 008 Use indicators: checked Confirm that: - source indicator inputs are displayed for 650 - destination indicator inputs are not displayed for 008 19. Test a control field as the conditional field. Select a condition such as "if" and enter 008 as the conditional field. Confirm that conditional indicator inputs are not displayed. 20. Change the conditional field to 650. Confirm that conditional indicator 1 and indicator 2 inputs become available. Functional testing against a bibliographic record ------------------------------------------------- 21. Create or edit a test bibliographic record so that it contains at least these two fields: 650 17 $a Dogs 650 _0 $a Cats In the examples above, "_" represents a literal blank MARC indicator. The two fields deliberately use different indicators so that indicator matching can be verified. Source indicator filtering -------------------------- 22. Create a new MARC modification template/action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 23. Apply the template to the test bibliographic record using: Tools > Batch record modification 24. Open the modified bibliographic record. Expected result: 650 17 $a Dogs 650 _0 $a Cats 651 17 $a Dogs There should NOT be a new: 651 _0 $a Cats This confirms that source indicator criteria select only fields whose indicators match 1/7. Explicit blank source indicator ------------------------------- 25. Create another action using: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: one literal blank space Source indicator 2: 0 Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 26. Apply the template to the test record. Expected result: 651 _0 $a Cats The following should NOT be copied by this action: 650 17 $a Dogs This confirms that a literal blank MARC indicator can be explicitly matched and is distinct from leaving an indicator criterion unset. Partial source indicator matching --------------------------------- 27. Create another action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: leave unset Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 28. Apply the template. Expected result: 651 17 $a Dogs The following should NOT be copied: 650 _0 $a Cats This confirms that an unset source indicator does not require a blank indicator. Instead, no restriction is applied for that indicator position. Explicit destination indicators ------------------------------- 29. Create another action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: one literal blank space Destination indicator 2: 0 30. Apply the template. Expected destination field: 651 _0 $a Dogs Confirm in the MARC editor that: - indicator 1 is blank - indicator 2 is 0 - $a contains Dogs This confirms that explicitly supplied destination indicators replace the source indicators on the newly created destination field. Unset destination indicators ---------------------------- 31. Repeat the copy from: 650 17 $a Dogs to field 651, but leave both destination indicators completely unset. Expected destination: 651 17 $a Dogs This confirms that when destination indicators are not supplied, the source field's indicators are preserved. Regression testing ------------------ 32. Create a MARC modification template action without selecting "Use indicators". Configure a normal existing MARC modification operation. 33. Save, edit, and apply the action. Confirm that the action behaves as it did before this enhancement and that indicator criteria are not required. 34. Confirm that existing MARC modification template actions created before this enhancement can still be viewed, edited, and applied without adding indicator criteria. Additional functional coverage ------------------------------ 35. Test Move with indicators against a bibliographic record. Verify that: - only the source field matching the specified indicators is moved - the source field is removed - the destination field is created - explicitly supplied destination indicators are applied - unrelated fields are unchanged 36. Test Copy and replace with indicators against a bibliographic record. Verify that: - only fields matching the source indicator criteria participate in the operation - the destination receives the expected value - explicitly supplied destination indicators are applied - unrelated fields are unchanged 37. Test a conditional indicator criterion against an actual bibliographic record. Use a record containing fields with different indicators. Confirm that the action runs when the conditional field has the requested indicators. 38. Repeat the conditional test using indicators that do not match the record. Confirm that the action does not run. 39. Confirm the resulting MARC record after each functional test and verify that no unrelated fields or indicators have been modified. 40. Sign off and have a wonderful day! :D Sponsored-by: koha-US <https://koha-us.org/> Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #72 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 204344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204344&action=edit Bug 21860: Address QA findings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #75 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Fingers crossed that it all looks good! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204342|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #77 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 204981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204981&action=edit Bug 21860: Add indicator matching to field_exists Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #79 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 204983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204983&action=edit Bug 21860: Store and apply MARC indicator criteria Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #81 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 204985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204985&action=edit Bug 21860: Fix indicator handling and display Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #83 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 204987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204987&action=edit Bug 21860: Address additional QA findings Addressed the additional QA findings. * Updated update_field indicator handling so indicators are treated as values to update rather than match criteria. Existing fields are now updated in place rather than creating a duplicate when the requested indicator differs. * Preserved the "add new" behavior when the target field/subfield does not exist. * Moved the _ to MARC blank indicator conversion until after form validation succeeds, so failed validation does not alter the displayed indicator values. * Added/updated regression coverage for updating indicators on an existing field. Manually tested both update and add-new behavior in the staff interface, including the reported 650 _0 → 650 70 case and the failed-validation _ behavior. QA tools and tests pass: * t/SimpleMARC.t * t/db_dependent/MarcModificationTemplates.t * node --check * git diff --check * qa Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #84 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, 3 findings here worth addressing: Finding 1: 'Add new' ignores the indicators you type 1) Apply the patches, updatedatabase and restart_all 2) Go to Cataloging > MARC modification templates: http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl 3) Create a new template, name it 'Bug 21860 add' 4) Action: 'Add new', field 650, subfield a, with value 'Dogs' 5) Check 'Use indicators'. Enter indicator 1 = '1' and indicator 2 = '7' in the inputs that appear. Click 'Add action' 6) Preview the template on biblio 1 (this assumes the template id is 1, check the template_id in the URL): http://localhost:8081/cgi-bin/koha/svc/records/preview?record_type=biblio&record_id=1&mmtid=1&overlay_context=batchmod 7) Look at the new 650 $a Dogs => Expected: 650 17 $a Dogs (the indicators you entered) => Actual: 650 __ $a Dogs (the indicators are ignored, left blank) Finding 2: 'Update existing or add new' with 'Use indicators' splits the field This follows on from the fix for comments 66 (point 3) and 73. Comment 74 says the 'add new' behavior is preserved when the target field/subfield does not exist. That's right when the field doesn't exist, but when the field exists and only the subfield is missing, it now creates a new field instead of adding the subfield to the existing one. 1) In the same tool, create a new template, name it 'Bug 21860 update' 2) Action: 'Update existing or add new', field 650, subfield x, with value 'Moral aspects'. Click 'Add action' 3) Preview it on biblio 1 (650 _0 $a Rock musicians (...)), this assumes the template id is 2: http://localhost:8081/cgi-bin/koha/svc/records/preview?record_type=biblio&record_id=1&mmtid=2&overlay_context=batchmod 4) Confirm you get one field: 650 _0 $a Rock musicians (...) $x Moral aspects 5) Edit the action, check 'Use indicators', enter indicator 2 = '0', save it 6) Repeat 3) => Expected: the same single field as 4), 650 _0 $a Rock musicians (...) $x Moral aspects ('Use indicators' should only set the indicators) => Actual: two fields, 650 _0 $a Rock musicians (...) and a separate 650 _0 $x Moral aspects (the heading is split in two) Finding 3: copying a repeated subfield picks the value from the wrong field 1) Edit biblio 1 in the basic editor: http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=1 2) In the existing 650 _0 $a Rock musicians (...), add $x History and a second $x Criticism 3) Add a new 650 with indicator 2 = 7: $a Dogs $x Training $2 fast. Save the record 4) Confirm biblio 1 now has these two 650s: 650 _0 $a Rock musicians (...) $x History $x Criticism 650 _7 $a Dogs $x Training $2 fast 5) Create a new template, name it 'Bug 21860 copy' 6) Action: 'Copy', field(s) 'All', field 650 subfield x, to field 651 subfield x 7) Check 'Use indicators', enter source indicator 2 = '7'. Click 'Add action' 8) Preview it on biblio 1, this assumes the template id is 3: http://localhost:8081/cgi-bin/koha/svc/records/preview?record_type=biblio&record_id=1&mmtid=3&overlay_context=batchmod => Expected: 651 $x Training (from the 650 with indicator 2 = 7, the only field matching the indicators) => Actual: 651 $x Criticism (only the 650 with indicator 2 = 0 has this value) Minor notes: - AddModificationTemplateAction and ModModificationTemplateAction now take the new arguments in the middle of the list. All callers in Koha are updated, but any plugin or local script using the old order would silently save values into the wrong columns. Adding them at the end, or switching to a hashref, would avoid that. - The ModModificationTemplateAction POD lists $from_field twice (C4/MarcModificationTemplates.pm line 344). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204981|0 |1 is obsolete| | Attachment #204982|0 |1 is obsolete| | Attachment #204983|0 |1 is obsolete| | Attachment #204984|0 |1 is obsolete| | Attachment #204985|0 |1 is obsolete| | Attachment #204986|0 |1 is obsolete| | Attachment #204987|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #86 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206856&action=edit Bug 21860: Add indicator matching to field_equals Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #88 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206858&action=edit Bug 21860: Apply MARC indicators in modification templates Test plan 1. Apply the database update for this bug if it has not already been applied. 2. Run the automated tests: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t Both tests should pass. Also run: perl -c C4/MarcModificationTemplates.pm perl -c Koha/SimpleMARC.pm node --check koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js git diff --check The Perl files should report "syntax OK". The JavaScript syntax check and git diff --check should return no errors. MARC modification template UI ----------------------------- 3. Go to: Tools > MARC modification templates 4. Create a new template named: Bug 21860 indicator test 5. Test whole-field copy with source and destination indicators. Add a new action with: Action: Copy Field number: All Source field: 650 Source subfield: blank Check "Use indicators" Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: one blank space Destination indicator 2: 0 Condition: blank Description: Copy 650 ind 1/7 to 651 ind blank/0 6. Save the action. 7. Confirm that the action summary displays the source and destination indicators, for example: Copy field 650 (ind1: 1, ind2: 7) to 651 (ind1: , ind2: 0) 8. Click Edit on the action. 9. Confirm that all saved values are restored: - Use indicators is checked - Source field is 650 - Source indicator 1 is 1 - Source indicator 2 is 7 - Destination field is 651 - Destination indicator 1 is blank - Destination indicator 2 is 0 10. Change destination indicator 2 to another value, save the action, then edit it again. Confirm that the updated indicator value is retained. Conditional indicators ---------------------- 11. Test conditional indicators. Add or edit an action with: Action: Copy Source field: 650 Source indicators: 1 / 7 Destination field: 651 Destination indicators: blank / 0 Condition: if Conditional field: 650 Conditional subfield: blank Conditional indicator 1: 1 Conditional indicator 2: 7 Comparison: exists 12. Save the action. 13. Confirm that the action summary displays the conditional indicators, for example: Copy field 650 (ind1: 1, ind2: 7) to 651 (ind1: , ind2: 0) if 650 (ind1: 1, ind2: 7) exists 14. Edit the action again and confirm that the conditional indicator values are restored. Form reset behavior ------------------- 15. Test form reset behavior. - Edit an existing action containing indicator values. - Click Cancel. - Click New action. - Confirm that "Use indicators" is unchecked. - Check "Use indicators". - Confirm that the source, destination, and conditional indicator fields do not contain values from the previously edited action. Control fields -------------- 16. Test control fields as the source. Create a Copy action and enter 008 as the source field. Check "Use indicators". Confirm that: - the source indicator inputs are not displayed - indicator controls are not offered for the 008 field 17. Enter 650 as the destination field. Confirm that: - destination indicator 1 and indicator 2 inputs are displayed - source indicator inputs remain hidden for 008 18. Test the reverse direction. Source field: 650 Destination field: 008 Use indicators: checked Confirm that: - source indicator inputs are displayed for 650 - destination indicator inputs are not displayed for 008 19. Test a control field as the conditional field. Select a condition such as "if" and enter 008 as the conditional field. Confirm that conditional indicator inputs are not displayed. 20. Change the conditional field to 650. Confirm that conditional indicator 1 and indicator 2 inputs become available. Functional testing against a bibliographic record ------------------------------------------------- 21. Create or edit a test bibliographic record so that it contains at least these two fields: 650 17 $a Dogs 650 _0 $a Cats In the examples above, "_" represents a literal blank MARC indicator. The two fields deliberately use different indicators so that indicator matching can be verified. Source indicator filtering -------------------------- 22. Create a new MARC modification template/action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 23. Apply the template to the test bibliographic record using: Tools > Batch record modification 24. Open the modified bibliographic record. Expected result: 650 17 $a Dogs 650 _0 $a Cats 651 17 $a Dogs There should NOT be a new: 651 _0 $a Cats This confirms that source indicator criteria select only fields whose indicators match 1/7. Explicit blank source indicator ------------------------------- 25. Create another action using: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: one literal blank space Source indicator 2: 0 Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 26. Apply the template to the test record. Expected result: 651 _0 $a Cats The following should NOT be copied by this action: 650 17 $a Dogs This confirms that a literal blank MARC indicator can be explicitly matched and is distinct from leaving an indicator criterion unset. Partial source indicator matching --------------------------------- 27. Create another action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: leave unset Destination field: 651 Destination subfield: blank Destination indicator 1: leave unset Destination indicator 2: leave unset 28. Apply the template. Expected result: 651 17 $a Dogs The following should NOT be copied: 650 _0 $a Cats This confirms that an unset source indicator does not require a blank indicator. Instead, no restriction is applied for that indicator position. Explicit destination indicators ------------------------------- 29. Create another action: Action: Copy Field number: All Source field: 650 Source subfield: blank Use indicators: checked Source indicator 1: 1 Source indicator 2: 7 Destination field: 651 Destination subfield: blank Destination indicator 1: one literal blank space Destination indicator 2: 0 30. Apply the template. Expected destination field: 651 _0 $a Dogs Confirm in the MARC editor that: - indicator 1 is blank - indicator 2 is 0 - $a contains Dogs This confirms that explicitly supplied destination indicators replace the source indicators on the newly created destination field. Unset destination indicators ---------------------------- 31. Repeat the copy from: 650 17 $a Dogs to field 651, but leave both destination indicators completely unset. Expected destination: 651 17 $a Dogs This confirms that when destination indicators are not supplied, the source field's indicators are preserved. Regression testing ------------------ 32. Create a MARC modification template action without selecting "Use indicators". Configure a normal existing MARC modification operation. 33. Save, edit, and apply the action. Confirm that the action behaves as it did before this enhancement and that indicator criteria are not required. 34. Confirm that existing MARC modification template actions created before this enhancement can still be viewed, edited, and applied without adding indicator criteria. Additional functional coverage ------------------------------ 35. Test Move with indicators against a bibliographic record. Verify that: - only the source field matching the specified indicators is moved - the source field is removed - the destination field is created - explicitly supplied destination indicators are applied - unrelated fields are unchanged 36. Test Copy and replace with indicators against a bibliographic record. Verify that: - only fields matching the source indicator criteria participate in the operation - the destination receives the expected value - explicitly supplied destination indicators are applied - unrelated fields are unchanged 37. Test a conditional indicator criterion against an actual bibliographic record. Use a record containing fields with different indicators. Confirm that the action runs when the conditional field has the requested indicators. 38. Repeat the conditional test using indicators that do not match the record. Confirm that the action does not run. 39. Confirm the resulting MARC record after each functional test and verify that no unrelated fields or indicators have been modified. 40. Sign off and have a wonderful day! :D Sponsored-by: koha-US <https://koha-us.org/> Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #90 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206860&action=edit Bug 21860: Address QA findings Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #92 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 206862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206862&action=edit Bug 21860: Address additional QA findings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #93 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Setting this back to Passed QA so it goes back to Pedro, but please let us know if you'd rather it gets a new SO or QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #95 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 207024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207024&action=edit Bug 21860: Add indicator matching to field_exists Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #97 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 207026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207026&action=edit Bug 21860: Store and apply MARC indicator criteria Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #99 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 207028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207028&action=edit Bug 21860: Fix indicator handling and display Signed-off-by: Angela Berrett <angela.berrett@familysearch.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #101 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 207030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207030&action=edit Bug 21860: Address additional QA findings Addressed the additional QA findings. * Updated update_field indicator handling so indicators are treated as values to update rather than match criteria. Existing fields are now updated in place rather than creating a duplicate when the requested indicator differs. * Preserved the "add new" behavior when the target field/subfield does not exist. * Moved the _ to MARC blank indicator conversion until after form validation succeeds, so failed validation does not alter the displayed indicator values. * Added/updated regression coverage for updating indicators on an existing field. Manually tested both update and add-new behavior in the staff interface, including the reported 650 _0 → 650 70 case and the failed-validation _ behavior. QA tools and tests pass: * t/SimpleMARC.t * t/db_dependent/MarcModificationTemplates.t * node --check * git diff --check * qa Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 --- Comment #103 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 207032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207032&action=edit Bug 21860: Update fields with missing subfields -- You are receiving this mail because: You are watching all bug changes.