https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79383&action=edit Bug 21409: Add column configuration to course reserves This patch adds columns configuration and print/export options to two tables: The table listing courses and the table listing titles reserved for a course. To test you should have more than one course and multiple title reserved for at least one course. - Apply the patch and go to Course reserves - In the table of courses, confirm that all DataTables controls work correctly: paging, filter, column visibility, export, etc. - View a course with multiple titles reserved. Test all DataTables controls on this table too. - Go to Administration -> Columns settings - Change the settings for the courses and reserves table and confirm that these changes are applied correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79383|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 79737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79737&action=edit Bug 21409: Add column configuration to course reserves This patch adds columns configuration and print/export options to two tables: The table listing courses and the table listing titles reserved for a course. To test you should have more than one course and multiple title reserved for at least one course. - Apply the patch and go to Course reserves - In the table of courses, confirm that all DataTables controls work correctly: paging, filter, column visibility, export, etc. - View a course with multiple titles reserved. Test all DataTables controls on this table too. - Go to Administration -> Columns settings - Change the settings for the courses and reserves table and confirm that these changes are applied correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caption - https://snag.gy/mikSJI.jpg h1- https://snag.gy/sLIK3u.jpg Caption adjusted (text-align: center; font-size: inherit; margin: inherit;) - https://snag.gy/GYahyl.jpg -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #5)

(In reply to Jonathan Druart from comment #3)

...

I have a small concern: we remove the table's caption.

We have neither a coding guideline regarding captions nor one defining how to use heading tags, so the templates are pretty random with regard to these elements. I think most if not all tables with DataTables toolbars use a heading instead of a caption.

https://www.w3.org/TR/WCAG20-TECHS/H39.html """ The objective of this technique is to programmatically associate captions for data tables where captions are provided in the presentation. The caption for a table is a table identifier and acts like a title or heading for the table. The caption element is the appropriate markup for such text and it ensures that the table identifier remains associated with the table, including visually (by default). In addition, using the caption element allows screen reading software to navigate directly to the caption for a table if one is present. """ We should use captions :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.