[Bug 6977] New: Support for repeated subfields when importing an authority into a biblio record field.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Bug #: 6977 Summary: Support for repeated subfields when importing an authority into a biblio record field. Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Created attachment 5719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5719 Adds support for repeatable subfields when importing authorities. For example, if we try to import an authority with multiple $x subfields into a bibliographic record using the "..." link, only the last $x value get added to the form and the other values are ignored. Patch attached that adds all subfield values to the form, including repeated subfield values. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored AssignedTo|gmcharlt@gmail.com |fcapovilla@live.ca --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-05 17:59:25 UTC --- Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jcamins@cpbibliography.com Severity|enhancement |major --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-08 16:07:20 UTC --- This is a pretty big bug for MARC21 users. Upgrading the severity to reflect that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-08 16:16:55 UTC --- Created attachment 5801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5801 Adds support for repeatable subfields when importing authorities. Before this patch, if we tried to import an authority with multiple $x subfields into a bibliographic record, only the last value get added to the form. All repeated values should now be sent to the form. http://bugs.koha-community.org/show_bug.cgi?id=6977 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-10-08 16:17:45 UTC --- This patch does not fix the ordering of subfields drawn from authority records, but it does not claim to, and just having working repeated subfields is a huge improvement, so I'm happy to sign off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5719|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5801|0 |1 is obsolete| | --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 13:13:18 UTC --- Created attachment 5851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5851 Adds support for repeatable subfields when importing authorities. Before this patch, if we tried to import an authority with multiple $x subfields into a bibliographic record, only the last value get added to the form. All repeated values should now be sent to the form. http://bugs.koha-community.org/show_bug.cgi?id=6977 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 13:15:38 UTC --- QA comment The test plan is: - create an authority with repeated subfields - add biblio - retrieve authority through authority search - the repeated subfields are now correctly retrieved in the biblio * Tested under UNIMARC, works fine as well * no specific QA comment => passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-12 14:18:57 UTC --- Also works continues to work with authorities WITHOUT repeated subfields. As Jared points out, it does not do anything about field order, but it does not purport to. Marking a Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-12 22:08:28 UTC --- Minor string changes, but fairly major bug, pushing as string changes are only on staff side -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 --- Comment #9 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-21 16:33:32 UTC --- Created attachment 6020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6020 Follow-up patch : catch CloneSubfield errors I have found a problem with this functionnality : If subfields are repeated in the authority record, but these subfields are not repeatable in the biblio record, the CloneSubfield function fails with a javascript error, and the popup doesn't disappear. Example : Importing informations of a UNIF_TITLE authority with multiple $x subfields in the biblio's 440 field. On my test instance, 440$x isn't repeatable, so an error occurs when trying to clone it. I added a try/catch to catch the error. In that case, the subfield isn't cloned and only the first subfield value is added to the biblio record. Follow-up patch attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6020|0 |1 is obsolete| | --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-11-11 15:32:25 UTC --- Created attachment 6285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6285 [SIGNED-OFF] Bug 6977: Follow-up patch : catch CloneSubfield errors A javascript error could occur if the CloneSubfield function failed for any reason. This would prevent the popup from disappearing. Example : Importing informations of a UNIF_TITLE authority with multiple $x subfields in the biblio's 440 field. 440$x isn't repeatable, so an error occurs when trying to clone it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2011-11-11 15:32:42 UTC --- nengard@debian:~/kohaclone$ git bz apply 6977 Bug 6977 - Support for repeated subfields when importing an authority into a biblio record field. Adds support for repeatable subfields when importing authorities. Apply? [yn] y Applying: Adds support for repeatable subfields when importing authorities. /home/nengard/kohaclone/.git/rebase-apply/patch:64: trailing whitespace. /home/nengard/kohaclone/.git/rebase-apply/patch:96: trailing whitespace. /home/nengard/kohaclone/.git/rebase-apply/patch:120: trailing whitespace. error: patch failed: authorities/blinddetail-biblio-search.pl:80 error: authorities/blinddetail-biblio-search.pl: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt:11 error: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt: patch does not apply Patch failed at 0001 Adds support for repeatable subfields when importing authorities. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Adds-support-for-repeatable-subfields-when-importi-x8B4fU.patch nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-11-11 15:38:14 UTC --- Ooops - sorry about my last comment that was when i tried to apply paul's patch which was pushed already. This is signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-18 21:46:47 UTC --- follow-up patch OK, pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6977 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org