[Bug 29557] New: auto-renew notices should handle failed renewal due to patron expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Bug ID: 29557 Summary: auto-renew notices should handle failed renewal due to patron expiration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The default auto-renew and auto-renew-digest notices should include logic to tell patrons when their renewals have failed due to upcoming patron expiration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19444 CC| |jonathan.druart+koha@gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 [Bug 19444] Automatic renewal script should not auto-renew if a patron's record has expired -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127956&action=edit Bug 29557: Add auto_account_expired to AUTO_RENEWALS It was missing and the notice sent was not providing the reason of the failure. Test plan: Check an item out with a date in the past, mark it as auto renew Modify the expired date of the patron and set it in the past Run the automatic_renewals.pl cronjob script, confirm that the notice now contains the reason of the failure. QA note: The template will be updated only for English installations. Should we add an alert for others? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127956|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 128099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128099&action=edit Bug 29557: Add auto_account_expired to AUTO_RENEWALS It was missing and the notice sent was not providing the reason of the failure. Test plan: Check an item out with a date in the past, mark it as auto renew Modify the expired date of the patron and set it in the past Run the automatic_renewals.pl cronjob script, confirm that the notice now contains the reason of the failure. QA note: The template will be updated only for English installations. Should we add an alert for others? Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: - Ran auto renewal cron job as follows: perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the default auto-renewal | |notices to tell patrons | |that their renewals have | |failed because their | |account has expired. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am in doubt about the database update as this will only work for notices that haven't been changed - including untranslated. But it doesn't hurt to update unchanged notices, so we can keep it. But maybe we could add a note to the update statement about updating your notice if you have changed them? Attaching a patch to do this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128099|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128707&action=edit Bug 29557: Add auto_account_expired to AUTO_RENEWALS It was missing and the notice sent was not providing the reason of the failure. Test plan: Check an item out with a date in the past, mark it as auto renew Modify the expired date of the patron and set it in the past Run the automatic_renewals.pl cronjob script, confirm that the notice now contains the reason of the failure. QA note: The template will be updated only for English installations. Should we add an alert for others? Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128708&action=edit Bug 29557: (QA follow-up) Add note for translated notices to update statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|auto-renew notices should |Auto renew notices should |handle failed renewal due |handle failed renewal due |to patron expiration |to patron expiration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- While pushing master, I've moved note in dbrev into a "say $out". Renders better : kohadev-koha@kohadevbox:/kohadevbox/koha$ ./installer/data/mysql/updatedatabase.pl Upgrade to 21.12.00.006 [21:50:56]: Bug 29557 - Add auto_account_expired to AUTO_RENEWALS notice Please update your AUTO_RENEWALS notice manually if you have changed or translated it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.02 released in| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.02 |22.05.00,21.11.02,21.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37669 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org