[Bug 41437] New: Setting RestrictionBlockRenewing to block can cause extra auto renewals to sent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 Bug ID: 41437 Summary: Setting RestrictionBlockRenewing to block can cause extra auto renewals to sent Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com To recreate: 0. Set RestrictionBlockRenewing to 'block' 1. Set up a patron for auto rewenal and then check something out to them. Make sure the patron has an email address and has messaging preferences set to receive auto renewals. 2. Now do something that would make an auto renewal fail. I placed the item from step 1 on hold for someone else. 2. Run the auto renewals cron ( perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v ) 3. A notice should be generated telling the patron the thing cannot renew with the error code of `on_reserve`. ( good ) 4. Restrict the patron, doing this manually is fine. 5. Run the auto renewals cron again. 6. Another auto rewenal is sent tell the patron the thing cannot renew with the error code `restriction`. ( bad ) This is confusing. The item is still on hold, we shouldn't inform the patron that the items cannot auto renew, they already know! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Setting |Setting |RestrictionBlockRenewing to |RestrictionBlockRenewing to |block can cause extra auto |block can cause extra auto |renewals to sent |renewals to send -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think we should be checking the previous auto renewal error, if it exists we should send a new failure notice. The exception is 'auto_too_soon'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190584&action=edit Bug 41437: Prevent sending an auto renewal failure if one already exists To test: 0. Set RestrictionBlockRenewing to 'block' 1. Set up a patron for auto rewenal and then check something out to them. Make sure the patron has an email address and has messaging preferences set to receive auto renewals. 2. Now do something that would make an auto renewal fail. I placed the item from step 1 on hold for someone else. 2. Run the auto renewals cron ( perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v ) 3. A notice should be generated telling the patron the thing cannot renew with the error code of `on_reserve`. ( good ) 4. Restrict the patron, doing this manually is fine. 5. Run the auto renewals cron again. 6. Another auto renewal is sent tell the patron the thing cannot renew with the error code `restriction`. ( bad ) 7. APPLY PATCH, restart_all 8. Reset the test plan and try all the steps again. Tthis time at step 8 you should NOT get a 2nd consecutive failure notice. 9. Lift the restriction and run the automatic_renewals.pl script once again, you shold get a notice that the renewal succeeds. 10. Repeat this process for digest notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Setting |Patrons should never |RestrictionBlockRenewing to |receive two consecutive |block can cause extra auto |auto renewal failure |renewals to send |notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41437 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I attempted to test (using a fresh KTD), but notices aren't generated for steps 2(2) and 6. Are there some other settings required, apart from those in steps 0 and 1? Step 2 (2): ----------- perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v getting auto renewals found 0 auto renewals Record under the checkouts table has: Item on hold for another patron Step 6: ------- perl /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl -c -v getting auto renewals found 0 auto renewals Record under the checkouts table has: 0 Not allowed: patron restricted (5 of 5 renewals remaining) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org