[Bug 6861] New: Fast Add returns to circulation page in all cases
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6861 Bug #: 6861 Summary: Fast Add returns to circulation page in all cases Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Cataloging AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Since the addition of Fast Add to circulation (when scanning an unknown barcode, an option is given to Fast Add at that point), some of the default behaviors for the previous existing functionality has changed. If Fast Add is selected from the Circulation mainpage (not within a checkout), or if it is selected as the framework via cataloging, when items are saved, the page redirects to a blank checkout page, rather than to the details or items pages for that biblio. This makes it very difficult for the librarian to confirm their changes have saved, since the newly added biblio will not be available for search until rebuild_zebra.pl next runs. The system should be able to detect the lack of borrowernumber and other passed checkout variables, and change the redirect accordingly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6861 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-09 11:00:36 UTC --- Created attachment 5381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5381 Proposed Patch Adds a conditional check for whether a borrowernumber has been passed; if so, then continue on to circ/circulation to complete transaction. Otherwise, remain on additem.pl as normal (we're cataloging) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6861 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6861 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5381|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-09-09 19:35:33 UTC --- Created attachment 5393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5393 [SIGNED-OFF] Bug 6861: Fast Add returns to circ/circulation.pl in all cases If Fast Add is accessed from either the circulation homepage or cataloguing, it should stay on the additem.pl page after saving the first item. Only when a Fast Add is done in the middle of a circulation transaction should it redirect back to circ/circulation.pl to complete that transaction. This patch adds a conditional check for a borrowernumber input param; the presense of such implies we're in the middle of a checkout. It's absense implies we should remain on additem.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6861 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6861 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-09 19:38:36 UTC --- Passing my own patch through QA, since it only adds a single check for a (required) parameter that is used in constructing the redirect URL... since URL won't work without that param, makes sense to check for it, right? Right? Please object if you do not agree with my doing this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6861 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-11 09:34:07 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6861 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Seems to work. Closing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org