https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82239&action=edit Bug 21813: In-page JavaScript causes error on patron entry page This patch removes a block of JavaScript from memberentrygen.tt which was being included in the page before jQuery is loaded. This causes a JavaScript error. To test, apply the patch and clear your browser cache if necessary. - In Administration -> Patron categories, confirm that you have two patron categories with different default messaging preferences defined. - Go to Patrons -> New patron - Create a new patron using one of the categories with messaging preferences. - Confirm that when you switch the category selection to the other patron category, the patron messaging preference checkboxes are changed to the default for that category. - Manually change one or more patron messaging preference checkboxes. - Switch the patron category again and confirm that you are prompted to confirm resetting the preferences to the default for that category. - Perform the same set of tests when editing a patron. - Confirm that there are no other JavaScript errors in the console. - Test again with EnhancedMessagingPreferences disabled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21751 [Bug 21751] fixFloat toolbar not displaying properly in Chrome -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Oh, should have read the test plan better! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82239|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83632&action=edit Bug 21813: In-page JavaScript causes error on patron entry page This patch removes a block of JavaScript from memberentrygen.tt which was being included in the page before jQuery is loaded. This causes a JavaScript error. To test, apply the patch, regenerate CSS, and clear your browser cache if necessary. - In Administration -> Patron categories, confirm that you have two patron categories with different default messaging preferences defined. - Go to Patrons -> New patron - Create a new patron using one of the categories with messaging preferences. - Confirm that when you switch the category selection to the other patron category, the patron messaging preference checkboxes are changed to the default for that category. - A "Loading" indicator should appear above the checkboxes to show that an operation is in process. It should disappear when new default prefs are loaded. - Manually change one or more patron messaging preference checkboxes. - Switch the patron category again and confirm that you are prompted to confirm resetting the preferences to the default for that category. - Perform the same set of tests when editing a patron. - Defaults should not be loaded during the edit process. - Confirm that there are no other JavaScript errors in the console. - Test again with EnhancedMessagingPreferences disabled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works for me, no regressions found and the qa scripts all pass. I'm going to go ahead and PQA this as it's a major.. but I think an accompanying regression test would be good to prevent future regressions. I'll create a new bug for that to prevent holding this one up and discus whether we want a specific test or a more generic check for errors in the console anywhere. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83695|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 83703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83703&action=edit Bug 21813: In-page JavaScript causes error on patron entry page This patch removes a block of JavaScript from memberentrygen.tt which was being included in the page before jQuery is loaded. This causes a JavaScript error. To test, apply the patch, regenerate CSS, and clear your browser cache if necessary. - In Administration -> Patron categories, confirm that you have two patron categories with different default messaging preferences defined. - Go to Patrons -> New patron - Create a new patron using one of the categories with messaging preferences. - Confirm that when you switch the category selection to the other patron category, the patron messaging preference checkboxes are changed to the default for that category. - A "Loading" indicator should appear above the checkboxes to show that an operation is in process. It should disappear when new default prefs are loaded. - Manually change one or more patron messaging preference checkboxes. - Switch the patron category again and confirm that you are prompted to confirm resetting the preferences to the default for that category. - Perform the same set of tests when editing a patron. - Defaults should not be loaded during the edit process. - Confirm that there are no other JavaScript errors in the console. - Test again with EnhancedMessagingPreferences disabled. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.02 -- You are receiving this mail because: You are watching all bug changes.