https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171872&action=edit Bug 37982: Replace edit form with GET Caught by tests from bug 37728 # $VAR3 = 'koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:158'; We don't really need the form to be POSTed, we should not reach the URL maxlength. The UI will certainly explode if there are lot of items to edit anyway. The code is not clear on this page as we are sending several forms using the items selected from this table. But this one form is used to display the edit form and so can be GET (and better as the URL can be shared). The other actions have their own form (in modals mostly). Test plan: Create a subscription and go to the serial collection page. Make sure at least one item is select and click the "Edit" button. No behaviour change expected here, the edit form should still be displayed. Try the other actions on top of the table and confirm they are still working as before. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171911|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171921&action=edit Bug 37982: Replace edit form with GET Caught by tests from bug 37728 # $VAR3 = 'koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:158'; We don't really need the form to be POSTed, we should not reach the URL maxlength. The UI will certainly explode if there are lot of items to edit anyway. The code is not clear on this page as we are sending several forms using the items selected from this table. But this one form is used to display the edit form and so can be GET (and better as the URL can be shared). The other actions have their own form (in modals mostly). Test plan: Create a subscription and go to the serial collection page. Make sure at least one item is select and click the "Edit" button. No behaviour change expected here, the edit form should still be displayed. Try the other actions on top of the table and confirm they are still working as before. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37982 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.