[Bug 25037] New: Add support for multiple checkout types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Bug ID: 25037 Summary: Add support for multiple checkout types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This is a blocker to Bug 24101. As of now we have two checkout types, a normal checkout and an on-site checkout type. In order to target circulation rules to a specific checkout type, the issues table must have information on which type of checkout it is. On-site checkout is currently determined by a boolean value in issues.onsite_checkout database column. For supporting multiple checkout types, we should convert this column into a generic checkout_type field. This Bug also sets an easy-to-extend base for further checkout types. In theory a library could define any types of checkouts dynamically, but support for that is outside the scope of this Bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24101 Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102259&action=edit Bug 25037: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "ONSITE" for indicating an on-site checkout. To test: 1. perl installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102260&action=edit Bug 25037: Add authorised values to sample data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #3 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102261&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type To test: 1. perl installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #4 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102262&action=edit Bug 25037: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #5 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102263&action=edit Bug 25037: Replace onsite_checkout with checkout_type To test: 1. Run all these tests: prove t/db_dependent/Circulation.t prove t/db_dependent/Circulation/TooMany.t prove t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Items.t prove t/db_dependent/Koha/Account/Line.t 2. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 2. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 1 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 2, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 2 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102263|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102264&action=edit Bug 25037: Replace onsite_checkout with checkout_type To test: 1. Run all these tests: prove t/db_dependent/Circulation.t prove t/db_dependent/Circulation/TooMany.t prove t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Items.t prove t/db_dependent/Koha/Account/Line.t 2. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 3. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 2 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 4. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 3, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 2 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 5. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 4 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102259|0 |1 is obsolete| | --- Comment #7 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102265&action=edit Bug 25037: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "ONSITE" for indicating an on-site checkout. To test: 1. perl installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102260|0 |1 is obsolete| | --- Comment #8 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102266&action=edit Bug 25037: Add authorised values to sample data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102261|0 |1 is obsolete| | --- Comment #9 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102267&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type To test: 1. perl installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102262|0 |1 is obsolete| | --- Comment #10 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102268&action=edit Bug 25037: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #11 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102269&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Run all these tests: prove t/db_dependent/Circulation.t prove t/db_dependent/Circulation/TooMany.t prove t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Items.t prove t/db_dependent/Koha/Account/Line.t 2. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 3. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 2 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 4. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 3, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 2 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 5. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 4 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #12 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102272&action=edit Bug 25037: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102264|0 |1 is obsolete| | Attachment #102265|0 |1 is obsolete| | --- Comment #13 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102413&action=edit Bug 25037: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "ONSITE" for indicating an on-site checkout. To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102266|0 |1 is obsolete| | --- Comment #14 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102414&action=edit Bug 25037: Add authorised values to sample data Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102267|0 |1 is obsolete| | --- Comment #15 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102415&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102268|0 |1 is obsolete| | --- Comment #16 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102416&action=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102269|0 |1 is obsolete| | --- Comment #17 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102417&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Run all these tests: prove t/db_dependent/Circulation.t prove t/db_dependent/Circulation/TooMany.t prove t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Items.t prove t/db_dependent/Koha/Account/Line.t 2. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 3. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 2 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 4. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 3, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 2 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 5. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 4 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102272|0 |1 is obsolete| | --- Comment #18 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102418&action=edit Bug 25037: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102413|0 |1 is obsolete| | --- Comment #19 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102419&action=edit Bug 25037: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "OS" (on-site) and "C" (normal checkout). To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102414|0 |1 is obsolete| | --- Comment #20 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102420&action=edit Bug 25037: Add authorised values to sample data Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102415|0 |1 is obsolete| | --- Comment #21 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102421&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "OS" Else checkout_type becomes "C" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102416|0 |1 is obsolete| | --- Comment #22 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102422&action=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102417|0 |1 is obsolete| | --- Comment #23 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102423&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Run all these tests: prove t/db_dependent/Circulation.t prove t/db_dependent/Circulation/TooMany.t prove t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Items.t prove t/db_dependent/Koha/Account/Line.t 2. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 3. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 2 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 4. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 3, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 2 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 5. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 4 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102418|0 |1 is obsolete| | --- Comment #24 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102424&action=edit Bug 25037: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102419|0 |1 is obsolete| | --- Comment #25 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102586&action=edit Bug 25037: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "OS" (on-site) and "C" (normal checkout). To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102420|0 |1 is obsolete| | --- Comment #26 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102587&action=edit Bug 25037: Add authorised values to sample data Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102421|0 |1 is obsolete| | --- Comment #27 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102588&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "OS" Else checkout_type becomes "C" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102422|0 |1 is obsolete| | --- Comment #28 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102589&action=edit Bug 25037: Schema changes Sponsred-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #29 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102590&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102424|0 |1 is obsolete| | --- Comment #30 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102591&action=edit Bug 25037: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102423|0 |1 is obsolete| | --- Comment #31 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102592&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102586|0 |1 is obsolete| | --- Comment #32 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102593&action=edit Bug 25037: Add authorised value for checkout types This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "OS" (on-site) and "C" (normal checkout). To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102587|0 |1 is obsolete| | --- Comment #33 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102594&action=edit Bug 25037: Add authorised values to sample data Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102588|0 |1 is obsolete| | --- Comment #34 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102595&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "OS" Else checkout_type becomes "C" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102589|0 |1 is obsolete| | --- Comment #35 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102596&action=edit Bug 25037: Schema changes Sponsred-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102590|0 |1 is obsolete| | --- Comment #36 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102597&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102591|0 |1 is obsolete| | --- Comment #37 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102598&action=edit Bug 25037: Validate checkout_type in Koha::Checkout->store This patch adds a validation for checkout_type value when storing a Koha::Checkout To test: 1. prove t/db_dependent/Koha/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102592|0 |1 is obsolete| | --- Comment #38 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102599&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25089 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 [Bug 25089] Add checkout_type to circulation rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lari, I really like the idea of circulation types - I think I actually suggested something like that when on-site was introduced at the time, because I know other systems use this concept. I have 2 comments for discussion/consideration. 1) "This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "OS" (on-site) and "C" (normal checkout)." I feel this is not necessary and would vote for hard-coding the circulation types and their descriptions. It will make it translatable and keep people from 'messing' with it. Unless you plan to really allow people to add a lot more of those? I'd also use more speakign abbreviations, maybe 'ONSITE' and CHECKOUT - no need to make things more cryptical than necessary. It would help doing reports etc. too. 2) On the mailing list it was suggested to have 'normal' 'on-site' and 'all'. I am not sure about the 'all'. I feel it might be complicating things more than necessary. If all was to preserve current behaviour, I don't think that would work as on-site currently is 1 day by default, independent of the normal loan period. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #40 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Katrin Fischer from comment #39)
Hi Lari,
I really like the idea of circulation types - I think I actually suggested something like that when on-site was introduced at the time, because I know other systems use this concept. Just curious, which systems and how does it work in them?
I have 2 comments for discussion/consideration.
1) "This commit adds an authorised value category "CHECKOUT_TYPE" and an authorised value "OS" (on-site) and "C" (normal checkout)."
I feel this is not necessary and would vote for hard-coding the circulation types and their descriptions. It will make it translatable and keep people from 'messing' with it. Unless you plan to really allow people to add a lot more of those? The default values are both hardcoded and exist as authorised value. While we are at it, my idea was to add database support for dynamicity. Although, fully supporting such feature would require more changes in the GUI and circulation logic which I do not plan to implement.
What comes to messing with the values - we can set a RESTRICT flag into the foreign key which means one cannot change nor delete the authorised values, unless the whole issues and old_issues table is empty. This way a librarian cannot accidentally mess up a production system (unless they really did not had any checkouts (active or returned) yet). But we can proceed with only hardcoding the values. We can move the authorised value patches to another Bug for someone else to continue from there. In order to protect issues.checkout_type from non-existing types, we could use an ENUM data type that only allows a value from a set of possible hardcoded values. I will do that now so we can get this Bug moving easier. We can then later choose whether to include auth value functionality or not.
I'd also use more speakign abbreviations, maybe 'ONSITE' and CHECKOUT - no need to make things more cryptical than necessary. It would help doing reports etc. too. I don't have any preference on the code choices. We can make it more readable.
2) On the mailing list it was suggested to have 'normal' 'on-site' and 'all'. I am not sure about the 'all'. I feel it might be complicating things more than necessary. If all was to preserve current behaviour, I don't think that would work as on-site currently is 1 day by default, independent of the normal loan period. The circulation rules part of this Bug was moved to Bug 25089. "All" is useful if you only need to separate one or two rules between the types of checkouts. As an example, you could then have one full set of rules with "All" scope, and loan period = 1, renewals allowed = 0 with "on-site" scope.
Thx for your input! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25103 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25103 [Bug 25103] Dynamically add checkout types -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102593|0 |1 is obsolete| | Attachment #102594|0 |1 is obsolete| | Attachment #102595|0 |1 is obsolete| | Attachment #102598|0 |1 is obsolete| | --- Comment #41 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102655&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "ONSITE" Else checkout_type becomes "CHECKOUT" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102596|0 |1 is obsolete| | --- Comment #42 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102656&action=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102597|0 |1 is obsolete| | --- Comment #43 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102657&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102599|0 |1 is obsolete| | --- Comment #44 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102658&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102655|0 |1 is obsolete| | --- Comment #45 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102659&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "ONSITE" Else checkout_type becomes "CHECKOUT" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102656|0 |1 is obsolete| | --- Comment #46 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102660&action=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102657|0 |1 is obsolete| | --- Comment #47 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102661&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102658|0 |1 is obsolete| | --- Comment #48 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102662&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102659|0 |1 is obsolete| | --- Comment #49 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102663&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "ONSITE" Else checkout_type becomes "CHECKOUT" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102660|0 |1 is obsolete| | --- Comment #50 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102664&action=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102661|0 |1 is obsolete| | --- Comment #51 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102665&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102662|0 |1 is obsolete| | --- Comment #52 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102666&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102665|0 |1 is obsolete| | --- Comment #53 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102675&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102666|0 |1 is obsolete| | --- Comment #54 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102676&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add support for multiple |Add checkout_type to |checkout types |checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #55 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi, two fail sfrom qa-tools FAIL Koha/Checkouts.pm OK critic OK forbidden patterns OK git manipulation FAIL pod *** ERROR: =cut found outside a pod block. Skipping to next block. in file Koha/Checkouts.pm OK pod coverage OK spelling OK valid FAIL Koha/Template/Plugin/Checkouts.pm OK critic FAIL forbidden patterns forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 57) OK git manipulation OK pod OK pod coverage OK spelling OK valid First is not a problem, the second one needs revision -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #56 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Bernardo Gonzalez Kriegel from comment #55)
FAIL Koha/Template/Plugin/Checkouts.pm OK critic FAIL forbidden patterns forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 57) OK git manipulation OK pod OK pod coverage OK spelling OK valid
..., the second one needs revision
It is not really a problem because it is not a Koha::Object, but let's change just for the sake of explicity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102675|0 |1 is obsolete| | --- Comment #57 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 104267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104267&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102676|0 |1 is obsolete| | --- Comment #58 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 104268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104268&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #59 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Comment on attachment 104268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104268 Bug 25037: Replace occurences to issues.onsite_checkout Review of attachment 104268: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25037&attachment=104268) ----------------------------------------------------------------- I checked all the other patches and they were looking good! ::: api/v1/swagger/definitions/checkout.json @@ +53,5 @@
"description": "Date the item was issued" }, + "checkout_type": { + "type": ["string", "null"], + "description": "Checkout type, an authorised value under CHECKOUT_TYPE category"
The description is still from the v1 version where authorized values were used. Could you here a) add enum for values "CHECKOUT" and "ONSITE" and b) update the description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #60 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 105638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105638&action=edit Bug 25037: (follow-up) Fix checkout_type property description Also adds a test of the property to checkouts.t REST test. To test: 1. prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #61 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Joonas Kylmälä from comment #59)
Comment on attachment 104268 [details] [review] Bug 25037: Replace occurences to issues.onsite_checkout
Review of attachment 104268 [details] [review]: -----------------------------------------------------------------
I checked all the other patches and they were looking good!
::: api/v1/swagger/definitions/checkout.json @@ +53,5 @@
"description": "Date the item was issued" }, + "checkout_type": { + "type": ["string", "null"], + "description": "Checkout type, an authorised value under CHECKOUT_TYPE category"
The description is still from the v1 version where authorized values were used. Could you here a) add enum for values "CHECKOUT" and "ONSITE" and b) update the description.
Done! Thanks for noticing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102663|0 |1 is obsolete| | Attachment #102664|0 |1 is obsolete| | Attachment #104267|0 |1 is obsolete| | Attachment #104268|0 |1 is obsolete| | Attachment #105638|0 |1 is obsolete| | --- Comment #62 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 105780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105780&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "ONSITE" Else checkout_type becomes "CHECKOUT" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #63 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 105781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105781&action=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #64 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 105782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105782&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #65 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 105783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105783&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #66 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 105784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105784&action=edit Bug 25037: (follow-up) Fix checkout_type property description Also adds a test of the property to checkouts.t REST test. To test: 1. prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch set on longer applies. Please rebase! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 25037: Convert issues.onsite_checkout to issues.checkout_type Applying: Bug 25037: Schema changes Applying: Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Applying: Bug 25037: Replace occurences to issues.onsite_checkout Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Items.pm M koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt M koha-tmpl/intranet-tmpl/prog/js/checkouts.js M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt M t/db_dependent/Circulation.t M t/db_dependent/Items.t M t/db_dependent/Koha/Account/Line.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Account/Line.t Auto-merging t/db_dependent/Items.t Auto-merging t/db_dependent/Circulation.t Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt Auto-merging koha-tmpl/intranet-tmpl/prog/js/checkouts.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt Auto-merging C4/Items.pm Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 25037: Replace occurences to issues.onsite_checkout The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-25037-Replace-occurences-to-issuesonsitechecko-4HO8b_.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk@ukr.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24101 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org