[Bug 12999] New: Untranslatable string on enhanced_content.pref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Bug ID: 12999 Summary: Untranslatable string on enhanced_content.pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr There is a untranslatable "NOTE" on enhanced_content.pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 31885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31885&action=edit Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show
# Enhanced Content > All msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr ""
3013a3018,3021
# Local Use msgid "local_use.pref## Nothing defined yet." msgstr ""
6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31885|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 31886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31886&action=edit Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show # Enhanced Content > All msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr "" # Local Use msgid "local_use.pref## Nothing defined yet." msgstr "" 6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31886|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32144&action=edit [SIGNED-OFF] Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show # Enhanced Content > All msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr "" # Local Use msgid "local_use.pref## Nothing defined yet." msgstr "" 6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32144|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32259&action=edit Bug 12999: Untranslatable string on enhanced_content.pref This patch modifies LangInstaller.pm to catch strings on syspref files that have no associated syspref To test: 1) Update strings for your preffered language 2) Check that the string "you can only choose one source" is not present on xx-YY-pref.po file 3) Apply the patch 4) Update strings again 5) Check the strig now appears [ and another one :) ] Doing a diff before and after will show # Enhanced Content > All msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr "" # Local Use msgid "local_use.pref## Nothing defined yet." msgstr "" 6) Translate the string 7) Install your language, check Administration > System preferences > Enhanced content > All (on your languge) and check the string is now translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- I am not sure I can explain this patch, but I confirm the only change in po files are: diff fr-FR-pref.po old/fr-FR-pref.po 2295a2296,2299
# Enhanced Content > All msgid "enhanced_content.pref## <strong>NOTE:</strong> you can only choose one source of cover images from below, otherwise Koha will show the images from all sources selected." msgstr ""
3014a3019,3022
# Local Use msgid "local_use.pref## Nothing defined yet." msgstr ""
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12999 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org