[Bug 31497] New: When you forget to fill in a field of the patron quick_add_form during a 1st validation test, the field, even if completed, is no longer saved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Bug ID: 31497 Summary: When you forget to fill in a field of the patron quick_add_form during a 1st validation test, the field, even if completed, is no longer saved Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com After filling it in, the 2nd attempt is not blocked, the validation can be done, but it seems that the field is cleared just before submission. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When you forget to fill in |When you forget to fill in |a field of the patron |a mandatory field of the |quick_add_form during a 1st |patron quick_add_form |validation test, the field, |during a 1st validation |even if completed, is no |test, the field, even if |longer saved |completed, is no longer | |saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master Summary|When you forget to fill in |Quick add: mandatory fields |a mandatory field of the |save as empty when not |patron quick_add_form |filled in before first save |during a 1st validation |attempt |test, the field, even if | |completed, is no longer | |saved | Severity|normal |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This bug is also present in current master (development branch). To test: * Go to patrons module * Click on Quick add new patron (I chose Patron as category) * On sample database these fields are marked as mandatory: * Surname * Cardnumber * Library * Category * Fill in Surname, leave cardnumber empty * Save - mandatory message is shown * Fill in cardnumber - save * The patron is saved * BUT: cardnumber is empty! Updating to major for data loss. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140568&action=edit Bug 31497: Prevent ID clash on quick add fields The quick add clones the original fields, including ids. This can cause some clash when other JS is running on the page. This patch updates the ids of the fields before adding to the form, which prevents bad copying/clearing of fields To test: * Go to patrons module * Click on Quick add new patron (I chose Patron as category) * On sample database these fields are marked as mandatory: * Surname * Cardnumber * Library * Category * Fill in Surname, leave cardnumber empty * Save - mandatory message is shown * Fill in cardnumber - save * The patron is saved * BUT: cardnumber is empty! APPLY PATCH * Repeat plan above * Cardnumber is correctly saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140568|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 140603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140603&action=edit Bug 31497: Prevent ID clash on quick add fields The quick add clones the original fields, including ids. This can cause some clash when other JS is running on the page. This patch updates the ids of the fields before adding to the form, which prevents bad copying/clearing of fields To test: * Go to patrons module * Click on Quick add new patron (I chose Patron as category) * On sample database these fields are marked as mandatory: * Surname * Cardnumber * Library * Category * Fill in Surname, leave cardnumber empty * Save - mandatory message is shown * Fill in cardnumber - save * The patron is saved * BUT: cardnumber is empty! APPLY PATCH * Repeat plan above * Cardnumber is correctly saved Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140603|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140606&action=edit Bug 31497: Prevent ID clash on quick add fields The quick add clones the original fields, including ids. This can cause some clash when other JS is running on the page. This patch updates the ids of the fields before adding to the form, which prevents bad copying/clearing of fields To test: * Go to patrons module * Click on Quick add new patron (I chose Patron as category) * On sample database these fields are marked as mandatory: * Surname * Cardnumber * Library * Category * Fill in Surname, leave cardnumber empty * Save - mandatory message is shown * Fill in cardnumber - save * The patron is saved * BUT: cardnumber is empty! APPLY PATCH * Repeat plan above * Cardnumber is correctly saved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- child_input.attr("id") + "_qa" Please clarify :) + console.log( orig_input_id); Debug ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #5)
child_input.attr("id") + "_qa" Please clarify :)
If you want to prevent clashing, wouldnt you need a more robust suffix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140703&action=edit Bug 31497: (follow-up) Expand ID suffix, fix password2, remove debug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140606|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 140808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140808&action=edit Bug 31497: Prevent ID clash on quick add fields The quick add clones the original fields, including ids. This can cause some clash when other JS is running on the page. This patch updates the ids of the fields before adding to the form, which prevents bad copying/clearing of fields To test: * Go to patrons module * Click on Quick add new patron (I chose Patron as category) * On sample database these fields are marked as mandatory: * Surname * Cardnumber * Library * Category * Fill in Surname, leave cardnumber empty * Save - mandatory message is shown * Fill in cardnumber - save * The patron is saved * BUT: cardnumber is empty! APPLY PATCH * Repeat plan above * Cardnumber is correctly saved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140703|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 140809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140809&action=edit Bug 31497: (follow-up) Expand ID suffix, fix password2, remove debug Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- 21.05.x not affected, no backport. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #14 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- *** Bug 30978 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31497 --- Comment #15 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- *** Bug 29303 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org