[Bug 16757] New: Add ability to pay fee by id for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Bug ID: 16757 Summary: Add ability to pay fee by id for SIP2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52468&action=edit Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52470&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52470|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52472&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52472|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 53261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53261&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52468|0 |1 is obsolete| | Attachment #53261|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 53262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53262&action=edit Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 53263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53263&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 [Bug 16895] Allow writeoffs via SIP2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53262|0 |1 is obsolete| | Attachment #53263|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55612&action=edit [SIGNED-OFF] Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55613&action=edit [SIGNED-OFF] Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55612|0 |1 is obsolete| | Attachment #55613|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 61375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61375&action=edit Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 61376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61376&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61375|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61607&action=edit Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61376|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61608&action=edit Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA Patch complexity|--- |Small patch --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me. Tested fee paid with and without accountlines id. The cli emulator looks ok, but did not test it; rather run a test file like t/db_dependent/SIP/Message.t or so :) Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16757 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org