http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16008|0 |1 is obsolete| | --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16009&action=edit [PATCH] Bug 9780: Alert librarians if a record is used by orders and prevent its suppression correcting a typo... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16161&action=edit [PATCH 2] Bug 9780: Don't show comma at the end of the line Little improvement : This patch uses loop.last in detail.tt template to suppress useless comma. M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hello Mathieu, sry, but : 1° : in your patch you have whitespace errors, not a problem to test but later for QA... I paste the git am message : ================================= Applying: Bug 9780: Alert librarians if a record is used by orders and prevent its suppression /home/christophe/workspace/versions/community/.git/rebase-apply/patch:49: trailing whitespace. WHERE aqorders.biblionumber=? /home/christophe/workspace/versions/community/.git/rebase-apply/patch:89: trailing whitespace. } /home/christophe/workspace/versions/community/.git/rebase-apply/patch:91: trailing whitespace. else { /home/christophe/workspace/versions/community/.git/rebase-apply/patch:95: trailing whitespace. } /home/christophe/workspace/versions/community/.git/rebase-apply/patch:135: trailing whitespace. [% END %] warning: squelched 14 whitespace errors warning: 19 lines add whitespace errors. =================================== 2° : in your patch 2 =================================== Applying: Bug 9780: Don't show comma at the end of the line /home/christophe/workspace/versions/community/.git/rebase-apply/patch:115: trailing whitespace. [%- UNLESS loop.last %],[% END %] error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:136 error: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt: patch does not apply Patch failed at 0001 Bug 9780: Don't show comma at the end of the line When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". =================================== As I was able to apply the patch1, I am going to test the patch without the follow up, please rebase for the followup thx -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16009|0 |1 is obsolete| | Attachment #16164|0 |1 is obsolete| | --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16167&action=edit Bug 9780: Show if a record is used by orders and prevent its suppression squashing the 2 previous files, and developping test plan Bug 9780: Show if a record is used by orders and prevent its suppression Before this patch, librarians can delete a record even if it is used in an order. And if items are not created when ordering, librarians cannot know the record is used in orders. This patch adds one sub in Acquisiton.pm : GetOrdersByBiblionumber It makes changes to detail.pl and detail.tt : If the record is used by an active order, or a deleted order, Koha will display a warning at the end of the record, with the number of active order and deleted orders using the record, and the corresponding basket number. If the librarian have managing order permission, the basket numbers are clickable. It also make changes to cat-toolbar.inc : It adds 2 new controls when deleting a record : - librarians cannot suppress it if it is used in an active order - only librarians with managing order permission can suppress it if it is used in a deleted order To test : A. test what can do and see a librarian with order managing rights 0) Connect to Koha with a borrower with order managing rights 1) check XSLTDetailsDisplay syspref is disabled 2) in basket A, create 2 orders with a single record (with no items attached) 3) in basket B, create 1 order with the same record 4) check that record in catalog (detail.pl page) : you should see a line saying it is used 3 times, in baskets A and B 5) in basket A, suppress one of the 2 orders 6) check the record again : you should see a line saying it is used 2 times in active orders, in baskets A and B, and 1 time in suppressed order in basket A 7) enable XSLTDetailsDisplay syspref 8) check the record again : you should see the same information as 5. 9) each basket number must be a hyperlink. Check if the links are correct 10) try to suppress the record : it should be impossible 11) suppress the 2 other orders in basket A and B 12) check catalogue : you should see a line saying it is only used in 3 deleted orders 13) try to delete again the record : it should be possible after a confirmation B. test what can do and see a librarian without order managing rights 14) in basket A, create again 1 order with a single record 15) disconnect yourself and connect to Koha with a borrower without order managing rights 16) check the record in the catalog : you should see information, but without any link to basket A 17) try to suppress the record : it should be impossible (like before) 18) disconnect yourself and connect to Koha with a borrower with order managing rights 19) suppress the order in basket A 20) disconnect yourself and connect to Koha with a borrower without order managing rights 21) check the record again : you should see a line saying it is only used in a deleted order in basket A 22) try to delete the record : it should be impossible, because you don't have order managing rights M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Paul, 1. I will correct tabulations tomorrow 2. For AcqCreateItem syspref=ordering, well, I need to look into this issue... The patch was made mainly for Rennes 2, and we are creating items at reception. M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16233|0 |1 is obsolete| | --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 16305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16305&action=edit [PATCH][Revised] Bug 9780: Show if a record is used by orders and prevent its suppression Revised : suppressing tabs, adding 5) and 18) step in test Before this patch, librarians can delete a record even if it is used in an order. And if items are not created when ordering, librarians cannot know the record is used in orders. This patch adds one sub in Acquisiton.pm : GetOrdersByBiblionumber It makes changes to detail.pl and detail.tt : If the record is used by an active order, or a deleted order, Koha will display a warning at the end of the record, with the number of active order and deleted orders using the record, and the corresponding basket number. If the librarian have managing order permission, the basket numbers are clickable. It also make changes to cat-toolbar.inc : It adds 2 new controls when deleting a record : - librarians cannot suppress it if it is used in an active order - only librarians with managing order permission can suppress it if it is used in a deleted order To test : A. test what can do and see a librarian with order managing rights 0) Connect to Koha with a borrower with order managing rights 1) check XSLTDetailsDisplay syspref is disabled 2) in basket A, create 2 orders with a single record 3) in basket B, create 1 order with the same record 4) check that record in catalog (detail.pl page) : you should see a line saying it is used 3 times, in baskets A and B 5) if some items are attached to that record, suppress all items 6) in basket A, suppress one of the 2 orders 7) check the record again : you should see a line saying it is used 2 times in active orders, in baskets A and B, and 1 time in suppressed order in basket A 8) enable XSLTDetailsDisplay syspref 9) check the record again : you should see the same information as 5. 10) each basket number must be a hyperlink. Check if the links are correct 11) try to suppress the record : it should be impossible 12) suppress the 2 other orders in basket A and B 13) check catalogue : you should see a line saying it is only used in 3 deleted orders 14) try to delete again the record : it should be possible after a confirmation B. test what can do and see a librarian without order managing rights 15) in basket A, create again 1 order with a single record 16) disconnect yourself and connect to Koha with a borrower without order managing rights 17) check the record in the catalog : you should see information, but without any link to basket A 18) if some items are attached to that record, suppress all items 19) try to suppress the record : it should be impossible (like before) 20) disconnect yourself and connect to Koha with a borrower with order managing rights 21) suppress the order in basket A 22) disconnect yourself and connect to Koha with a borrower without order managing rights 23) check the record again : you should see a line saying it is only used in a deleted order in basket A 24) try to delete the record : it should be impossible, because you don't have order managing rights Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7593 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Applying: Bug 9780: Add unit test and a new condition in GetOrdersByBiblionumber /usr/share/koha/testclone/.git/rebase-apply/patch:56: trailing whitespace. ok( scalar (@listorders) >0,'GetOrdersByBiblionumber : result contains at least one element' ); fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #18)

I propose to rewrite BZ9780, focusing on 1) only, as it was the main issue I wanted to fix.

Yes Mathieu, I think it is the easier way. I will try to manage with all others bugs relating to the acq details in biblio pages. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #20 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- In fact, the more I look into this problem, the more I think my solution is not realy good : there can be some situation where suppressing a record linked to orders should be allowed, for example if the library withdraw items some months after having bought them... So maybe a more fundamental change is needed, so that information in basket will not be deleted if we delete the record : - either in the basket, use info stored deletedbiblioitems and deletedbiblios as well as biblios and biblioitems - or store bibliographic information (title, author...) in aqorders table (bug 9548, N. Engard liked the idea) The 2d option is more radical, but should allow librarians to have always exactly the same information when they print a basketgroup in pdf. At present, we need to store the pdf somewhere in a DD, because we cannot trust Koha : each time we click on pdf, it is generated dynamicly. So if a record is changed, or suppressed, the pdf of the basketgroup is altered... This is not good : as basketgroups are sent to booksellers, they are not supposed to change, except if we want so. Maybe it deserves a message in Koha-devel... M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #21 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- What I am planning ; - making an other patch for displaying deleted records in acq module (Bug 10758 + discussion on koha-devel) - create an alert in this bug. I think we should not forbid the suppression of records used in acq module, because documents could have been withdrawn and libraries could rightfully want to delete the record. BUT -we must have a strong warn, particularly while 10758 is not pushed (and I don't know when it will be, since it is not written yet!). -only ppl with acq permission should have rights to suppress the record So I think we could : - make a simple, strong warn for ppl with acq rights : "Warning : deleting the record will cause severe issues in basket display" - make an other message for ppl without acq permissions "You cannot delete this record. You need acq rghts" - work on 10758 - when 10758 is pushed (some weeks ago maybe), make an other patch, to change the warn message, and maybe try to be more subtle (for ex, giving the choice of deleting the order while deleting the record, or allowing to delete only cancelled records, etc). M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16305|0 |1 is obsolete| | --- Comment #22 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 21254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21254&action=edit [PATCH] Bug 9780 : Restric the right to suppress a record used in some order Currently, anyone can suppress a record used in an order. With this patch, only librarians with managing order permission can suppress it if it is used in an active or a deleted order. This patch also add a specific warning informing that deleting a record used in an active order is dangerous. To test : A. test what can do and see a librarian with order managing rights 0) Connect to Koha with a borrower with order managing rights 1) in a basket, create 2 orders A & B from new records 2) delete order B 3) in the catalogue, try to suppress - record used for order A : you should see a specific warning informing you the record is used in 1 order, and that deleting it is dangerous - record used for order B : you should see a specific warning informing you the record is used in 1 deleted order - a record not used in any order : you should see no specific warning B. test what can do and see a librarian without order managing rights 4) Connect to Koha with a borrower without order managing rights 5) in a basket, create 2 orders A & B from new records 6) delete order B 7) in the catalogue, try to suppress - record used for order A : you should see a specific warning informing you you need specific rights to suppress the record - record used for order B : idem - a record not used in any order : you should see no specific warning M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleting a record suppress |Restric the right to |bibliographic info in |suppress a record used in |orders using that record |some order -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre@gmail.com --- Comment #24 from Pierre Angot <tredok.pierre@gmail.com> --- Is it a duplicate of 10869 ? It seems redundant. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #26 from Pierre Angot <tredok.pierre@gmail.com> --- I think there is a problem when your items are created when placing an order. I've suppressed item associated to record A. There is no message which warn you that this items is used in an order. It's a big problem. When AcqCreateItem is "when placing an order", if you suppress the item, you cannot add a new one to the order. You must delete the order or create a new one. It will be good if there is a new condition linked to this syspref. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #28 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I read again your comment. In fact everything is OK for me : The goal of the patch is to prevent the suppression of RECORDS used in orders, not the suppression of ITEMS used in orders. So the behavior is unchanged for items : you can still suppres an item created by an order, without any warns, like before the patch. It is bad, but it must be fixed in an other patch, as it is not exactly the same problem. Do you agree with that? I put patch to need sign off again. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #29 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- If you agree and if the other points of the test plan were ok for you, you can sign it off. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #31 from Paul Poulain <paul.poulain@biblibre.com> --- Just for the record: this problem (and the items one) was discussed yesterday at KohaCon13 acquisition roundtable. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #33 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Paul Poulain from comment #31)

Just for the record: this problem (and the items one) was discussed yesterday at KohaCon13 acquisition roundtable.

Of course, Paul, if you have arguments against signing this patch you can expose them. Or, maybe, if the patch is working, let it be signed off, and you could make its QA and tell us if my logic is not good ? Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #35 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Pierre Angot from comment #34)

Ha ha ha !

I've got an idea : go to your Syspref, select AcqCreateItem and change it to "when placing an order". You are know in the same situation as me :p

I've done it to check my patch was not making things worse for "when placing an order" syspref ;-) But I think it does not make things worse in that case, it has just no effect when tou suppress the items. But when the items are suppress, you still have the same warning if you try to delete the record. So it is usefull even with "when placing an order" syspref. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #37 from Pierre Angot <tredok.pierre@gmail.com> --- All the tests are ok. There is a little problem in test plan : if you unckeck "order manage", you can't created basket :p I mentionned only if someone wants do some other test. The second part : B. test what can do and see a librarian without order managing rights 4) Connect to Koha with a borrower with order managing rights 5) in a basket, create 2 orders A & B from new records 6) delete order B 7) Logoff and connect to Koha with a borrower without order managing rights 8) in the catalogue, try to suppress - record used for order A : you should see a specific warning informing you you need specific rights to suppress the record - record used for order B : idem - a record not used in any order : you should see no specific warning PS : we need a same warn on items when AcqCreateItem is "when placing an order" :p -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #39 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Pierre, new bug created for the issue you pointed out: Bug 11082 Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #41 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: * passes koha-qa.pl * translatable strings are correctly managed * works as expected * handles nicely various cases, depending on the permissions the librarian has well done passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is one small thing with this \n in the message will create trouble in Pootle and can't be translated correctly to be line breaks. What I would do is split those messages up or take the \n out. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #44 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Katrin Fischer from comment #43)

There is one small thing with this \n in the message will create trouble in Pootle and can't be translated correctly to be line breaks. What I would do is split those messages up or take the \n out.

I cannot deal with today. we can get rid of /n. I have seen /n in other javascript alert in Koha. Is it something to fix? Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #46 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Katrin Fischer from comment #45)

If they are not in a translated string it shouldn't cause problems. Ex. $string .= "\n--------------------------------"; The problem is that Pootle seems to escape those automatically, so you end up with a printed \n in translations (or at least it used to).

I'm suppressing that. But a grep gave me an other '\n' in js in modules/calendar.inc. Maybe it needs to be fixed too. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 --- Comment #48 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to mathieu saby from comment #47)

String patch, no need to test I think. But if you want to test, replay the test plan of main patch, and check the messages in javascript alert are displaying the right way. I've reviewed your patch, it's \n removal only, passed QA still valid imo

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11303 -- You are receiving this mail because: You are watching all bug changes.