[Bug 32738] New: Correct upload local cover image title tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Bug ID: 32738 Summary: Correct upload local cover image title tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 26703 The upload local cover image template still uses the old sequence of breadcrumb details: Koha -> Cataloging -> Upload local cover images (see Bug 26703 - Modify the "title" elements to contain unique information first). These elements should be reversed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26703 [Bug 26703] Modify the "title" elements to contain unique information first -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145769&action=edit Bug 32738: Correct upload local cover image title tag This patch corrects the local cover image template's title tag so that it conforms to the changes made in Bug 26703, 'Modify the "title" elements to contain unique information first.' The patch also makes minor corrections to the page's breadcrumbs. To test you must have the LocalCoverImages system preference enabled. - Apply the patch and go to Cataloging -> Upload local cover image. - The page title should be correct: Upload local cover image › Cataloging › Koha - The breadcrumbs should be: Home -> Cataloging -> Upload cover image - Locate a bibliographic record and view its details. - Click the "Images" tab, then the "Upload" button. - The page title should now be Upload local cover image for [title] › Cataloging › Koha - The breadcrumbs should now be: Home -> Cataloging -> Upload local cover image -> Upload cover for [title] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145769|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 145776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145776&action=edit Bug 32738: Correct upload local cover image title tag This patch corrects the local cover image template's title tag so that it conforms to the changes made in Bug 26703, 'Modify the "title" elements to contain unique information first.' The patch also makes minor corrections to the page's breadcrumbs. To test you must have the LocalCoverImages system preference enabled. - Apply the patch and go to Cataloging -> Upload local cover image. - The page title should be correct: Upload local cover image › Cataloging › Koha - The breadcrumbs should be: Home -> Cataloging -> Upload cover image - Locate a bibliographic record and view its details. - Click the "Images" tab, then the "Upload" button. - The page title should now be Upload local cover image for [title] › Cataloging › Koha - The breadcrumbs should now be: Home -> Cataloging -> Upload local cover image -> Upload cover for [title] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145776|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145830&action=edit Bug 32738: Correct upload local cover image title tag This patch corrects the local cover image template's title tag so that it conforms to the changes made in Bug 26703, 'Modify the "title" elements to contain unique information first.' The patch also makes minor corrections to the page's breadcrumbs. To test you must have the LocalCoverImages system preference enabled. - Apply the patch and go to Cataloging -> Upload local cover image. - The page title should be correct: Upload local cover image › Cataloging › Koha - The breadcrumbs should be: Home -> Cataloging -> Upload cover image - Locate a bibliographic record and view its details. - Click the "Images" tab, then the "Upload" button. - The page title should now be Upload local cover image for [title] › Cataloging › Koha - The breadcrumbs should now be: Home -> Cataloging -> Upload local cover image -> Upload cover for [title] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 --- Comment #5 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32738 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply clean to 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org