[Bug 9903] New: Sort by date broken on patron detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Bug ID: 9903 Summary: Sort by date broken on patron detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /members/moremember.pl?borrowernumber=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org Depends on: 9887 Date sorting (due date column, checked out date column) is incorrect for metric dates. This page should be updated to use the same technique Bug 9887 uses: sorting on hidden unformatted date data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17308&action=edit Bug 9903 - Sort by date broken on patron detail page When the patron detail page switched to DataTables no accommodation was made for metric date formats in sorting. This patch adds sorting based on data in a span's title attribute, and thus requires that the patch for Bug 9887 be applied. To test, view the detail page for a patron who has assorted checkouts, relatives' checkouts, and holds. Sorting of date columns should be correct with the dateformat preference set to any value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle.m.hall@gmail.com --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- After applying this patch, I can no longer sort holds on moremember.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17308|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17405&action=edit Bug 9903 - Sort by date broken on patron detail page When the patron detail page switched to DataTables no accommodation was made for metric date formats in sorting. This patch adds sorting based on data in a span's title attribute, and thus requires that the patch for Bug 9887 be applied. To test, view the detail page for a patron who has assorted checkouts, relatives' checkouts, and holds. Sorting of date columns should be correct with the dateformat preference set to any value. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, Isn't possible to use the KohaDates plugin and don't call output_pref in the perl script? It will avoid to pass new variables. (In order to have something like <span title="[% issueloo.date_due %]">[% issueloo.date_due | $KohaDates %]</span>) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17405|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17627&action=edit [PASSED QA] Bug 9903 - Sort by date broken on patron detail page When the patron detail page switched to DataTables no accommodation was made for metric date formats in sorting. This patch adds sorting based on data in a span's title attribute, and thus requires that the patch for Bug 9887 be applied. To test, view the detail page for a patron who has assorted checkouts, relatives' checkouts, and holds. Sorting of date columns should be correct with the dateformat preference set to any value. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Nice improvement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, sorry, I see now that I missed Jonathans question in comment 4 when I looked at this, could you provide a follow up/new patch/feedback...? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17643&action=edit Bug 9903: Followup: use the KohaDates T::T plugin to display dates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9903 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org