[Bug 26266] New: Add jQuery validator to opac-password-recovery.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Bug ID: 26266 Summary: Add jQuery validator to opac-password-recovery.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: timothy_alexis.vass@ub.lu.se QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |timothy_alexis.vass@ub.lu.s | |e Status|NEW |ASSIGNED Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 --- Comment #1 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 108800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108800&action=edit Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- (In reply to Timothy Alexis Vass from comment #1)
Created attachment 108800 [details] [review] Bug 26266: Add jQuery validator to opac-password-recovery.tt
To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off.
Hi Timothy, I have applied the patch and not find any validation while entering the mismatch password. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108800|0 |1 is obsolete| | --- Comment #3 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 108972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108972&action=edit Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108972|0 |1 is obsolete| | --- Comment #4 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 108974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108974&action=edit Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108974|0 |1 is obsolete| | --- Comment #5 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 108975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108975&action=edit Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- I'm sorry for attaching so many patches... This one is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this needs rebasing since bug 23816 was pushed. I had a go, but I'm not close enough to this area of code to be confident. Looks like a reasonable idea though, happy to test when it's ready :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108975|0 |1 is obsolete| | --- Comment #8 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 110312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110312&action=edit Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 0) Activate password reset in system preferences. 1) Initiate a password recovery. 2) Try to submit with an invalid password. 3) Confirm that validation occurs. 4) Try to submit with mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110312|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110589&action=edit Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 0) Activate password reset in system preferences. 1) Initiate a password recovery. 2) Try to submit with an invalid password. 3) Confirm that validation occurs. 4) Try to submit with mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110589|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110592&action=edit Bug 26266: Add jQuery validator to opac-password-recovery.tt To test: 0) Activate password reset in system preferences. 1) Initiate a password recovery. 2) Try to submit with an invalid password. 3) Confirm that validation occurs. 4) Try to submit with mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected, no regressions found.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26266 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org