https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |hammat.wele@inlibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 186986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186986&action=edit Bug 40866: Make message translatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.hafen@washk12.org --- Comment #4 from Michael Hafen <michael.hafen@washk12.org> --- I would like to upload alternate patchs that moves or removes the other variables that were introduced by bug 9762, if that is ok. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 --- Comment #6 from Michael Hafen <michael.hafen@washk12.org> --- I will add a patch to this bug then. I would like these variables to be kept together. Thank you. (In reply to Paul Derscheid from comment #5)

Nah, it's too late for that @Michael Hafen. Fixing issues in the original bugs post push to maintenance branches always causes confusion. If the patches in this bug are not sufficient, add more or open a new bug, please :)

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186985|0 |1 is obsolete| | --- Comment #8 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 187116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187116&action=edit Bug 40866: Fix incorrect display of override message on normal checkouts - The message 'No patron matched Restriction overridden temporarily' was appearing on every checkout, even when no restriction override occurred. - This was caused by the message being set unconditionally after AddIssue in circ/circulation.pl. - The message should not appear in circulation.pl, but in the Log Viewer. To test: 1. Check out an item to a patron normally. 2. 'Restriction overridden temporarily' message appears. 3. Apply patches 4. Repeat 1. ---> Verify that no 'Restriction overridden temporarily' message appears. 5. Check out an item that requires an override (e.g., not for loan item with AllowNotForLoanOverride enabled). ---> Verify that no 'Restriction overridden temporarily' message appears. 6. Go to Tool -> Log viewer. 7. Enter the borrowernumber in Object field and submit. ---> Verify that the 'Restriction overridden temporarily' message is logged correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186986|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187063|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- We don't need to logaction here? Why is that being deleted? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Needs Signoff |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- FQA as per last comment. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187116|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187627&action=edit Bug 40866: Fix incorrect display of override message on normal checkouts - The message 'No patron matched Restriction overridden temporarily' was appearing on every checkout, even when no restriction override occurred. - This was caused by the message being set unconditionally after AddIssue in circ/circulation.pl. - The message should not appear in circulation.pl, but in the Log Viewer. To test: 1. Check out an item to a patron normally. 2. 'Restriction overridden temporarily' message appears. 3. Apply patches 4. Repeat 1. ---> Verify that no 'Restriction overridden temporarily' message appears. 5. Check out an item that requires an override (e.g., not for loan item with AllowNotForLoanOverride enabled). ---> Verify that no 'Restriction overridden temporarily' message appears. 6. Go to Tool -> Log viewer. 7. Enter the borrowernumber in Object field and submit. ---> Verify that the 'Restriction overridden temporarily' message is logged correctly. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187629&action=edit Bug 40866: Remove original Bug 9762 implementation remnants (Part 1) This patch removes the duplicate logging code from the original Bug 9762 implementation that was not properly removed when the Alternative implementation was merged. The original implementation added separate logaction() calls in CanBookBeIssued and circulation.pl that created additional log entries with a different JSON format. This caused double logging when the Alternative implementation (which logs via AddIssue) was merged on top. Changes in this patch: C4/Circulation.pm: - Removed @message_log array and all pushes to it - Removed the separate logaction() call at the end of CanBookBeIssued - Removed 5th return value (@message_log) from CanBookBeIssued - Removed all if ($issueconfirmed) blocks that were populating @message_log circ/circulation.pl: - Removed the problematic line that added OVERRIDDEN to every confirmed checkout: $needsconfirmation->{'OVERRIDDEN'} = $issueconfirmed This addresses the double logging issue where circulation overrides were being logged twice with different formats. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187631&action=edit Bug 40866: Remove original Bug 9762 implementation remnants (Part 3 - Returns) This patch removes the duplicate logging code from circ/returns.pl that was part of the original Bug 9762 implementation. The original implementation added a separate logaction() call when ignoring holds on return. This code created a custom JSON log entry with the message "return an element that is reserved". However, this logging appears to have been orphaned - there is no corresponding Alternative implementation for return override logging in the current codebase. The code was creating log entries but they were not properly integrated with any override confirmation workflow. Changes: circ/returns.pl: - Removed entire else block that created custom override log entries - Removed unused variables: $message, @message, $user, $branchcode, $barcode - Removed C4::Log qw(logaction) import as it's no longer needed This eliminates the orphaned logging code and ensures returns.pl only uses standard Koha logging mechanisms. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187633&action=edit Bug 40866: Add unit tests for hold override logging This patch adds unit tests to verify the hold override logging functionality implemented in the previous patches. The tests cover the logging of hold overrides in `C4/Reserves.pm` and the `Koha/REST/V1/Holds.pm` API endpoint. To test: 1. Run the following tests and confirm they pass: - prove -lrv t/db_dependent/Circulation.t - prove -lrv t/db_dependent/Reserves.t - prove -lrv t/db_dependent/api/v1/holds.t 2. All tests should pass. Changes: t/db_dependent/Circulation.t: - Added tests for hold override scenarios in circulation. t/db_dependent/Reserves.t: - Added tests to verify that hold overrides are correctly logged when a hold is placed. t/db_dependent/api/v1/holds.t: - Added tests to ensure that the holds API correctly logs overrides when a hold is created with the `x-koha-override` header. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Weird and untranslatable |Corrections to override |message appears every time |logging |something is checked out | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate, | |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187675&action=edit Bug 40866: Add missing override states to action-logs.inc This follow-up adds missing override state translations that were discovered during testing. The patchset logs various override states but some were not covered in the log viewer display template. Missing states added: - USERBLOCKEDNOENDDATE: Patron had an indefinite restriction - CURRENTISSUE: Item is currently checked out to this patron - UNSEEN: Unseen renewal - SEEN: Seen renewal These states are now properly displayed in the action logs viewer when reviewing circulation override logging. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187628|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187678&action=edit Bug 40866: Remove unused $message variable from circulation The $message variable was declared in circ/circulation.pl but never actually set, making the "No patron matched" template block unreachable. This is a remnant from old code that was incompletely cleaned when that functionality was changed/removed. This patch removes the unused variable, template parameter, and the unreachable template block. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187630|0 |1 is obsolete| | --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187680&action=edit Bug 40866: Remove original Bug 9762 implementation remnants (Part 2 - Renewals) This patch removes the duplicate logging code from renewal scripts (circ/renew.pl and svc/renew) that was part of the original Bug 9762 implementation. The original implementation created separate logaction() calls with custom JSON messages whenever renewal overrides occurred. This caused double logging alongside the Alternative implementation which properly logs overrides via the confirmations parameter in AddRenewal. Changes: circ/renew.pl: - Removed unused variables: $user, $branchcode, @message - Removed separate logaction() calls for override logging - Changed to use confirmations array with proper codes: * 'RENEWAL_LIMIT' for override_limit * 'ON_RESERVE' for override_holds - Removed C4::Log qw(logaction) import svc/renew: - Removed unused variables: $borrower, $user, $message, @message - Removed separate logaction() calls for override logging - Changed to use confirmations array with proper codes: * 'ON_RESERVE' for on_reserve override * 'RENEWAL_LIMIT' for too_many override - Removed C4::Log qw(logaction) import The Alternative implementation in AddRenewal will now handle all override logging consistently through the confirmations parameter. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187632|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187682&action=edit Bug 40866: Implement Alternative pattern for holds override logging (Part 4) This patch implements proper override logging for holds following the Alternative implementation pattern used for checkouts and renewals. Instead of just removing the orphaned logging code from the original Bug 9762 implementation, this patch properly implements override logging by updating AddReserve to accept and log override information, similar to how AddIssue handles confirmations and forced overrides. Changes: C4/Reserves.pm: - Added JSON qw(to_json) import - Updated AddReserve to accept confirmations and forced parameters - Enhanced the existing logaction call to include override information in JSON format when overrides are present - Log format matches the Alternative implementation pattern: * hold ID * branchcode * biblionumber * itemnumber * confirmations array * forced array Koha/REST/V1/Holds.pm: - Added confirmations array building in the add() method - Pass 'HOLD_POLICY_OVERRIDE' confirmation when override_all is true - Pass confirmations parameter to AddReserve call reserve/request.pl: - Removed orphaned original implementation logging code - Removed unused variables and imports (message, @message, user, etc.) - Removed C4::Log import koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc: - Added 'HOLD_POLICY_OVERRIDE' case to translate_log_override block - Displays as "Hold policy override" in log viewer koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt: - Added JSON display handling for HOLDS module (similar to CIRCULATION) - Displays hold ID, biblionumber, and optional itemnumber with links - Shows forced and confirmation overrides using translate_log_override This ensures hold overrides are logged consistently with the Alternative implementation pattern, providing proper audit trails for policy overrides that are properly displayed in the log viewer. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187675|0 |1 is obsolete| | --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187684&action=edit Bug 40866: Add missing override states to action-logs.inc This follow-up adds missing override state translations that were discovered during testing. The patchset logs various override states but some were not covered in the log viewer display template. Missing states added: - USERBLOCKEDNOENDDATE: Patron had an indefinite restriction - CURRENTISSUE: Item is currently checked out to this patron - UNSEEN: Unseen renewal - SEEN: Seen renewal These states are now properly displayed in the action logs viewer when reviewing circulation override logging. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187678|0 |1 is obsolete| | --- Comment #31 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187687&action=edit Bug 40866: Remove unused $message variable from circulation The $message variable was declared in circ/circulation.pl but never actually set, making the "No patron matched" template block unreachable. This is a remnant from old code that was incompletely cleaned when that functionality was changed/removed. This patch removes the unused variable, template parameter, and the unreachable template block. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187680|0 |1 is obsolete| | --- Comment #33 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187689&action=edit Bug 40866: Remove original Bug 9762 implementation remnants (Part 2 - Renewals) This patch removes the duplicate logging code from renewal scripts (circ/renew.pl and svc/renew) that was part of the original Bug 9762 implementation. The original implementation created separate logaction() calls with custom JSON messages whenever renewal overrides occurred. This caused double logging alongside the Alternative implementation which properly logs overrides via the confirmations parameter in AddRenewal. Changes: circ/renew.pl: - Removed unused variables: $user, $branchcode, @message - Removed separate logaction() calls for override logging - Changed to use confirmations array with proper codes: * 'RENEWAL_LIMIT' for override_limit * 'ON_RESERVE' for override_holds - Removed C4::Log qw(logaction) import svc/renew: - Removed unused variables: $borrower, $user, $message, @message - Removed separate logaction() calls for override logging - Changed to use confirmations array with proper codes: * 'ON_RESERVE' for on_reserve override * 'RENEWAL_LIMIT' for too_many override - Removed C4::Log qw(logaction) import The Alternative implementation in AddRenewal will now handle all override logging consistently through the confirmations parameter. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187682|0 |1 is obsolete| | --- Comment #35 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187691&action=edit Bug 40866: Implement Alternative pattern for holds override logging (Part 4) This patch implements proper override logging for holds following the Alternative implementation pattern used for checkouts and renewals. Instead of just removing the orphaned logging code from the original Bug 9762 implementation, this patch properly implements override logging by updating AddReserve to accept and log override information, similar to how AddIssue handles confirmations and forced overrides. Changes: C4/Reserves.pm: - Added JSON qw(to_json) import - Updated AddReserve to accept confirmations and forced parameters - Enhanced the existing logaction call to include override information in JSON format when overrides are present - Log format matches the Alternative implementation pattern: * hold ID * branchcode * biblionumber * itemnumber * confirmations array * forced array Koha/REST/V1/Holds.pm: - Added confirmations array building in the add() method - Pass 'HOLD_POLICY_OVERRIDE' confirmation when override_all is true - Pass confirmations parameter to AddReserve call reserve/request.pl: - Removed orphaned original implementation logging code - Removed unused variables and imports (message, @message, user, etc.) - Removed C4::Log import koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc: - Added 'HOLD_POLICY_OVERRIDE' case to translate_log_override block - Displays as "Hold policy override" in log viewer koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt: - Added JSON display handling for HOLDS module (similar to CIRCULATION) - Displays hold ID, biblionumber, and optional itemnumber with links - Shows forced and confirmation overrides using translate_log_override This ensures hold overrides are logged consistently with the Alternative implementation pattern, providing proper audit trails for policy overrides that are properly displayed in the log viewer. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187684|0 |1 is obsolete| | --- Comment #37 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 187693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187693&action=edit Bug 40866: Add missing override states to action-logs.inc This follow-up adds missing override state translations that were discovered during testing. The patchset logs various override states but some were not covered in the log viewer display template. Missing states added: - USERBLOCKEDNOENDDATE: Patron had an indefinite restriction - CURRENTISSUE: Item is currently checked out to this patron - UNSEEN: Unseen renewal - SEEN: Seen renewal These states are now properly displayed in the action logs viewer when reviewing circulation override logging. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #41 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- We now have some failing test here in: t/db_dependent/Circulation/CanBookBeIssued.t I think this is part of the original implementation and they should be removed? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 --- Comment #43 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187725&action=edit Bug 40866: (follow-up) Remove obsolete CanBookBeIssued.t test file This test file was specifically testing the message_log return value from CanBookBeIssued, which was removed as part of the bug 40866 patchset. The circulation message functionality has been reimplemented elsewhere with proper test coverage, making this test file redundant. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #47 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 9762 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41590 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42153 [Bug 42153] Holds override is not reflected in action logs -- You are receiving this mail because: You are watching all bug changes.