[Bug 22974] New: Patron password update validation broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Bug ID: 22974 Summary: Patron password update validation broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 21964 Target Milestone: --- Bug 21946 (accidentally) removed inclusion of str/members-menu.inc, breaking JavaScript validation of the two password fields on the "change password" page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21964 [Bug 21964] Switch two-column templates to Bootstrap grid: Patrons part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 90030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90030&action=edit Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22973 [Bug 22973] Remove type attribute from script tags: Staff client includes 2/2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90030|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 90043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90043&action=edit Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above." Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90043|0 |1 is obsolete| | --- Comment #3 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 90080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90080&action=edit Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above." Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90080|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 90099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90099&action=edit Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above." Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22974 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36354 [Bug 36354] Action log viewer should give option to search by object type (item, biblio, borrowernumber, reserve_id sql.id etc) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org