[Bug 34137] New: Holds Cancellation Tab Configure Table Not in Order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Bug ID: 34137 Summary: Holds Cancellation Tab Configure Table Not in Order Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: quinn.morris@citruslibraries.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When configuring the table in the Holds cancellation tab, there is a checkbox missing for Date Cancellation Request. So all the boxes are one off. For example to hide the Title tab, I would have to check the patron box while configuring. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|22.11 |master OS|Windows |All Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds Cancellation Tab |Requested cancellation date |Configure Table Not in |column missing from holds |Order |awaiting pickup table | |config -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152812&action=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #2 from quinn.morris@citruslibraries.org --- Just for clarification, where would I put this information to try the fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152812|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152840&action=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to quinn.morris from comment #2)
Just for clarification, where would I put this information to try the fix?
In case you were referring to an incomplete test plan, I have revised it with more details. If you're asking how to apply and test the patch, check out this page: https://wiki.koha-community.org/wiki/Sandboxes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152840|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 152841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152841&action=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. Signed-off-by: Quinn <quinn.morris@citruslibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152841|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 152842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152842&action=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. Signed-off-by: Quinn <quinn.morris@citruslibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 quinn.morris@citruslibraries.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for testing, Quinn! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The most visible change here is that the Actions columns is now toggable again as the last column of the table. It's included in the yaml, so this seems intentional. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152842|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153211&action=edit Bug 34137: Requested cancellation date column missing from holds awaiting pickup table config This patch adds an entry for the requested cancellation date column to columns_settings.yml so that the column can be configured correctly in table settings and on the fly. To test you will need at least one hold with a cancellation request: - Go to Administration -> Circulation and fine rules -> Default waiting hold cancellation policy - Add at least one rule allowing cancellation on waiting items. - Place a hold for a patron which would fall under the rule you defined. - Satisfy the hold by checking the item in at the hold's destination location. - Cancel the hold, either by logging in to the OPAC as the patron with the hold, or in the staff client via the holds tab on the patron's record. - Apply the patch and restart all services. - Go to Circulation -> Holds awaiting pickup - In the "Holds with cancellation requests" tab, confirm that there is a "Date cancellation requested" column and that it is one of the choices under the "Columns" button. - Confirm that the correct columns are shown and hidden when making selections in the columns menu. - Go to Administration -> Table settings -> Circulation -> Holds awaiting pickup. - Test setting "Is hidden by default" and "Cannot be toggled" for various columns in the table, including the "Date cancellation requested" column. Signed-off-by: Quinn <quinn.morris@citruslibraries.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34137 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org