[Bug 28374] New: Convert pos/printreceipt.pl to use GetPreparedLetter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Bug ID: 28374 Summary: Convert pos/printreceipt.pl to use GetPreparedLetter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org It looks like somehow a patch got dropped from bug 26734 that converted the POS receipt printer to use GetPrepparedLetter too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26734, 28368 Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 [Bug 28368] Error when printing receipt of point of sale -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121116&action=edit Bug 28373: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1/ Try printing a point of sale receipt before and after applying the patch 2/ No change should result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121117&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1/ Try printing a point of sale receipt before and after applying the patch 2/ No change should result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121116|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26787 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121117|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122613&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1/ Try printing a point of sale receipt before and after applying the patch 2/ No change should result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I get an error after these patches - you remove the USE statements from the page template, but the letter expects them. They can be added to the notice, but I think we need a DB update then. Additionally, the default letter is not marked as HTML, but it is formatted as html - if I don't change the notice to HTML then I get all the HTML tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26734 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26734 [Bug 26734] Convert accounts (monetary) notices to use GetPreparedLetter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122613|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127367&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1/ Try printing a point of sale receipt before and after applying the patch 2/ No change should result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127368&action=edit Bug 28374: Update existing notices This patch updates the default slip to include KohaDates, Branches and Price plugins as required and prepends the same to existing notices at upgrade time. We also, switch the HTML flag on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry.. it took me ages to get back to this.. the fix was trivial too :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |david@davidnind.com |.com | Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 127415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127415&action=edit Bug 28374 - Print receipt is blank after patches applied After the patches are applied (and database update) the receipt has no details - see the attachment. Testing notes (koha-testing-docker): 1. Setup for testing: i. Enable EnablePointOfSale and UseCashRegisters system preferences ii. Add a new cash register (Administration > Accounting > Cash registers) ii. Add one or two products for sale (Administration > Accounting > Debit types, make sure 'Can be sold?' is ticked) 2. Go to Home > Point of sale 3. Add some items for purchase to a sale 4. Click confirm 5. Click on 'Print receipt' and save the PDF file somewhere 6. Apply patches 7. Update database: updatedatabase 8. Repeat steps 2-5 9. Compare receipt PDFs - should be no changes 10. Check that the default RECEIPT is updated - for print, HTML should be ticked (Tools > 11. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127367|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127434&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1. Setup for testing: i. Enable EnablePointOfSale and UseCashRegisters system preferences ii. Add a new cash register (Administration > Accounting > Cash registers) iii. Add one or two products for sale (Administration > Accounting > Debit types, make sure 'Can be sold?' is ticked) 2. Go to Home > Point of sale 3. Add some items for purchase to a sale 4. Click confirm 5. Click on 'Print receipt' and save the PDF file somewhere 6. Apply patches 7. Update database: updatedatabase 8. Repeat steps 2-5 9. Compare receipt PDFs - should be no changes 10. Check that the default RECEIPT is updated - for print, HTML should be ticked 11. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127368|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127435&action=edit Bug 28374: Update existing notices This patch updates the default slip to include KohaDates, Branches and Price plugins as required and prepends the same to existing notices at upgrade time. We also, switch the HTML flag on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thankyou so much for testing David!.. I'm quite embarrassed I got so much wrong in that first submission.. it seems my local notices are all significantly ahead of this patch set. I've uploaded a fresh set of patches.. they should work for new installs and installs with an existing notice that closely resembles the original one installed. Many thanks again, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127434|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 127438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127438&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1. Setup for testing: i. Enable EnablePointOfSale and UseCashRegisters system preferences ii. Add a new cash register (Administration > Accounting > Cash registers) iii. Add one or two products for sale (Administration > Accounting > Debit types, make sure 'Can be sold?' is ticked) 2. Go to Home > Point of sale 3. Add some items for purchase to a sale 4. Click confirm 5. Click on 'Print receipt' and save the PDF file somewhere 6. Apply patches 7. Update database: updatedatabase 8. Repeat steps 2-5 9. Compare receipt PDFs - should be no changes 10. Check that the default RECEIPT is updated - for print, HTML should be ticked 11. Sign off! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127435|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 127439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127439&action=edit Bug 28374: Update existing notices This patch updates the default slip to include KohaDates, Branches and Price plugins as required and prepends the same to existing notices at upgrade time. We also, switch the HTML flag on. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |lucas@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127438|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127549&action=edit Bug 28374: Convert printreceipt to use GetPreparedLetter This patch converts the point of sale receipt printer controller to using GetPreparedLetter instead of calling getletter directly. Test plan 1. Setup for testing: i. Enable EnablePointOfSale and UseCashRegisters system preferences ii. Add a new cash register (Administration > Accounting > Cash registers) iii. Add one or two products for sale (Administration > Accounting > Debit types, make sure 'Can be sold?' is ticked) 2. Go to Home > Point of sale 3. Add some items for purchase to a sale 4. Click confirm 5. Click on 'Print receipt' and save the PDF file somewhere 6. Apply patches 7. Update database: updatedatabase 8. Repeat steps 2-5 9. Compare receipt PDFs - should be no changes 10. Check that the default RECEIPT is updated - for print, HTML should be ticked 11. Sign off! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127439|0 |1 is obsolete| | --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127550&action=edit Bug 28374: Update existing notices This patch updates the default slip to include KohaDates, Branches and Price plugins as required and prepends the same to existing notices at upgrade time. We also, switch the HTML flag on. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127551&action=edit Bug 28374: (QA follow-up) Avoid adding duplicate USE Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I would have tried to limit a bit more the matches * UPDATE letter SET content = REPLACE(content, 'payment.', 'credit.') WHERE code = 'RECEIPT'; Could have been payment\. * UPDATE letter SET content = REPLACE(content, 'offset', 'debit') WHERE code = 'RECEIPT'; offset\. and debit. * UPDATE letter SET content = REPLACE(content, 'offsets', 'credit.debits') WHERE code = 'RECEIPT'; IN offsets Not considering blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch converts the release notes| |point of sale receipt | |printer controller to using | |GetPreparedLetter instead | |of calling getletter | |directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Bug 28374 depends on bug 28368, which changed state. Bug 28368 Summary: Error when printing receipt of point of sale https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28368 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org