http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7850 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 8710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8710&action=edit Bug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks This patch does three things: - Add a copyright comment to normarc_fastadd_framework.sql - Change the value of marc_subfield_structure.hidden from -1 to 0 for several subfields of 952, in both the default and fast add framework, using this SQL statement: update marc_subfield_structure set hidden = 0 where tagfield = '952' and hidden = -1; - Add the maxlength column introduced by bug 7263 to all rows in marc_subfield_structure, setting the following maxlengths: 000 = 24 008 = 40 all other subfields = 9999 The format of the SQL files is the one that is produced by exporting the frameworks from the Web UI, with added copyright comments at the top. To test: - Install nb-NO - Run through the web installer in Norwegian on an empty database - Select NORMARC as the marcflavour - Be sure to select the fast add framework ("Rammeverk for hurtigkatalogisering" under "Valgritt") - Check in Home › Administration › MARC Frameworks that 000 and 008 for both frameworks have the right length - Add a dummy record so you get to the item edit screen and check that the form for subfields looks good. The subfields that are shown should be 01234578abcdefghjoptuvwyz and all subfields should have a text box or a dropdown associated with them. Check this for for both the default and fast add frameworks -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8710|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8745&action=edit [SIGNED-OFF] Bug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks This patch does three things: - Add a copyright comment to normarc_fastadd_framework.sql - Change the value of marc_subfield_structure.hidden from -1 to 0 for several subfields of 952, in both the default and fast add framework, using this SQL statement: update marc_subfield_structure set hidden = 0 where tagfield = '952' and hidden = -1; - Add the maxlength column introduced by bug 7263 to all rows in marc_subfield_structure, setting the following maxlengths: 000 = 24 008 = 40 all other subfields = 9999 The format of the SQL files is the one that is produced by exporting the frameworks from the Web UI, with added copyright comments at the top. To test: - Install nb-NO - Run through the web installer in Norwegian on an empty database - Select NORMARC as the marcflavour - Be sure to select the fast add framework ("Rammeverk for hurtigkatalogisering" under "Valgritt") - Check in Home › Administration › MARC Frameworks that 000 and 008 for both frameworks have the right length - Add a dummy record so you get to the item edit screen and check that the form for subfields looks good. The subfields that are shown should be 01234578abcdefghjoptuvwyz and all subfields should have a text box or a dropdown associated with them. Check this for for both the default and fast add frameworks Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Walked through the test plan, seems to work well. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7850 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- NORMARC only, and I'll trust the textual content to be correct. Looks to be safe SQL changes, clear and clean (if a little tedious to read through, thanks to Gits line-by-line basis instead of char-by-char). Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7850 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7263 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7850 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.