[Bug 16160] New: t/db_dependent/www/search_utf8.t fails due to layout change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Bug ID: 16160 Summary: t/db_dependent/www/search_utf8.t fails due to layout change Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com Aparently, a layout change made the tests fail. To reproduce: - Run (on kohadevbox:ansible) $ sudo koha-shell kohadev $ cd kohaclone $ prove t/db_dependent/www/search_utf8.t => FAIL: mainsubmitform is not found, and the tests hang -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I mark this as major because a POC of the fix made some UTF-8 related tests fail, and need help debugging it (ran out of time today). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49654&action=edit Bug 16160: Fix t/../www/search_utf8.t for layout change Some of the include files in tools/manage-marc-import.tt introduced a new form object so the form index for the tests needed to be changed to match the new layout. While testing this I also found that due to the new record_type input in stage-marc-import.tt the tests would fail if run on an instance with already imported stuff (i.e. the import id was defaulting to zero). This might have been the cause of some random failures in jenkins befire we started to DROP / re-CREATE the DB. To test: - Run (on kohadevbox:ansible) $ sudo koha-shell kohadev $ cd kohaclone $ prove t/db_dependent/www/search_utf8.t => FAIL: mainsubmitform is not found, and the tests hang - Apply the patch - re-run the tests: $ prove t/db_dependent/www/search_utf8.t => SUCCESS: Tests now pass! - Sign off Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Tests are not failing with the patch, false alarm. But it is worth pushing ASAP, becasue we have a useless jenkins right now, due to this tests hanging forever. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- For non kohadevbox:ansible users willing to test this, you can run it on a regular dev setup, provided you already set this environment variables (adjust values to your setup): export KOHA_USER=koha_kohadev export KOHA_PASS=password export KOHA_INTRANET_URL=http://localhost:8080 export KOHA_OPAC_URL=http://localhost:80 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm, It looks like it hangs if you have the wrong settings still. prove t/db_dependent/www/search_utf8.t t/db_dependent/www/search_utf8.t .. Error GETing http://localhost:5001/cgi-bin/koha/mainpage.pl: Can't connect to localhost:5001 (Connection refused) at t/db_dependent/www/search_utf8.t line 117 # Looks like your test exited with 111 before it could output anything. It's hung there ... 10 minutes now, that is with the patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Chris Cormack from comment #5)
Hmm, It looks like it hangs if you have the wrong settings still.
prove t/db_dependent/www/search_utf8.t t/db_dependent/www/search_utf8.t .. Error GETing http://localhost:5001/cgi-bin/koha/mainpage.pl: Can't connect to localhost:5001 (Connection refused) at t/db_dependent/www/search_utf8.t line 117 # Looks like your test exited with 111 before it could output anything.
It's hung there ... 10 minutes now, that is with the patch applied.
That'd be bug 14158, for which I haven't written a patch! This one is simpler, just a layout change, reflected on the WWW::Mechanize use. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49654|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49675&action=edit Bug 16160: Fix t/../www/search_utf8.t for layout change Some of the include files in tools/manage-marc-import.tt introduced a new form object so the form index for the tests needed to be changed to match the new layout. While testing this I also found that due to the new record_type input in stage-marc-import.tt the tests would fail if run on an instance with already imported stuff (i.e. the import id was defaulting to zero). This might have been the cause of some random failures in jenkins befire we started to DROP / re-CREATE the DB. To test: - Run (on kohadevbox:ansible) $ sudo koha-shell kohadev $ cd kohaclone $ prove t/db_dependent/www/search_utf8.t => FAIL: mainsubmitform is not found, and the tests hang - Apply the patch - re-run the tests: $ prove t/db_dependent/www/search_utf8.t => SUCCESS: Tests now pass! - Sign off Regards Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tomas, did you notice that the tests do not pass if plack is enabled? $ prove t/db_dependent/www/search_utf8.t t/db_dependent/www/search_utf8.t .. 9/66 0% completed at t/db_dependent/www/search_utf8.t line 181. t/db_dependent/www/search_utf8.t .. 37/66 Link not found at t/db_dependent/www/search_utf8.t line 127. # Looks like you planned 66 tests but ran 37. # Looks like your test exited with 255 just after 37. ^C -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16160 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |julian.maurice@biblibre.com Status|Pushed to Master |RESOLVED --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Tests pass on 3.22.x without this patch, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org