[Bug 36164] New: Bring more consistency to our module landing pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Bug ID: 36164 Summary: Bring more consistency to our module landing pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Koha's modules have a variety of landing page designs. We should try to move to a more consistent approach across landing pages. This bug serves as a collector for such work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 [Bug 36150] Circulation home page styling does not match Cataloging home page styling -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21482 [Bug 21482] Create a "landing page" for ILL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23478 [Bug 23478] Simplify report landing page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36165 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 [Bug 36165] Update "Tools" landing page to be more consistent with 'Cataloging' and 'Circulation' landing pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Hackfest -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162433&action=edit Bug 36164: Proof of concept This PoC serves the purpose of DRYing the markup and logic present in cataloging-home to ensure consistency between module landing pages going forward. This abstraction would then also be done in circulation-home. And after that, in tools-home and/or other adopting modules in the future. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |david@davidnind.com, | |jonathan.druart+koha@gmail. | |com, | |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I've submitted a PoC and would love feedback on it to justify investing more time in it or not. The test plan from the user perspective is to just visit <staff_url>/cgi-bin/koha/cataloguing/cataloging-home.pl and make sure everything is working as before. The purpose of this work is to ensure consistency across module landing pages going forward, having a single place where markup (and logic) is maintained and extended, as opposed to WET (write everytime). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Bug 36164 depends on bug 36150, which changed state. Bug 36150 Summary: Circulation home page styling does not match Cataloging home page styling https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36150 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162433|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166049&action=edit Bug 36164: Proof of concept This PoC serves the purpose of DRYing the markup and logic present in cataloging-home to ensure consistency between module landing pages going forward. This abstraction would then also be done in circulation-home. And after that, in tools-home and/or other adopting modules in the future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 [Bug 36751] Creating new patron attribute types should start with type choice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 --- Comment #4 from David Nind <david@davidnind.com> --- Totally support this idea!
From testing the PoC patch, everything looks and works the same as before.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I like it. Some things: * There is margin 1rem 0 from .toptabs that makes #sub-header no longer sticking #header_search https://snipboard.io/7XhEir.jpg vs https://snipboard.io/csJ5CR.jpg * + [%# FIXME: Confirm messages.inc is needed. Neither circulation-home and cataloging-home use output_and_exit from C4::Output#%] We want messages.inc EVERYWHERE. It has the "wrong csrf-token" error, and ideally we will use it for all our dialog messages/errors. * Bad news, we cannot split TT directives on several lines (see bug 18675). * I would move the BLOCKs from html_helpers.inc to a separate include file (html_helpers/landing_page.inc?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36751 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 [Bug 36751] Creating new patron attribute types should start with type choice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Initiative type|--- |Epic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Initiative type|Epic |Meta -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39320 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39320 [Bug 39320] Create a 'landing page' for ERM -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org