[Bug 4208] New: Many submit buttons are not translatable in 3.2
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 Summary: Many submit buttons are not translatable in 3.2 Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: critical Priority: P1 Component: I18N/L10N AssignedTo: chris@bigballofwax.co.nz ReportedBy: katrin.fischer@bsz-bw.de Estimated Hours: 0.0 Change sponsored?: --- After an translation update we noticed that many buttons are now in English (examples below). We see this in our production installations (3.01.00.061) and our test installation from HEAD (3.01.00.117 patched from 3.01.00.061) The text strings seem to be not in current .po files. I searched Pootle (French and German) without success. Examples: INTRANET Patron account > tabs Check Out (moremember.pl) and Details (circulation.pl): Renew or Return checked Items, Renew all, Return all Patron account > tab fines (pay.pl, mancredit.pl) Make payment, Add Credit Edit Item (additem.pl): Add item, Add & Duplicate, Add Multiple Copies OPAC Patron account > my summary (opac-user.pl): Renew all Patron account > my purchase suggestions (opac-suggestions.pl): Delete checked items Patron account > change password (opac-passwd.pl) Submit changes -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-04-06 14:37:28 --- We updated our test installation with updated po files from Pootle. All my examples are now translated and I found no other untranslated submit buttons. I'm not sure if this problem is already fixed in HEAD or only for Pootle, so leaving this bug open. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-04-07 08:36:46 --- Patch was sent by Henri-Damien LAURENT to koha-patches: http://lists.koha.org/pipermail/koha-patches/2010-March/005872.html Chris applied the patch locally and ran the update on the German files, before I tested them in our installation. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-04-13 09:14:41 --- Created an attachment (id=1802) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1802) untranslated strings in opac detail Opac detail page misses a lot of translations (see screenshot) I cant find "more searches" in Pootle. I can find "Save Record:", but opac-detail is missing from the template list (/home/chris/git/koha.git/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tmpl:80 /home/chris/git/koha.git/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tmpl:197) Expanded MARC View and ISBD View show translated links. Perhaps a problem with opac-detail.pl? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-04-22 18:46:44 --- I updated my test installation to current head and updated the po files for opac. I got a lot of error messages from the update scripts and opac-detail is still mostly unstranslated The translation of xslt files for result page and opac detail seem to be broken too. Part of error messages for opac-detail.tmpl: Warning: opac-detail.tmpl: line 74: Probably missing whitespace before or missing quotation mark near: http://www.syndetics.com/index.aspx?isbn=<!-- TMPL_VAR NAME="normalized_isbn" -->/<!-- /TMPL_IF --><!-- TMPL_VAR NAME="SyndeticsCoverImageSize" -->.GIF&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" -->&type=xw10<!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" --> xgettext.pl: Warning: opac-detail.tmpl: line 260: SGML "closed start tag" notation: <a target="_blank" href="https://secure.syndetics.com/ffseries.aspx?isbn=<!--TMPL_ELSE --><a target="_blank" href="http://www.syndetics.com/ffseries.aspx?isbn=<!-- /TMPL_IF --><!-- TMPL_VAR NAME="normalized_isbn" -->&type=series&num=1&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" -->< xgettext.pl: Warning: opac-detail.tmpl: line 260: Strange attribute syntax: _blank" href="http://www.syndetics.com/ffseries.aspx?isbn=<!-- /TMPL_IF --><!-- TMPL_VAR NAME="normalized_isbn" -->&type=series&num=1&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" --> xgettext.pl: Warning: opac-detail.tmpl: line 265: SGML "closed start tag" notation: <a target="_blank" href="https://secure.syndetics.com/index.aspx?isbn=<!-- TMPL_ELSE --><a target="_blank" href="http://www.syndetics.com/index.aspx?isbn=<!-- /TMPL_IF --><!-- TMPL_VAR NAME="normalized_isbn" -->/avprofile.html&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" -->< xgettext.pl: Warning: opac-detail.tmpl: line 265: Strange attribute syntax: _blank" href="http://www.syndetics.com/index.aspx?isbn=<!-- /TMPL_IF --><!-- TMPL_VAR NAME="normalized_isbn" -->/avprofile.html&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" --> xgettext.pl: Warning: opac-detail.tmpl: line 270: SGML "closed start tag" notation: <a target="_blank" href="https://secure.syndetics.com/index.aspx?isbn=<!-- TMPL_ELSE --><a target="_blank" href="http://www.syndetics.com/index.aspx?isbn=<!-- /TMPL_IF --><!-- TMPL_VAR NAME="normalized_isbn" -->/fiction.html&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" -->< xgettext.pl: Warning: opac-detail.tmpl: line 270: Strange attribute syntax: _blank" href="http://www.syndetics.com/index.aspx?isbn=<!-- /TMPL_IF --><!-- TMPL_VAR NAME="normalized_isbn" -->/fiction.html&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" --> xgettext.pl: Warning: opac-detail.tmpl: line 275: SGML "closed start tag" notation: <a target="_blank" href="https://secure.syndetics.com/ffawards.aspx?isbn=<!-- TMPL_ELSE --><a target="_blank" href="http://www.syndetics.com/ffawards.aspx?isbn=<!-- /TMPL_IF --><!-- TMPL_VAR NAME="normalized_isbn" -->&type=awards&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" -->< xgettext.pl: Warning: opac-detail.tmpl: line 275: Strange attribute syntax: _blank" href="http://www.syndetics.com/ffawards.aspx?isbn=<!-- /TMPL_IF --><!-- TMPL_VAR NAME="normalized_isbn" -->&type=awards&client=<!-- TMPL_VAR NAME="SyndeticsClientCode" --><!-- TMPL_IF NAME="normalized_upc" -->&upc=<!-- TMPL_VAR NAME="normalized_upc" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="normalized_oclc" -->&oclc=<!-- TMPL_VAR NAME="normalized_oclc" --> xgettext.pl: Warning: opac-detail.tmpl: line 302: Possible SGML "closed start tag" notation: <script src="https://www.librarything.com/forlibraries/widget.js?id=<!-- TMPL_ELSE --><script src="http://www.librarything.com/forlibraries/widget.js?id=<!-- /TMPL_IF -->< xgettext.pl: Warning: opac-detail.tmpl: line 302: Unrecognizable token found: (too confused to show details) -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2010-04-22 19:29:28 --- Created an attachment (id=1815) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1815) Proposed fix This patch addresses the Syndetics/Librarything errors by eliminating TMPL_IFs nested inside HTML tags. This fix should be tested both for compatibility with the translation script and by a Syndetics user to confirm I haven't broken anything. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |jwagner@ptfs.com --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2010-04-22 19:35:24 --- CC'ing jwagner on this bug in the hopes that she can test my patch with a Syndetics client ID. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> 2010-04-23 10:54:03 --- Pushed Owen's patch. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #8 from Jane Wagner <jwagner@ptfs.com> 2010-04-23 12:36:39 --- Owen, I do not have a server at current head that's set up with Syndetics. I updated my current head test server this morning, and copied over a Syndetics ID from another system. I am getting no Syndetics content at all in the test server. I don't know if that's a result of the patch or a problem with the Syndetics ID; can someone else running Syndetics also test? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2010-04-23 18:41:19 --- Update: All submit buttons are now translated, so this part of the bug is fixed. opac-detail is a lot better, everything is translated now except the xslt file. The translator script still gives a lot of errors when updating the po files. I will open a new bug for the problem with xslt file translation. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> 2010-05-05 18:26:43 --- Created an attachment (id=1876) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1876) Proposed fix -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4208 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2010-05-05 18:38:45 --- "$ prove xt/author/translatable-templates.t" still reports: "# xgettext.pl: Warning: opac-opensearch.tmpl: line 38: Possible SGML "closed start tag" notation: <
bugzilla-daemon＠kohaorg.ec2.liblime.com