[Bug 16933] New: Alt-Y not working on "Please confirm checkout" dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Bug ID: 16933 Summary: Alt-Y not working on "Please confirm checkout" dialogs Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: tmcmahon@wlpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The alt-Y key which used to select Yes in circulation dialogs switches to the renew tab instead. I also noticed that the new "Don't check out and print slip (P)" button doesn't work with alt-P either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tmcmahon@wlpl.org --- Comment #1 from tmcmahon@wlpl.org --- Created attachment 54941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54941&action=edit Patch to fix Alt+y for selecting Yes to prompts This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54941|Patch to fix Alt+y for |Patch to fix Alt+y for description|selecting Yes to prompts |selecting Yes at dialogs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch --- Comment #2 from tmcmahon@wlpl.org --- I didn't know why Alt+y was used for renew, so I changed it to Alt+w so it doesn't conflict with Alt+y to answer yes in dialogs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tmcmahon@wlpl.org |ity.org | Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hello, You patch is not correctly formated. Please have a look at https://wiki.koha-community.org/wiki/SubmitingAPatch and then switch the status to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54941|0 |1 is patch| | Attachment #54941|Patch to fix Alt+y for |Bug 16933: Alt+y not description|selecting Yes at dialogs. |working on "Please confirm | |checkout " dialogs | | | |The | |keyboard shortcut for renew | |is also set to Alt+y. | |Change the key | |for renew | |from Alt+y to Alt+w. | | | | | |To | |test: | |1) Press Alt+y when | |you get a "Please confirm | |checkout" dialog. | |2) The | |renew tab is selected | |instead of confirming the | |dialog. | |3) Apply the patch | |and refresh your browser to | |load the change. | |4) Repeat | |step one. | |5) Alt+y confirms | |the checkout, Alt+w selects | |the renew tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54941|Bug 16933: Alt+y not |Bug 16933: Alt+y not description|working on "Please confirm |working on "Please confirm |checkout " dialogs |checkout " dialogs | | |The | |keyboard shortcut for renew | |is also set to Alt+y. | |Change the key | |for renew | |from Alt+y to Alt+w. | | | | | |To | |test: | |1) Press Alt+y when | |you get a "Please confirm | |checkout" dialog. | |2) | --- Comment #4 from tmcmahon@wlpl.org --- Comment on attachment 54941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54941 Bug 16933: Alt+y not working on "Please confirm checkout " dialogs The keyboard shortcut for renew is also set to Alt+y. Change the key for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54941|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55362&action=edit [SIGNED-OFF] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In order to select Yes I need to do alt+shift+y - It makes sense as it's a Y, but leaving a note anyway :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The new shortcut for renewal should be added to the help file on the circulation home page! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55362|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55457&action=edit [PASSED QA] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 --- Comment #9 from Danielle Elder <danielle@bywatersolutions.com> --- Created attachment 56105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56105&action=edit Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56105|0 |1 is obsolete| | --- Comment #10 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 56114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56114&action=edit Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55457|0 |1 is obsolete| | Attachment #56114|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56448&action=edit [PASSED QA] Bug 16933 - Alt-Y not working on "Please confirm checkout" dialogs This patch changes the keyboard shortcut for renew from Alt+y to Alt+w. To test: 1) Press Alt+y when you get a "Please confirm checkout" dialog. 2) The renew tab is selected instead of confirming the dialog. 3) Apply the patch and refresh your browser to load the change. 4) Repeat step one. 5) Alt+y confirms the checkout, Alt+w selects the renew tab. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56451&action=edit [PASSED QA] Bug 16933 - Update documentation/help file. Updates help documentation about Alt+W to open renew tab. To test: Go to circulation help page, open help file and see that new line mentioning Alt+W. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure the version setting here is correct - I tested this on master pre 16.11 release. I am resetting it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Tim, Dani! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x, will be in 16.11.02 . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Depends on| |12051 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- For reference, this shortcut has been introduced by bug 12051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 [Bug 12051] add renew tab to top on staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |CLOSED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #17 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org