[Bug 25134] New: Return claims column should not be shown if ClaimReturnedLostValue is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Bug ID: 25134 Summary: Return claims column should not be shown if ClaimReturnedLostValue is not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the checkouts table shown on circulation and patron details the "Return claims" column should be wrapped in a conditional checking for the presence of a value in the ClaimReturnedLostValue system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This bug might be dependent on Bug 24768? I'm confused by what's going on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I thought it would be the easiest fix to add it to column configuration, because I wanted to be able to hide it for libraries not wanting to use it (it takes up quite a bit of space). Not sure if a conditional check would mean additional work is needed on not bug 24768. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |14697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Katrin, you also filed bug 25583, about how the Claims tab doesn't show if ClaimReturnedLostValue isn't set. If we make the return claims column also not show, does that resolve your issue in 25583? If both the column and the tab hid themselves when the syspref isn't set, then one wouldn't be able to generate a claim one was then unable to manage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #4 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- At the moment we're not using the Claims Returned feature because it doesn't work with our local policies. Our ClaimReturnedLostValue is not set but we still see the Claims tab on circulation and patron details. We agree that the tab should be hidden when the syspref isn't set because it is confusing to staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Never mind my previous comment. We discovered we had a blank space in the ClaimReturnedLostValue so that's why it was displaying. So nothing to see here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- But, following Barbara's comment, it might not be unreasonable to only show the Claims Returned controls if the syspref contains a *valid* lost value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't recreate the original issue described in comment 0. (In reply to Andrew Fuerste-Henry from comment #6)
But, following Barbara's comment, it might not be unreasonable to only show the Claims Returned controls if the syspref contains a *valid* lost value.
I would suggest a check and warning on the about page instead. Should we update the bug report's title? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Return claims column should |Return claims column should |not be shown if |not be shown if |ClaimReturnedLostValue is |ClaimReturnedLostValue is |not set |not set to a valid value Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25583 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 --- Comment #8 from Michaela Sieber <michaela.sieber@kit.edu> --- I believe this is still valid. I see the claims tab although ClaimReturnedLostValue is emty (and no blank space) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe the claims tab is now also used for the item bundle feature, so that might explain some change in behavior/might have taken into account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works if both BundleLostValue and ClaimReturnedLostValue are empty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org