[Bug 14973] New: Suggestions - Search and warn user about existing biblio when submitting a suggestion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Bug ID: 14973 Summary: Suggestions - Search and warn user about existing biblio when submitting a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com QA Contact: testopia@bugs.koha-community.org When submitting a new purchase suggestion, we search for similar document among biblio and show a message if a duplicate is found. User can ignore the message and confirm the suggestion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 43193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43193&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Hi Alex, I tested in Opac: Purchase Suggestions Existing Biblio with item: Wachtmeister Studers erste Fälle by Friedrich Glauser Suggested: Wachtmeister Studers erste Fälle -> Duplicate messsage Wachtmeister Studer -> No message Wachtmeister Studers -> No message Wachtmeister Studers erste -> No Message Studers erste Fälle -> No message Combining full title with full Author Wachtmeister Studers erste Fälle Friedrich Glauser -> No Message Wachtmeister Studers erste Fälle Glauser, Friedrich -> No Message Combining full title with partial Author Wachtmeister Studers erste Fälle Glauser -> No Message So it seems to work with the full title only. Is this intended? Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- Hello Marc, I used C4::Search::FindDuplicate which seems to require almost the full title / author. Either we fix findDuplicate to make it more flexible or we create an other subrutine (using simpleSearch ?) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #4 from Marc Véron <veron@veron.ch> --- Hi Alex, Maybe simpleSearch is better in this case. Can you give it a try? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #5 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- I would say not finding a match on a partial title is ok. Otherwise we'll have a lot of fake positives, which will be unsettling for our users and might discourage them from creating suggestions. However, not finding a match when the full title and the author was entered is definitely a bug for me. I think if findDuplicate says there is a duplicate when just the title is entered, it should definitely find one if both title and author are entered. I am not sure about how it works though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- I agree with Gaetan. If we use simpleSearch, this means that if we type "Dragons" as a title, a book like "Rise of the Dragons" could be shown as a duplicate to the user. I think this is not what we want. However, findDuplicate should be able to find duplicate when typing full title and author. So i think we should fix this sub. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #7 from Alex Arnaud <alex.arnaud@biblibre.com> --- I go back on my word about findDuplicate. Searching duplicates with full title and author works for me. I have a book: Les montagnes from Keith Lye. Submit a suggestion with title "Les montagnes" => duplicate message Submit a suggestion with title "Les montagnes" and author "Keith Lye" => duplicate message Submit a suggestion with title "Les montagnes", author "Keith Lye" and itemtype "Book" => duplicate message. Anyone has the same problem than Marc ? I will send a new patch because i have broken the itemtypes list in the form -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 44091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44091&action=edit Bug 14973 - Fix broken itemtypes list in opac-suggestions form -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com --- Comment #9 from Nicole Engard (ByWater) <nicole@bywatersolutions.com> --- I don't see a test plan on this - can you add one and then I'll happily test. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43193|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 44319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44319&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44091|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 44320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44320&action=edit Bug 14973 - Fix broken itemtypes list in opac-suggestions form -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #12 from Alex Arnaud <alex.arnaud@biblibre.com> --- Nicole, I have added the test plan to the commit message of the first commit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44319|0 |1 is obsolete| | --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44334&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44320|0 |1 is obsolete| | --- Comment #14 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44335&action=edit Bug 14973 - Fix broken itemtypes list in opac-suggestions form Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #15 from Nicole C. Engard <nengard@gmail.com> --- This is neat, it's not super powerful, but I see how one day it could be. I'll note in the documentation that it only works if the title and the name are exact - so if I enter author Barbara Kingsolver it doesn't find her, but if I put in Kingsolver, Barbara it does. Still a good feature that doesn't break anything that I can see :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- I agree it's not super-powerfull, and I also agree with Alex about using FindDuplicate. The next step is probably to improve FindDuplicate. idea : using the matching points system. Opening a ticket for that now ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15248 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Alex, 1/ I think MarcRecordFromSuggestion is confusing. It does not take an existing suggestion in parameter, and that's why you use the default framework to get the marc fields. Either you rename it with something like MarcRecordFromNewSuggestion, or you take into account that this suggestion can already be linked to a record. 2/ Should not we have the same behavior on the staff side? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org