[Bug 9050] New: rebuild_zebra should use the adelete action so it doesn't fail when deleting a record not in the index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 Priority: P5 - low Change sponsored?: --- Bug ID: 9050 Assignee: gmcharlt@gmail.com Summary: rebuild_zebra should use the adelete action so it doesn't fail when deleting a record not in the index Severity: major Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Searching Product: Koha
From the man page of zebraidx: delete directory Remove the records corresponding to the files found under directory from the register.
adelete directory Remove the records corresponding to the files found under directory from the register. Unlike command delete this command does not fail if a record does not exist (but which is attempted deleted). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13373&action=edit Bug 9050: Use safer adelete when deleting records from Zebra index Previously we used the "delete" command in zebraidx, which fails when you try to delete a record that doesn't exist in the index. By changing to the "adelete" command, we can reduce the likelihood of a failed delete causing ghost records. A symptom of this problem is the warning message occasionally encountered when indexing from the zebraqueue, "[warn] cannot delete record above (seems new)." To test: 1) Add a recordDelete action for a record that does not exist to zebraqueue in MySQL: INSERT INTO zebraqueue (biblio_auth_number, operation, server) \ VALUES (999999999, 'recordDelete', 'biblioserver'); 2) Run `rebuild_zebra.pl -b -z -v [-x]`. 3) Note that you do not get the message "[warn] cannot delete record above (seems new)". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13373|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13381&action=edit Bug 9050: Use safer adelete when deleting records from Zebra index Previously we used the "delete" command in zebraidx, which fails when you try to delete a record that doesn't exist in the index. By changing to the "adelete" command, we can reduce the likelihood of a failed delete causing ghost records. A symptom of this problem is the warning message occasionally encountered when indexing from the zebraqueue, "[warn] cannot delete record above (seems new)." To test: 1) Add a recordDelete action for a record that does not exist to zebraqueue in MySQL: INSERT INTO zebraqueue (biblio_auth_number, operation, server) \ VALUES (999999999, 'recordDelete', 'biblioserver'); 2) Run `rebuild_zebra.pl -b -z -v [-x]`. 3) Note that you do not get the message "[warn] cannot delete record above (seems new)". Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|master |3.8 QA Contact| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * tiny (one char) patch that fixes an uncommon problem, worth being fixed. passed QA (not sure it's a major problem though, if there's not other effect than the warning, it's a minor one. Not changing severity, but if someone agree with me, feel free !) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #3)
QA comment * tiny (one char) patch that fixes an uncommon problem, worth being fixed.
passed QA
(not sure it's a major problem though, if there's not other effect than the warning, it's a minor one. Not changing severity, but if someone agree with me, feel free !)
Definitely a major problem. The warning is only a symptom. The reason it's a problem is that nothing is processed after that warning but the entries are still marked as done in zebraqueue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9050 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org