[Bug 41280] New: Adjust PatronLibrary scope, respect global level for the second patron_maxissueqty rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Bug ID: 41280 Summary: Adjust PatronLibrary scope, respect global level for the second patron_maxissueqty rule Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com See bug 27834. Thinking here about an alternative approach (without messing up the original report). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adjust PatronLibrary scope, |Adjust PatronLibrary scope, |respect global level for |respect global level for |the second |the second |patron_maxissueqty rule |patron_maxissueqty rule in | |C4::Circulation::TooMany -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 189836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189836&action=edit Bug 41280: Add check on branchcode of patron_maxissueqty rule Test plan: Still coming -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 189837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189837&action=edit Bug 41280: Add patron library scope to PatronLibrary for branch level rules At the same time bringing both CircControl blocks more in sync by using $branch and a new $prefetch variable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189836|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 189838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189838&action=edit Bug 41280: Add check on branchcode of patron_maxissueqty rule Test plan: Still coming -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189837|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 189839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189839&action=edit Bug 41280: Add patron library scope to PatronLibrary for branch level rules At the same time bringing both CircControl blocks more in sync by using $branch and a new $prefetch variable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Fixed: Can't call method "branchcode" on unblessed reference at /usr/share/koha/C4/Circulation.pm line 594 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27834 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41290 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 189911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189911&action=edit Bug 41280: Fix missing branchcode for patron qty rule Since we now want to check if the rule is global or not, we need more than the rule value returned by GetBranchBorrowerCircRule. This highlights another issue in this code (for a new report): the code assumes that there is a regular issue rule on the same level (global or branch) for regular issues when counting onsite issues. Theoretically, this may not be the case. Added FIXMEs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Opened bug 41290 to have a closer look at circ scope for onsite checkouts. This feels wrong as it is now (too much assumptions). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Before getting further here, I need feedback. After that we can fix tests etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41280 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org