https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745 [Bug 24745] OPAC news block plugin should evaluate as false if there are no items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104362&action=edit Bug 23223: Convert OpacNav system preference to news block This patch builds on Bug 22318 to move the OpacNav system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> News and verify that the content from OpacMainUserBlock is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacNav_en', 'OpacNav_fr-FR', 'OpacNav_cs-CZ' - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This patch has a couple of issues I know of which I could use help with: - It doesn't work on the reading history page and I don't know why. The "lang" and "branchcode" template variables on that page seem to be wrong. - There are warnings from the QA tool which I think are false positives but I'm not sure. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Everything works well here for me, I test with translation and all is good. When I run the QA tool I do get this failure: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/svc/suggestion.tt OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Bareword found where operator expected Bareword found where operator expected (Missing operator before KohaNews?) Bareword found where operator expected (Missing operator before OpacNav?) Unquoted string "lang" may clash with future reserved word Unquoted string "branchcode" may clash with future reserved word Bareword found where operator expected Bareword found where operator expected Bareword found where operator expected Bareword found where operator expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104453|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109856&action=edit Bug 24223: Convert OpacNav system preference to news block This patch builds on Bug 22318 to move the OpacNav system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> News and verify that the content from OpacMainUserBlock is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacNav_en', 'OpacNav_fr-FR', 'OpacNav_cs-CZ' - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109856|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 110843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110843&action=edit Bug 24223: Convert OpacNav system preference to news block This patch builds on Bug 22318 to move the OpacNav system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> News and verify that the content from OpacMainUserBlock is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacNav_en', 'OpacNav_fr-FR', 'OpacNav_cs-CZ' - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110853&action=edit Bug 24223: (follow-up) Add date to OpacNav news entries This follow-up modifies the atomic update so that it inserts today's date as the "Published on" date. Without that information the system considers the item unpublished and will not display the content. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110853|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 110898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110898&action=edit Bug 24223: (follow-up) Add date to OpacNav news entries This follow-up modifies the atomic update so that it inserts today's date as the "Published on" date. Without that information the system considers the item unpublished and will not display the content. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- The functionality of the svc/suggestion.tt template seems to work. If I enable the AuthorityFile "Did you mean" plugin I get valid results. I wonder if the QA tool expects file ins /svc/* to be something other than template files? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #14)

(In reply to Owen Leonard from comment #13)

...

I wonder if the QA tool expects file ins /svc/* to be something other than template files?

Yes, it's a "bug" in qa-test-tools. Files in a path contained "/svc/" are considered perl files. You can ignore it.

See https://gitlab.com/koha-community/qa-test-tools/-/issues/43 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110897|0 |1 is obsolete| | Attachment #110898|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 113130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113130&action=edit Bug 24223: Convert OpacNav system preference to news block This patch builds on Bug 22318 to move the OpacNav system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> News and verify that the content from OpacMainUserBlock is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacNav_en', 'OpacNav_fr-FR', 'OpacNav_cs-CZ' - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 113132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113132&action=edit Bug 24223: (follow-up) Make logged-in user's branchcode available to template This patch makes a couple of corrections for problems I discovered while working on Bug 24224: The variables required for correct display of news items by branch and language were not consistently available to the templates. In opac-readingrecord.pl, the "lang" variable was being overwritten. On this and other pages the logged-in patron's brachcode was not made available. I've corrected instances of KohaNews.get() to use the globally-available "logged_in_user.branchcode" instead. To test, apply the patch and follow the original test plan, with the addition of instances of the OpacNav news item which have a specific library selected. Confirm that such items are correctly displayed according to the logged-in user's home library. If there is no logged-in user the library-specific OpacNav should not display. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #19 from David Nind <david@davidnind.com> --- The patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113130|0 |1 is obsolete| | Attachment #113131|0 |1 is obsolete| | Attachment #113132|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115758&action=edit Bug 24223: Convert OpacNav system preference to news block This patch builds on Bug 22318 to move the OpacNav system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> News and verify that the content from OpacMainUserBlock is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacNav_en', 'OpacNav_fr-FR', 'OpacNav_cs-CZ' - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115760&action=edit Bug 24223: (follow-up) Make logged-in user's branchcode available to template This patch makes a couple of corrections for problems I discovered while working on Bug 24224: The variables required for correct display of news items by branch and language were not consistently available to the templates. In opac-readingrecord.pl, the "lang" variable was being overwritten. On this and other pages the logged-in patron's brachcode was not made available. I've corrected instances of KohaNews.get() to use the globally-available "logged_in_user.branchcode" instead. To test, apply the patch and follow the original test plan, with the addition of instances of the OpacNav news item which have a specific library selected. Confirm that such items are correctly displayed according to the logged-in user's home library. If there is no logged-in user the library-specific OpacNav should not display. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Bug 24223 depends on bug 27451, which changed state. Bug 27451 Summary: Split opac_news.lang into two distinct fields for location and language https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27451 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115758|0 |1 is obsolete| | Attachment #115759|0 |1 is obsolete| | Attachment #115760|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124935&action=edit Bug 24223: Convert OpacNav system preference to additional content This patch builds on Bug 22318 to move the OpacNav system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNav is now stored there. When you edit the entry you should see content for each of the enabled translations in your system under each tab. - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124937&action=edit Bug 24223: (follow-up) Make logged-in user's branchcode available to template This patch makes a couple of corrections for problems I discovered while working on Bug 24224: The variables required for correct display of news items by branch and language were not consistently available to the templates. In opac-readingrecord.pl, the "lang" variable was being overwritten. On this and other pages the logged-in patron's brachcode was not made available. I've corrected instances of KohaNews.get() to use the globally-available "logged_in_user.branchcode" instead. To test, apply the patch and follow the original test plan, with the addition of instances of the OpacNav additional contents item which have a specific library selected. Confirm that such items are correctly displayed according to the logged-in user's home library. If there is no logged-in user the library-specific OpacNav should not display. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28925 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124936|0 |1 is obsolete| | --- Comment #29 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 125301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125301&action=edit Bug 24223: (follow-up) Add date to OpacNav additional content entries This follow-up modifies the atomic update so that it inserts today's date as the "Published on" date. Without that information the system considers the item unpublished and will not display the content. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124938|0 |1 is obsolete| | --- Comment #31 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 125303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125303&action=edit Bug 24223: (follow-up) Updates to conform to new practices - The patch now works with new "Additional contents" system - The database update follows new skeleton.pl - Add "OpacNav" option to the additional contents template Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- I signed existing patches. But also added one : Bug 24223: (follow-up) Do not add id 'opacnav' in navigation.inc Like in Bug 28927, no need anymore to create a div with id 'opacnav' : it will generate a div with id="opacnav" and one inside with id="OpacNav". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125300|0 |1 is obsolete| | Attachment #125301|0 |1 is obsolete| | Attachment #125302|0 |1 is obsolete| | Attachment #125303|0 |1 is obsolete| | Attachment #125304|0 |1 is obsolete| | --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125767&action=edit Bug 24223: Convert OpacNav system preference to additional content This patch builds on Bug 22318 to move the OpacNav system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNav is now stored there. When you edit the entry you should see content for each of the enabled translations in your system under each tab. - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125769&action=edit Bug 24223: (follow-up) Make logged-in user's branchcode available to template This patch makes a couple of corrections for problems I discovered while working on Bug 24224: The variables required for correct display of news items by branch and language were not consistently available to the templates. In opac-readingrecord.pl, the "lang" variable was being overwritten. On this and other pages the logged-in patron's brachcode was not made available. I've corrected instances of KohaNews.get() to use the globally-available "logged_in_user.branchcode" instead. To test, apply the patch and follow the original test plan, with the addition of instances of the OpacNav additional contents item which have a specific library selected. Confirm that such items are correctly displayed according to the logged-in user's home library. If there is no logged-in user the library-specific OpacNav should not display. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 125771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125771&action=edit Bug 24223: (follow-up) Do not add id 'opacnav' in navigation.inc Id attribut will be defined by 'koha_news_block'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 28650 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Skeleton should include a return of a hash like: return { bug_number => "BUG_NUMBER", description => "A single line description", up => sub { my ($args) = @_; my ($dbh, $out) = @$args{qw(dbh out)}; # Do you stuffs here $dbh->do(q{}); # Print useful stuff here say $out "Update is going well so far"; }, } You do not return a hash, but you start a block with { } -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Explaining: FAIL valid Useless use of anonymous hash ({}) in void context -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #40)

You do not return a hash, but you start a block with

Hmm. At least it is not right :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #46 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #43)

No blocker, but you might wanna take a look at:

Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt line 264. Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 300. Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 303.

I don't think this is related to the changes made by my patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126147&action=edit Bug 24223: Get languages for OPAC There were 2 warnings Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. Use of uninitialized value $theme in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Opened bug 29245 for improving getTranslatedLanguages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is weird: Dates got mixed up somewhere. I have 2026-08-01 in additional_contents.published_on. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The following observations are broader than the scope of this report. But I am mentioning them here anyhow: Listview shows: See HTML customizations. This 'See' is confusing. The toggle between news and contents could be improved imo. List view on tools/additional-contents.pl: Shows me one title, altough I have titles per language. Display location on tools/additional-contents.pl: Bit strange to see lc and uc here like OpacNav and opacheader. ArticleRequestsDisclaimerText at the end. We should sort this list. Sometimes it seems like the Contents textarea only expands when it gets focus (even with a very small delay or so)? Going back from an additional contents item, I should be returning to additional contents, not news. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #55)

The following observations are broader than the scope of this report. But I am mentioning them here anyhow:

Listview shows: See HTML customizations. This 'See' is confusing. The toggle between news and contents could be improved imo.

How? What do you suggest?

List view on tools/additional-contents.pl: Shows me one title, altough I have titles per language.

I don't understand, can you post a screenshot?

Display location on tools/additional-contents.pl: Bit strange to see lc and uc here like OpacNav and opacheader. ArticleRequestsDisclaimerText at the end. We should sort this list.

Yes, sorted would be good. The uc/lc mismatch is because of the original syspref's names. Ideally we should rename them but keep the code in parenthesis (?)

Sometimes it seems like the Contents textarea only expands when it gets focus (even with a very small delay or so)?

Yes, it's not nice. I think it's a bug in tinymce, or we are doing something wrong with our css.

Going back from an additional contents item, I should be returning to additional contents, not news.

Indeed, an that's an easy to fix. Please report on a separate bug report and link it with bug 24387. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #53)

This is weird: Dates got mixed up somewhere. I have 2026-08-01 in additional_contents.published_on.

See bug 29254 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #60 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #57)

I think adding only the default would make sense to me.

For what it's worth, the idea behind adding to all available languages is to ensure that the content doesn't disappear. Before this patch, anything in OpacNav is displayed for all languages. After this patch OpacNav might not appear for everyone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- If it's "en" it must be the default. If it has a specific language prior the upgrade we should use it and copy the content for default (so two entries in the table). It's what we did on bug 22544. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #64 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #63)

(In reply to Jonathan Druart from comment #62)

...

If it's "en" it must be the default. If it has a specific language prior the upgrade we should use it and copy the content for default (so two entries in the table). It's what we did on bug 22544.

Can you explain that?

Why must en be default and a specific entry be copied? If we only had default, woudl it not display for all installed languages?

Sorry, it was too early. I was referring to the upgrade from bug 24387, where we moved data from the old table structure. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #66 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #65)

So yes, only 1 entry as "default" would make sense to me as well.

Well, no changes needed for that then. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #68 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #66)

(In reply to Jonathan Druart from comment #65)

...

So yes, only 1 entry as "default" would make sense to me as well.

Well, no changes needed for that then.

Actually yes, we need to only insert default. So update atomic update. Will do. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125767|0 |1 is obsolete| | --- Comment #69 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 126484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126484&action=edit Bug 24223: Convert OpacNav system preference to additional content This patch builds on Bug 22318 to move the OpacNav system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNav is now stored there. When you edit the entry you should see content for each of the enabled translations in your system under each tab. - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125769|0 |1 is obsolete| | --- Comment #71 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 126486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126486&action=edit Bug 24223: (follow-up) Make logged-in user's branchcode available to template This patch makes a couple of corrections for problems I discovered while working on Bug 24224: The variables required for correct display of news items by branch and language were not consistently available to the templates. In opac-readingrecord.pl, the "lang" variable was being overwritten. On this and other pages the logged-in patron's brachcode was not made available. I've corrected instances of KohaNews.get() to use the globally-available "logged_in_user.branchcode" instead. To test, apply the patch and follow the original test plan, with the addition of instances of the OpacNav additional contents item which have a specific library selected. Confirm that such items are correctly displayed according to the logged-in user's home library. If there is no logged-in user the library-specific OpacNav should not display. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125771|0 |1 is obsolete| | --- Comment #73 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 126488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126488&action=edit Bug 24223: (follow-up) Do not add id 'opacnav' in navigation.inc Id attribut will be defined by 'koha_news_block'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126147|0 |1 is obsolete| | --- Comment #75 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 126490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126490&action=edit Bug 24223: Get languages for OPAC There were 2 warnings Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. Use of uninitialized value $theme in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #77 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 126492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126492&action=edit Bug 24223: (QA follow-up) Link OpacNav to HTML customizations now In the pref description of OpacNavBottom. (Before obsoleting that one too somewhere soon.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #79 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Some patches will be squashed when pushed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #81 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #80)

1. I may be missing something but I don't understand why we are setting OpacNav from the .tt when we need it in .inc. Why don't we AdditionalContents.get from there?

Is there any best practice about the place of TT's [% USE %] directives? Note that we still didnt tackle the load aborted errors on template plugins where we also use includes.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127338&action=edit Bug 24223: Fix borrowernumber from opac-readingrecord.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126484|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127343&action=edit Bug 24223: Convert OpacNav system preference to additional content This patch builds on Bug 22318 to move the OpacNav system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNav system preference. To make testing easier it's also a good idea to have content in the OpacNavBottom preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNav is now stored there. When you edit the entry you should see content for each of the enabled translations in your system under each tab. - Confirm that the previous contents of OpacNav were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNav preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNav system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNav is also displayed. - Test also using the updated translation. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 24223: (follow-up) Add date to OpacNav additional content entries This follow-up modifies the atomic update so that it inserts today's date as the "Published on" date. Without that information the system considers the item unpublished and will not display the content. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 24223: (follow-up) Make logged-in user's branchcode available to template This patch makes a couple of corrections for problems I discovered while working on Bug 24224: The variables required for correct display of news items by branch and language were not consistently available to the templates. In opac-readingrecord.pl, the "lang" variable was being overwritten. On this and other pages the logged-in patron's brachcode was not made available. I've corrected instances of KohaNews.get() to use the globally-available "logged_in_user.branchcode" instead. To test, apply the patch and follow the original test plan, with the addition of instances of the OpacNav additional contents item which have a specific library selected. Confirm that such items are correctly displayed according to the logged-in user's home library. If there is no logged-in user the library-specific OpacNav should not display. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 24223: (follow-up) Updates to conform to new practices - The patch now works with new "Additional contents" system - The database update follows new skeleton.pl - Add "OpacNav" option to the additional contents template Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 24223: (follow-up) Add missing "return" to atomicupdate Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Bug 24223: (QA follow-up) Link OpacNav to HTML customizations now In the pref description of OpacNavBottom. (Before obsoleting that one too somewhere soon.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126490|0 |1 is obsolete| | --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127345&action=edit Bug 24223: Get languages for OPAC There were 2 warnings Use of uninitialized value $interface in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. Use of uninitialized value $theme in concatenation (.) or string at /kohadevbox/koha/C4/Languages.pm line 121. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126485|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #89 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #81)

(In reply to Jonathan Druart from comment #80)

...

1. I may be missing something but I don't understand why we are setting OpacNav from the .tt when we need it in .inc. Why don't we AdditionalContents.get from there?

Is there any best practice about the place of TT's [% USE %] directives? Note that we still didnt tackle the load aborted errors on template plugins where we also use includes..

The correct answer was: to avoid double fetch. We are actually doing: SET OpacNav = AdditionalContents.get [...] [% IF OpacNav %] [% INCLUDE navigation.inc %] [% END %] And reusing OpacNav from navigation.inc -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #91 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #90)

Is that weird to have OpacNav without OpacNavBottom part of 21.11?

Well, we have OpacNavRight already. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24224 [Bug 24224] Convert OpacNavBottom system preference to news block -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 --- Comment #93 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24223 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.