[Bug 8717] New: Wrong subscription notes are showing in catalogue detail view of serials in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Priority: P5 - low Change sponsored?: --- Bug ID: 8717 Assignee: oleonard@myacpl.org Summary: Wrong subscription notes are showing in catalogue detail view of serials in staff client Severity: minor Classification: Unclassified OS: All Reporter: dcook@prosentient.com.au Hardware: All Status: NEW Version: master Component: Templates Product: Koha The detail.pl file is pushing "notes" when it should be pushing "internalnotes". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 11949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11949&action=edit Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi David, The header column is "Public notes" then I suppose we want to display the public note rather than the internalnotes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Hi Jonathan: I'm not sure where you are looking, but I don't see a header column on the page to which I'm referring. I'll attach a screenshot. (In reply to comment #2)
Hi David, The header column is "Public notes" then I suppose we want to display the public note rather than the internalnotes.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 11994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11994&action=edit Screenshot of "subscription notes" This is the patched version. Ordinarily, it would show "subscription public note" . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #4)
Created attachment 11994 [details] Screenshot of "subscription notes"
This is the patched version. Ordinarily, it would show "subscription public note" .
Yes, sorry, I didn't test at the right place :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11949|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12001&action=edit Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client Changes the subscription note from the opac "notes" to the proper staff client "internalnotes" field. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> ---
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 2a60d49) * 1685fe5 Bug 8717 - Wrong subscription notes are showing in catalogue deta catalogue/detail.pl * catalogue/detail.pl OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org