[Bug 17274] New: Add where come from the memcached config to about.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Bug ID: 17274 Summary: Add where come from the memcached config to about.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 17261 The memcached config can be read from ENV or koha-conf.xml In order to remove any ambiguity, let's inform the user which config is used. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261 [Bug 17261] Add memcached configuration info to about.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55329&action=edit Bug 17274: Display the place where the memcached is picked The memcached config can be read from ENV or koha-conf.xml In order to remove any ambiguity, let's inform the user which config is used. Test plan: 1/ Define the memcached config in ENV and $KOHA_CONF => Go on about page, you should get a warning 2/ Define the memcached config in ENV and not in $KOHA_CONF => Go on about page, you should get a warning 3/ Do not defined the memcached config in ENV or $KOHA_CONF => Go on about page, you should get a warning 4/ Define the memcached config in $KOHA_CONF and not in ENV => Go on about page, you should not get a warning, this is the expected config -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jonathan: Maybe it is better to keep warnings on 'System information'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- (In reply to Tomás Cohen Arazi from comment #2)
Jonathan: Maybe it is better to keep warnings on 'System information'?
The place where the warning is displayed (i.e. same place as info about memcached configuration / Bug 17261) makes sense to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55329|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 55479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55479&action=edit Bug 17274: Display the place where the memcached is picked The memcached config can be read from ENV or koha-conf.xml In order to remove any ambiguity, let's inform the user which config is used. Test plan: 1/ Define the memcached config in ENV and $KOHA_CONF => Go on about page, you should get a warning 2/ Define the memcached config in ENV and not in $KOHA_CONF => Go on about page, you should get a warning 3/ Do not defined the memcached config in ENV or $KOHA_CONF => Go on about page, you should get a warning 4/ Define the memcached config in $KOHA_CONF and not in ENV => Go on about page, you should not get a warning, this is the expected config Followed test plan, works as expected. Signed-off-by: Marc <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add where come from the |Add info about which |memcached config to |memcached config is used to |about.pl |about.pl CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Where is memcached server extracted from koha-conf.xml? I don't see it in Koha::Cache.pm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Frédéric Demians from comment #5)
Where is memcached server extracted from koha-conf.xml? I don't see it in Koha::Cache.pm.
koha::Cache.pm (86~93): $self->{'namespace'} ||= $ENV{MEMCACHED_NAMESPACE}; my @servers = split /,/, $ENV{MEMCACHED_SERVERS} || ''; unless ( $self->{namespace} and @servers ) { my $koha_config = Koha::Config->read_from_file( Koha::Config->guess_koha_conf() ); $self->{namespace} ||= $koha_config->{config}{memcached_namespace} || 'koha'; @servers = split /,/, $koha_config->{config}{memcached_servers} // '' unless @servers; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Frédéric Demians from comment #5)
Where is memcached server extracted from koha-conf.xml? I don't see it in Koha::Cache.pm.
In current master, it reads it from koha-conf.xml BUT it prefers ENV if available. That's why I mentioned it is safe for stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55479|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 57056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57056&action=edit [PASSED QA] Bug 17274: Display the place where the memcached is picked The memcached config can be read from ENV or koha-conf.xml In order to remove any ambiguity, let's inform the user which config is used. Test plan: 1/ Define the memcached config in ENV and $KOHA_CONF => Go on about page, you should get a warning 2/ Define the memcached config in ENV and not in $KOHA_CONF => Go on about page, you should get a warning 3/ Do not defined the memcached config in ENV or $KOHA_CONF => Go on about page, you should get a warning 4/ Define the memcached config in $KOHA_CONF and not in ENV => Go on about page, you should not get a warning, this is the expected config Followed test plan, works as expected. Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Mason James <mtj@kohaaloha.com> --- enhancement, passing for 16.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17274 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The memcached config can be release notes| |read from ENV or | |koha-conf.xml | |In order to | |remove any ambiguity, now | |we inform the user which | |config is used in About | |Koha > Server information | |page. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org