[Bug 36663] New: Biblio detail page - StaffDetailItemSelection hides table elements inconsistently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Bug ID: 36663 Summary: Biblio detail page - StaffDetailItemSelection hides table elements inconsistently Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, jonathan.druart@gmail.com Depends on: 33568 To reproduce: 1- Enable StaffDetailItemSelection 2- Visit a biblio page: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 3- Notice there are no table configuration options on the top right (Columns, Export, Configure). 4- Click the "Show filters" link, notice the table configuration options now show, as well as top and bottom pagers, column filter inputs and search input. 5- Disable StaffDetailItemSelection 6- Visit a biblio page: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 7- Notice that the table configurations options are visible, as well as top and bottom pagers, and search input. 8- Click the "Show filters" link, notice it now only governs the column filter inputs, the other elements mentioned in step 7 are always visible. This does not seem consistent, "Show filters" should behave the same regardless of the value of StaffDetailItemSelection, i.e. it should only hide or show the column filter inputs. Additionally, before bug 33568, I believe the configuration options showed by default (with StaffDetailItemSelection enabled) on k-t-d, and they don't anymore. Patch adding this behavior: https://github.com/Koha-Community/Koha/commit/0db4098 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165262&action=edit Bug 36663: Don't hide table elements if StaffDetailItemSelection is enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |lucas@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- @Joubu would love input here. I'm not 100% sure about my patch or what the code I'm removing is originally supposed to fix/prevent, but the patch solves the issue I described in the first comment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165262|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 165266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165266&action=edit Bug 36663: Don't hide table elements if StaffDetailItemSelection is enabled Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- The purpose of those lines are to hide the pagination if the number of items to display is <= than the number of the number of total items (ie. all the items are displayed on the screen). The idea was to reduce the size of the table when it's not necessary to show the pagination. It was a requirement from testers from bug 33568 so I think we should keep it. However I agree that we could display the buttons however. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- We could have that instead: container.find(".dt-info").remove(); container.find(".table_entries").remove(); container.find(".dataTables_filter").remove(); container.find(".dt_button_clear_filter").remove(); container.find(".bottom.pager").remove(); But then there is a CSS adjustment to provide, the "Columns" button is not on the right with the other 2 buttons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Biblio detail page - |Biblio detail page - |StaffDetailItemSelection |StaffDetailItemSelection |hides table elements |hides items table elements |inconsistently |inconsistently -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165322&action=edit Bug 36663: Adjust datatable button selector This change makes the selector apply specifically to the 'clear filter' button, instead of whatever is the first button as 'clear filter' may or may not exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165323&action=edit Bug 36663: Update alignment of datatable buttons Pack items from the end -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165324&action=edit Bug 36663: Hide specific inner elements, not the whole top pager container 1- Enable StaffDetailItemSelection 2- Visit a biblio page: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 3- Notice there are no table configuration options on the top right (Columns, Export, Configure). 4- Click the "Show filters" link, notice the table configuration options now show, as well as top and bottom pagers, column filter inputs and search input. 5- Disable StaffDetailItemSelection 6- Visit a biblio page: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 7- Notice that the table configurations options are visible, as well as top and bottom pagers, and search input. 8- Click the "Show filters" link, notice it now only governs the column filter inputs, the other elements mentioned in step 7 are always visible. 9- Apply patches, run yarn css:build 10- Repeat 1 and 2. 11- Notice the table configuration options are shown on the top right, and no other table options exist. Further testing: Test clicking hide/show filters Test with StaffDetailItemSelection enabled/disabled Test other datatables in other pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165266|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lucas Gass from comment #9)
Doesn't apply now.
Meant to obsolete the original patch but forgot to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165322|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165326&action=edit Bug 36663: Adjust datatable button selector This change makes the selector apply specifically to the 'clear filter' button, instead of whatever is the first button as 'clear filter' may or may not exist. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165323|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165327&action=edit Bug 36663: Update alignment of datatable buttons Pack items from the end Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165324|0 |1 is obsolete| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165328&action=edit Bug 36663: Hide specific inner elements, not the whole top pager container 1- Enable StaffDetailItemSelection 2- Visit a biblio page: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 3- Notice there are no table configuration options on the top right (Columns, Export, Configure). 4- Click the "Show filters" link, notice the table configuration options now show, as well as top and bottom pagers, column filter inputs and search input. 5- Disable StaffDetailItemSelection 6- Visit a biblio page: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 7- Notice that the table configurations options are visible, as well as top and bottom pagers, and search input. 8- Click the "Show filters" link, notice it now only governs the column filter inputs, the other elements mentioned in step 7 are always visible. 9- Apply patches, run yarn css:build 10- Repeat 1 and 2. 11- Notice the table configuration options are shown on the top right, and no other table options exist. Further testing: Test clicking hide/show filters Test with StaffDetailItemSelection enabled/disabled Test other datatables in other pages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165326|0 |1 is obsolete| | Attachment #165327|0 |1 is obsolete| | Attachment #165328|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165352&action=edit Bug 36663: Adjust datatable button selector This change makes the selector apply specifically to the 'clear filter' button, instead of whatever is the first button as 'clear filter' may or may not exist. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 --- Comment #15 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165353&action=edit Bug 36663: Update alignment of datatable buttons Pack items from the end Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 165354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165354&action=edit Bug 36663: Hide specific inner elements, not the whole top pager container 1- Enable StaffDetailItemSelection 2- Visit a biblio page: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 3- Notice there are no table configuration options on the top right (Columns, Export, Configure). 4- Click the "Show filters" link, notice the table configuration options now show, as well as top and bottom pagers, column filter inputs and search input. 5- Disable StaffDetailItemSelection 6- Visit a biblio page: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 7- Notice that the table configurations options are visible, as well as top and bottom pagers, and search input. 8- Click the "Show filters" link, notice it now only governs the column filter inputs, the other elements mentioned in step 7 are always visible. 9- Apply patches, run yarn css:build 10- Repeat 1 and 2. 11- Notice the table configuration options are shown on the top right, and no other table options exist. Further testing: Test clicking hide/show filters Test with StaffDetailItemSelection enabled/disabled Test other datatables in other pages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Biblio detail page - |Biblio detail page - |StaffDetailItemSelection |Buttons are not displayed |hides items table elements | |inconsistently | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Biblio detail page - |Table configuration options |Buttons are not displayed |on items table don't show | |in staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33568 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663 Bug 36663 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org