[Bug 35614] New: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Bug ID: 35614 Summary: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com Work to be done: - Update cpanfile - JSON::Validator 5.13 is required as well - Build that version on the staging Debian repo for regression testing - Push to stables -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Updating using `cpanm` pulled JSON::Validator@5.14 and everything seems fine with the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 160117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160117&action=edit Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35613 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160117|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 160192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160192&action=edit Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Why is it required to increase the minimum version for these two modules ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- We were having a weird error on a spec regarding collectionFormat and we noticed https://github.com/jhthorsen/mojolicious-plugin-openapi/commit/c972fdd02a05d... Because after updating the updated library the problem went away. To reproduce: 1. Point your REST client to /api/v1/holds 2. Pass x-koha-embed: pickup_library => SUCCESS: You get the results 3. Pass x-koha-embed: biblio => SUCCSS: You get results 4. Pass x-koha-embed: pickup_library,biblio => FAIL: Weird and inconsistent error (i.e. it tells you valid options are... what we passed) 5. Update the library 6. Repeat 4 => SUCCESS: It now works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35658 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What does it mean for the package manager? We need more info here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- libjson-validator-perl buster (oldoldstable) 3.06+dfsg-1: all bullseye (oldstable) 4.14+dfsg-1: all bookworm (stable) 5.14+dfsg-1: all trixie (testing) 5.14+dfsg-1: all sid (unstable) 5.14+dfsg-1: all focal (20.04LTS) 3.23+dfsg-1: all jammy (22.04LTS) 5.05+dfsg-1: all lunar (23.04) 5.13+dfsg-1: all mantic (23.10) 5.14+dfsg-1: all libmojolicious-plugin-openapi-perl bullseye (oldstable) 3.41-1: all bookworm (stable) 5.09-1: all trixie (testing) 5.09-1: all sid (unstable) 5.09-1: all focal (20.04LTS) 2.21-1: all jammy (22.04LTS) 5.02-1: all lunar (23.04) 5.09-1: all mantic (23.10) 5.09-1: all So we still need to package our own. Mason, are you ok with that? We would need to remove the '-really' and provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ping -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Severity|enhancement |major --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- We need to move forward here. ping Mason! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160192|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 164116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164116&action=edit Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
So we still need to package our own.
Mason, are you ok with that? We would need to remove the '-really' and provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09
No need to keep this in SO. Mason, please respond or update our packages accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #11)
(In reply to Jonathan Druart from comment #7)
So we still need to package our own.
Mason, are you ok with that? We would need to remove the '-really' and provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09
No need to keep this in SO. Mason, please respond or update our packages accordingly.
Ok but then now it's PQA whereas it's not ready for push because we are waiting for Mason's feedback? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've pinged Mason about this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #14 from Mason James <mtj@kohaaloha.com> --- (In reply to Marcel de Rooy from comment #11)
(In reply to Jonathan Druart from comment #7)
So we still need to package our own.
Mason, are you ok with that? We would need to remove the '-really' and provide JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09
No need to keep this in SO. Mason, please respond or update our packages accordingly.
hi Marcel, i've updated the packages in the staging repo i've had to keep the '+really' suffix, so existing packages will be correctly updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164116|0 |1 is obsolete| | --- Comment #15 from Mason James <mtj@kohaaloha.com> --- Created attachment 164403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164403&action=edit Bug 35614: Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09 This patch updates the following libraries, as required by Koha: * Mojolicious::Plugin::OpenAPI * JSON::Validator To test: 1. Apply this patch 2. Run: $ ktd --shell k$ sudo cpanm --installdeps . => SUCCESS: Dependencies updated correctly 3. Run: k$ prove -r t/db_dependent/api/v1/ \ t/db_dependent/Koha/REST/ => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Is this needed for backport ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org