[Bug 30499] New: Keyboard shortcuts broken on several pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Bug ID: 30499 Summary: Keyboard shortcuts broken on several pages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Keyboard shortcuts fro catalog search, check in and renew should be following: 1) Alt-q for catalog search 2) Alt-r for check in 3) Alt-w for renew However on some of the pages shortcuts get mixed up: 1) Alt-w for catalog search 2) Alt-q for check in 3) Alt-r for renew Problem occurs at least on the following pages: circulation-home.pl circulation.pl renew.pl set-library.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tmcmahon@wlpl.org Assignee|koha-bugs@lists.koha-commun |tmcmahon@wlpl.org |ity.org | Status|NEW |ASSIGNED --- Comment #1 from tmcmahon@wlpl.org --- Created attachment 138208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138208&action=edit Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts Bug 30499: Keyboard shortcuts broken on several pages Keyboard shortcuts for catalog search, check in and renew should be following: 1) Alt-q for catalog search 2) Alt-r for check in 3) Alt-w for renew However on some of the pages shortcuts get mixed up: 1) Alt-w for catalog search 2) Alt-q for check in 3) Alt-r for renew Affected files are: circ/pendingreserves.tt circ/circulation_batch_checkouts.tt circ/circulation-home.tt circ/branchtransfers.tt circ/branchoverdues.tt circ/set-library.tt circ/checkout-notes.tt circ/renew.tt circ/waitingreserves.tt circ/transferstoreceive.tt circ/offline.tt circ/bookcount.tt circ/on-site_checkouts.tt circ/circulation.tt circ/transfers_to_send.tt circ/request-article.tt circ/overdue.tt circ/reserveratios.tt offline_circ/list.tt offline_circ/process_koc.tt offline_circ/enqueue_koc.tt plugins/plugins-upload.tt plugins/plugins-disabled.tt pos/registers.tt pos/register.tt pos/pay.tt reports/reports-home.tt reports/dictionary.tt reports/guided_reports_start.tt reserve/request.tt tools/scheduler.tt This is because the include statement for catalogue-search-box.inc is in the wrong line in circ-search.inc. To test: 1) Go to an affected page (circulation-home was the first one I noticed) 2) Try the keyboard shortcuts and notice they are incorrect 3) Apply patch and refresh the page 4) Notice that the keys work properly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 tmcmahon@wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |trivial Status|ASSIGNED |Needs Signoff Version|unspecified |21.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I'm having trouble applying this patch. Using git bz I get: Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2716, in <module> applied = do_apply(bug_ref) File "/usr/local/bin/git-bz", line 1827, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request response.msg, xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found> Applying manually doesn't work either:
Patch format detection failed.
It seems patch is missing metadata header (stuff containing e.g. information when patch was made and by whom) from the begining of it. Could you provide patch again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 138373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138373&action=edit Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts Keyboard shortcuts for catalog search, check in and renew should be following: 1) Alt-q for catalog search 2) Alt-r for check in 3) Alt-w for renew However on some of the pages shortcuts get mixed up: 1) Alt-w for catalog search 2) Alt-q for check in 3) Alt-r for renew Affected files are: circ/pendingreserves.tt circ/circulation_batch_checkouts.tt circ/circulation-home.tt circ/branchtransfers.tt circ/branchoverdues.tt circ/set-library.tt circ/checkout-notes.tt circ/renew.tt circ/waitingreserves.tt circ/transferstoreceive.tt circ/offline.tt circ/bookcount.tt circ/on-site_checkouts.tt circ/circulation.tt circ/transfers_to_send.tt circ/request-article.tt circ/overdue.tt circ/reserveratios.tt offline_circ/list.tt offline_circ/process_koc.tt offline_circ/enqueue_koc.tt plugins/plugins-upload.tt plugins/plugins-disabled.tt pos/registers.tt pos/register.tt pos/pay.tt reports/reports-home.tt reports/dictionary.tt reports/guided_reports_start.tt reserve/request.tt tools/scheduler.tt This is because the include statement for catalogue-search-box.inc is in the wrong line in circ-search.inc. To test: 1) Go to an affected page (circulation-home was the first one I noticed) 2) Try the keyboard shortcuts and notice they are incorrect 3) Apply patch and refresh the page 4) Notice that the keys work properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138373|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 138374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138374&action=edit Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts Keyboard shortcuts for catalog search, check in and renew should be following: 1) Alt-q for catalog search 2) Alt-r for check in 3) Alt-w for renew However on some of the pages shortcuts get mixed up: 1) Alt-w for catalog search 2) Alt-q for check in 3) Alt-r for renew Affected files are: circ/pendingreserves.tt circ/circulation_batch_checkouts.tt circ/circulation-home.tt circ/branchtransfers.tt circ/branchoverdues.tt circ/set-library.tt circ/checkout-notes.tt circ/renew.tt circ/waitingreserves.tt circ/transferstoreceive.tt circ/offline.tt circ/bookcount.tt circ/on-site_checkouts.tt circ/circulation.tt circ/transfers_to_send.tt circ/request-article.tt circ/overdue.tt circ/reserveratios.tt offline_circ/list.tt offline_circ/process_koc.tt offline_circ/enqueue_koc.tt plugins/plugins-upload.tt plugins/plugins-disabled.tt pos/registers.tt pos/register.tt pos/pay.tt reports/reports-home.tt reports/dictionary.tt reports/guided_reports_start.tt reserve/request.tt tools/scheduler.tt This is because the include statement for catalogue-search-box.inc is in the wrong line in circ-search.inc. To test: 1) Go to an affected page (circulation-home was the first one I noticed) 2) Try the keyboard shortcuts and notice they are incorrect 3) Apply patch and refresh the page 4) Notice that the keys work properly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Attachment #138208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I got the following error trying to apply this to a sandbox. I'm wondering if maybe it's to do with two copies of the same patch being active here? I just marked one obsolete to see if that helps, waiting on a new sandbox. Bug 30499 - Keyboard shortcuts broken on several pages 138208 - Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts 138374 - Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts Apply? [(y)es, (n)o, (i)nteractive] Traceback (most recent call last): File "/usr/bin/git-bz", line 2716, in <module> applied = do_apply(bug_ref) File "/usr/bin/git-bz", line 1827, in do_apply users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher] })['users'] File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__ return self.__send(self.__name, args) File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request verbose=self.__verbose File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request return self.single_request(host, handler, request_body, verbose) File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request response.msg, xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi: 404 Not Found> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138374|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 138376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138376&action=edit Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts Keyboard shortcuts for catalog search, check in and renew should be following: 1) Alt-q for catalog search 2) Alt-r for check in 3) Alt-w for renew However on some of the pages shortcuts get mixed up: 1) Alt-w for catalog search 2) Alt-q for check in 3) Alt-r for renew Affected files are: circ/pendingreserves.tt circ/circulation_batch_checkouts.tt circ/circulation-home.tt circ/branchtransfers.tt circ/branchoverdues.tt circ/set-library.tt circ/checkout-notes.tt circ/renew.tt circ/waitingreserves.tt circ/transferstoreceive.tt circ/offline.tt circ/bookcount.tt circ/on-site_checkouts.tt circ/circulation.tt circ/transfers_to_send.tt circ/request-article.tt circ/overdue.tt circ/reserveratios.tt offline_circ/list.tt offline_circ/process_koc.tt offline_circ/enqueue_koc.tt plugins/plugins-upload.tt plugins/plugins-disabled.tt pos/registers.tt pos/register.tt pos/pay.tt reports/reports-home.tt reports/dictionary.tt reports/guided_reports_start.tt reserve/request.tt tools/scheduler.tt This is because the include statement for catalogue-search-box.inc is in the wrong line in circ-search.inc. To test: 1) Go to an affected page (circulation-home was the first one I noticed) 2) Try the keyboard shortcuts and notice they are incorrect 3) Apply patch and refresh the page 4) Notice that the keys work properly Signed-off-by: Andrew <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | Version|21.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138376|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 138389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138389&action=edit Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to correct keyboard shortcuts Keyboard shortcuts for catalog search, check in and renew should be following: 1) Alt-q for catalog search 2) Alt-r for check in 3) Alt-w for renew However on some of the pages shortcuts get mixed up: 1) Alt-w for catalog search 2) Alt-q for check in 3) Alt-r for renew Affected files are: circ/pendingreserves.tt circ/circulation_batch_checkouts.tt circ/circulation-home.tt circ/branchtransfers.tt circ/branchoverdues.tt circ/set-library.tt circ/checkout-notes.tt circ/renew.tt circ/waitingreserves.tt circ/transferstoreceive.tt circ/offline.tt circ/bookcount.tt circ/on-site_checkouts.tt circ/circulation.tt circ/transfers_to_send.tt circ/request-article.tt circ/overdue.tt circ/reserveratios.tt offline_circ/list.tt offline_circ/process_koc.tt offline_circ/enqueue_koc.tt plugins/plugins-upload.tt plugins/plugins-disabled.tt pos/registers.tt pos/register.tt pos/pay.tt reports/reports-home.tt reports/dictionary.tt reports/guided_reports_start.tt reserve/request.tt tools/scheduler.tt This is because the include statement for catalogue-search-box.inc is in the wrong line in circ-search.inc. To test: 1) Go to an affected page (circulation-home was the first one I noticed) 2) Try the keyboard shortcuts and notice they are incorrect 3) Apply patch and refresh the page 4) Notice that the keys work properly Signed-off-by: Andrew <andrewfh@dubcolib.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #10 from Tim McMahon <tmcmahon@wlpl.org> --- Will this be added to 21.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00,21.11, 22.05.06 |22.11.00,22.05.06,21.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org