[Bug 6098] New: zebra conf NSB NSE indexed as space
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Bug #: 6098 Summary: zebra conf NSB NSE indexed as space Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org For those who are not using icu in Zebra conf and have NSB NSE special characters in biblio. This patch removes those undisplayed characters in searching and sorting. Regards, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-04-06 15:46:14 UTC --- Created attachment 3758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3758 pro -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> 2011-05-03 13:25:05 UTC --- Isn't this bug already solved in current /etc/zebradb/etc/word-phrase-utf.chr file. We have at the end of the file: map (\x88.*\x89)) @ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-03 14:42:10 UTC --- (In reply to comment #2)
Isn't this bug already solved in current /etc/zebradb/etc/word-phrase-utf.chr file.
We have at the end of the file:
map (\x88.*\x89)) @
Indeed, This line should remove from indexation all characters (regexp ".*") between "\x88" and "\x89". Unfortunately, I have tested a lot, is doesn't work. It seems that Zebra understands in "map" only a few elements of regexp syntaxe like "\s". It is impossible tu define a unknown number of characters. Maybe it is limited to avoid a catastrophic indexing performance. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 14:14:39 UTC --- On any page, NSB/NSE characters are replaced by space in Output.pm. It isn't a good thing: - It isn't necessary since Zebra indexer handle properly those characters as delimiter. - It isn't necessary for display since XSL file already do that. - It isn't efficient since a regex is done on every whole page sent by Koha, not only on biblio record part. - It removes an information that librarian want to keep in their biblio records: any record edited in Koha loose its NSB/NSE characters. See proposed patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 14:15:11 UTC --- Created attachment 4105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4105 Clean Output.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5885 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2011-05-13 16:24:57 UTC --- (In reply to comment #5)
Created attachment 4105 [details] Clean Output.pm
Shoudn't it be 2 different bugs ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 16:36:10 UTC ---
Shoudn't it be 2 different bugs ?
Maybe. IMHO, we should just have one bug labeled "NSB/NSE proper handling". This bug stays open until we consider there isn't anything to do anymore to handle correctly those characters in various places. And after closing this bug, we can reopen it if we discover another corner where NSB/NSE have to be eradicated! So open a new bug if you think it's better, or rename this one (not sur it's possible), or/and sign-of my patch if you agree that it's required, or argue against it. Just for performace reason, I think it's very necessary. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-01 08:36:48 UTC --- Second patch requires sign off still -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3758|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-21 19:16:21 UTC --- Created attachment 6904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6904 BUG 6098 zebra conf NSB NSE indexed as space Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4105|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-21 19:16:57 UTC --- Created attachment 6905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6905 Bug 6098 Followup -- doesn't replace NSB/NSE by space On any page, NSB/NSE characters are replaced by space in Output.pm. It isn't a good thing: - It isn't necessary since Zebra indexer handle properly those characters as delimiter. - It isn't necessary for display since XSL file already do that. - It isn't efficient since a regex is done on every whole page sent by Koha, not only on biblio record part. - It removes an information that librarian want to keep in their biblio records: any record edited in Koha loose its NSB/NSE characters. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #11 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-09 12:49:12 UTC --- Simple changes to handling of NSB and NSE characters; removes regex processing and adds to Zebra config. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|rel_3_4 |rel_3_6 Patch Status|Passed QA |Patch Pushed AssignedTo|gmcharlt@gmail.com |fridolyn.somers@gmail.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-13 10:24:26 UTC --- patch pushed, please test QA COMMENT: seing comments 2 and 3, shouldn't the line map (\x88.*\x89)) @ also be removed from /etc/zebradb/etc/word-phrase-utf.chr file ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6098 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org