[Bug 24352] New: OpacItemLocation is buggy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Bug ID: 24352 Summary: OpacItemLocation is buggy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The different settings from the OpacItemLocation don't appear to work correctly. When "collection" is selected, collection is not visible, but a label 'Location(s)' shows up? The callnumber never showed for me in my testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97221&action=edit Screenshot of modified template Does this look correct? The screenshot shows the results from the three different OpacItemLocation settings: - Call number - Location - Collection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97225&action=edit Bug 24352: OpacItemLocation is buggy This patch modifies the OPAC's MARC21 search results XSLT so that the OpacItemLocation preference correctly controls what information displays. Previously the code for distinguishing between the 'location' and 'collection' settings was combined. To test, apply the patch and set the OPACXSLTResultsDisplay system preference to 'default.' Set the OpacItemLocation preference to 'call number only.' - On the OPAC search results page, each result with items should show information in this format: - "Availability: Items available for loan: {library} [Call number: {call number} ] With the OpacItemLocation preference set to 'collection code,' - "Availability: Items available for loan: {library} Collection(s): {collection description} [{ call number }]" With the OpacItemLocation preference set to 'location,' - "Availability: Items available for loan: {library} Location(s): {shelving location} [{ call number }]" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- These are the results for me from changing OpacItemLocation after applying the patch (searching for cat on koha-testing-docker): call number only - doesn't show the call number: Availability: Items available for loan: Fairview (2), Midway (1). collection code: Availability: Items available for loan: Fairview (2), Midway (1). Collection(s): GEN , GEN . location: Availability: Items available for loan: Fairview (2), Midway (1). Location(s): General Stacks , General Stacks . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16147 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- David, it sounds like you're seeing what Katrin was seeing, but I don't know what might be different about our setup/data to cause it--assuming you're looking at records which have call numbers? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 --- Comment #5 from David Nind <david@davidnind.com> --- Face palm - records didn't have call numbers! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97225|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 97257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97257&action=edit Bug 24352: OpacItemLocation is buggy This patch modifies the OPAC's MARC21 search results XSLT so that the OpacItemLocation preference correctly controls what information displays. Previously the code for distinguishing between the 'location' and 'collection' settings was combined. To test, apply the patch and set the OPACXSLTResultsDisplay system preference to 'default.' Set the OpacItemLocation preference to 'call number only.' - On the OPAC search results page, each result with items should show information in this format: - "Availability: Items available for loan: {library} [Call number: {call number} ] With the OpacItemLocation preference set to 'collection code,' - "Availability: Items available for loan: {library} Collection(s): {collection description} [{ call number }]" With the OpacItemLocation preference set to 'location,' - "Availability: Items available for loan: {library} Location(s): {shelving location} [{ call number }]" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I sorry Owen, not having a good run on your patches tonight :( In my setup this doesn't work when there are no collections set on any of the items on the record: Collection(s): . Could you have another look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #7)
Collection(s): .
It still sounds to me like the item must not have a call number. Even if the items have no location, for instance, the call numbers show up for me: https://zivotdesign.com/p/view.php?p=15791100203899 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, you were right, but still struggling a bit with these patches, can you help? These are my items: Books Centerville Fiction Non-fiction 782.42166092 B (Browse shelf) Available Books Centerville New Materials Shelf Non-fiction 782.42166092 B (Browse shelf) Pending hold Books Union Fiction Reference 782.42166092 B (Browse shelf) Available So all 3 have locations, one is a pending hold, 2 are available. In the result list, only reference shows: Availability: Items available for loan: Centerville (2). Pending hold (1). Collection(s): Reference [782.42166092 B]. Can you tell why the collection Non-fiction doesn't show? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97257|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105931&action=edit Bug 24352: Correct location and collection labels in OPAC search results This patch modifies the OPAC's MARC21 search results XSLT so that OPAC search result information is correctly labeled based on the OpacItemLocation preference. Previously, search results showed the label "Location(s)" whether the setting was "collection code" or "location." To test, apply the patch and set the OPACXSLTResultsDisplay system preference to 'default.' On the OPAC search results page, each result with items should show information in this format: With the OpacItemLocation preference set to 'call number only,' - "Availability: Items available for loan: {library} [Call number: {call number} ] With the OpacItemLocation preference set to 'collection code,' - "Availability: Items available for loan: {library} Collection(s): {collection description} [{ call number }]" With the OpacItemLocation preference set to 'location,' - "Availability: Items available for loan: {library} Location(s): {shelving location} [{ call number }]" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- The new patch changes much less, in part because the XSL markup has changed a lot since I submitted the original patch. I'm still not certain I understand the original bug report, but I fixed what problem I could see. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105931|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 105948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105948&action=edit Bug 24352: Correct location and collection labels in OPAC search results This patch modifies the OPAC's MARC21 search results XSLT so that OPAC search result information is correctly labeled based on the OpacItemLocation preference. Previously, search results showed the label "Location(s)" whether the setting was "collection code" or "location." To test, apply the patch and set the OPACXSLTResultsDisplay system preference to 'default.' On the OPAC search results page, each result with items should show information in this format: With the OpacItemLocation preference set to 'call number only,' - "Availability: Items available for loan: {library} [Call number: {call number} ] With the OpacItemLocation preference set to 'collection code,' - "Availability: Items available for loan: {library} Collection(s): {collection description} [{ call number }]" With the OpacItemLocation preference set to 'location,' - "Availability: Items available for loan: {library} Location(s): {shelving location} [{ call number }]" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Leaving QA to Katrin as the original bug reporter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OpacItemLocation is buggy |Wrong labels displaying in | |result list with | |OpacItemLocation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are still some oddities (punctuation, repeating the same location/collection), but I believe this is a great improvement :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105948|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106171&action=edit Bug 24352: Correct location and collection labels in OPAC search results This patch modifies the OPAC's MARC21 search results XSLT so that OPAC search result information is correctly labeled based on the OpacItemLocation preference. Previously, search results showed the label "Location(s)" whether the setting was "collection code" or "location." To test, apply the patch and set the OPACXSLTResultsDisplay system preference to 'default.' On the OPAC search results page, each result with items should show information in this format: With the OpacItemLocation preference set to 'call number only,' - "Availability: Items available for loan: {library} [Call number: {call number} ] With the OpacItemLocation preference set to 'collection code,' - "Availability: Items available for loan: {library} Collection(s): {collection description} [{ call number }]" With the OpacItemLocation preference set to 'location,' - "Availability: Items available for loan: {library} Location(s): {shelving location} [{ call number }]" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the OPAC's release notes| |MARC21 search results XSLT | |so that OPAC search result | |information is correctly | |labelled based on the | |OpacItemLocation | |preference. | | | |Previously, | |search results showed the | |label "Location(s)" whether | |the | |setting was "collection | |code" or "location." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.08 CC| |aleisha@catalyst.net.nz --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08 |19.11.08, 19.05.14 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org