[Bug 29463] New: Umlauts in search field get changed into Replacement character
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Bug ID: 29463 Summary: Umlauts in search field get changed into Replacement character Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: stalkernoid@gmail.com Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org CC: nugged@gmail.com Our customers can't search for patrons with umlauts in their names using the "Check out" search menu on the main page of Koha. Other search menus seem to work fine. To reproduce: 1) Go to the main page of Koha and in the "Check out" search window type something like "Tëst". Press the search button. 2) See that it gets replaced with a replacement character. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Our customers can't search for patrons with umlauts in their names using the "Check out" search menu on the main page of Koha. Other search menus seem to work fine. To reproduce: 1) Go to the main page of Koha and in the "Check out" search window type something like "näyttö". Press the search button. 2) See that it gets replaced with a replacement character. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 --- Comment #2 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 127583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127583&action=edit Bug 29463: Escape utf8 characters before appending search query to url. To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127583|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127593&action=edit Bug 29463: Escape utf8 characters before appending search query to url To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. JK: remove period from commit title Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi Depends on| |15812 Severity|minor |normal --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Regression from bug 15812, would be nice to get this in before the 21.11 release. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 [Bug 15812] Checkout search with too many results (single character search) causes poor performance or timeout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com Component|Searching |Circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127593|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 127846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127846&action=edit Bug 29463: Escape utf8 characters before appending search query to url To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. JK: remove period from commit title Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Umlauts in search field get |Umlauts in search field get |changed into Replacement |changed into replacement |character |character -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29463 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org