[Bug 22856] New: Show SQL code button should trigger CodeMirror view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 Bug ID: 22856 Summary: Show SQL code button should trigger CodeMirror view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- We use a readonly CodeMirror display for the SQL reports' "view" page. We should do the same for the SQL view which is shown on the report results page, triggered by the "Show SQL code" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89370&action=edit Bug 22856: Show SQL code button should trigger CodeMirror view This patch adds CodeMirror syntax highlighting to the SQL view which can be shown on the report results page by clicking the "Show SQL code" button. To test, apply the patch and run any SQL report. On the report results page, click the "Show SQL button." The SQL should be displayed with CodeMirror syntax highlighting. Test toggling the SQL code view on and off to confirm that the CodeMirror highlighting continues to work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89370|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 89371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89371&action=edit Bug 22856: Show SQL code button should trigger CodeMirror view This patch adds CodeMirror syntax highlighting to the SQL view which can be shown on the report results page by clicking the "Show SQL code" button. To test, apply the patch and run any SQL report. On the report results page, click the "Show SQL button." The SQL should be displayed with CodeMirror syntax highlighting. Test toggling the SQL code view on and off to confirm that the CodeMirror highlighting continues to work correctly. Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89371|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89415&action=edit Bug 22856: Show SQL code button should trigger CodeMirror view This patch adds CodeMirror syntax highlighting to the SQL view which can be shown on the report results page by clicking the "Show SQL code" button. To test, apply the patch and run any SQL report. On the report results page, click the "Show SQL button." The SQL should be displayed with CodeMirror syntax highlighting. Test toggling the SQL code view on and off to confirm that the CodeMirror highlighting continues to work correctly. Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this could fall under 'polishing' the Code mirror work in this release :) It's nice, maybe the text area is a little big for a tiny report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22856 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org