[Bug 13442] New: Facet links broken when collection code limit is used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Bug ID: 13442 Summary: Facet links broken when collection code limit is used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Clicking on a collection code facet generates a broken URL. For example on the Bywater demo server http://intranet.bywatersolutions.com (username: bywater, password bywater) Step 1) Keyword search for 'Juggling': http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q=juggling&op=and&idx=kw&q=&op=and&idx=kw&q=&limit-yr=&limit=&limit=&limit=&limit=&limit=&limit=&multibranchlimit=&sort_by=relevance Step 2) Click on Author 'De Paola, Tomie' in record 5. "The clown of God : an old story" (Popular author, likely to have useful search facets). This takes us to http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=au:%... Step 3) Click facet for item type "Adult Office" => http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=ccl=... This is equivalent to http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=ccl=...: Which obviously won't return any results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34331&action=edit Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 34594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34594&action=edit [Signed-off] Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. I could not reproduce the bug either, but I saw it on the Bywater Demo (comment #1). Applied patch and tested facets, no problems found, signing off Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34331|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34602&action=edit [PASSED QA] Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. I could not reproduce the bug either, but I saw it on the Bywater Demo (comment #1). Applied patch and tested facets, no problems found, signing off Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Can not reproduce the problem, but I can also not find a regression. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Does this work if the facet contain a simple quote? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13812 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #5 from Barton Chittenden <barton@bywatersolutions.com> --- Shelf location facets are breaking in exactly the same way. Does C4::Search::buildQuery need to be refactored? Bug 13812 - Facet links broken when shelf location limit is used. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Does this target master? the 3.18.x branch? UTf-8 handling differs, a lot on each. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #6)
Does this target master? the 3.18.x branch? UTf-8 handling differs, a lot on each.
Sorry, wrong but number :-D Kyle, could you please address Jonathan's concern? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #8 from Barton Chittenden <barton@bywatersolutions.com> --- The double-quoted "ccode" URLs are being passed to the search results page /cgi-bin/koha/catalogue/detail.pl and breaking the "Return to results" link on that page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #6)
Does this target master? the 3.18.x branch? UTf-8 handling differs, a lot on each.
Yes, this targets master. As far as I know this isn't a UTF-8 related issue, but deals with quotes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #10 from David Cook <dcook@prosentient.com.au> --- I can't reproduce this in master. Search: http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=au:%... Creates: <a href="/cgi-bin/koha/catalogue/search.pl?q=ccl=au%3A" de%20paola%2c%20tomie."&limit="itype:AOF"" title="AOF">Adult Office</a> However... Search: http://192.168.1.61:2112/cgi-bin/koha/catalogue/search.pl?q=au:%22De%20Paola... Creates: <a href="/cgi-bin/koha/catalogue/search.pl?q=ccl=au%3A%22De%20Paola%2C%20Tomie%22&sort_by=relevance_dsc&limit=itype:TEST" title="TEST">test</a> Which works just fine. I noticed the Bywater site is on 3.19.00.016, and I'm on 3.19.00.026, so maybe that makes a difference. Or perhaps there's a setting difference somewhere... but this is the same thing I noticed on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812. The Bywater link has an extra space and all the letters are lowercased. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Peggy Thrasher <p.thrasher@dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org