[Bug 29153] New: CodeMirror broken on additional-contents.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Bug ID: 29153 Summary: CodeMirror broken on additional-contents.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: -Go to Tools and open either addtional contents ( either News or HTML customization ) -Make sure you open it using CodeMirror and not TinyMCE -Code mirror is broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24387 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 126368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126368&action=edit Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126368|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126390&action=edit Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126390|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126463&action=edit Bug 29153: Fix CodeMirror textareas to work with all languages To test: 1. Go to Tools > HTML customizations 2. Open or create a new entry with CodeMirror. ( Edit with text editor ) 3. CodeMirror doesn't work, notice a console error. 4. Apply patch 5. Try steps 1 & 2 again. The CodeMirror editor should now load. 6. Make sure it works in both the Default and English(en) tabs. 7. BONUS: install some other language packs and look at the tabs for that language, it should still work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CodeMirror broken on |CodeMirror broken for news |additional-contents.pl |and HTML customizations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29153 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org