https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 144855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144855&action=edit Bug 32537: Add no-block option to SIP cli emulator This patch adds the option to pass a no-block option and use this in checkout/checkin/renew messages To test: 1 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 2 - Confirm out like: SEND: 09N20221227 20183920221227 201839APCPL|AOCPL|AB39999000010831|ACterm1|BIN| (Note the N after 09) 3 - Apply patch 4 - Restart SIP, repeat 1 5 - Confirm still an N 6 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 -n N 7 - Confirm still an N 8 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 -n Y 9 - Confirm the send has a Y after 09 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhanced adds the release notes| |no-block option to the SIP | |emulator for optional use | |in checkout/checkin/renew | |messages. --- Comment #3 from David Nind <david@davidnind.com> --- Koha testing notes (using KTD - used 39999000011418 as the item). I have included the responses I got for the commands as there were unitialized values reported in the output, and I don't know whether these are expected or not. 1. Response for step 1: root@kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 120. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230101 20473320230101 204733APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230101 204734AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|CRREF| 2. To restart SIP: koha-sip --restart kohadev 3. Response for step 4: root@kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 124. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230101 20543120230101 205431APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230101 205431AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|CRREF| 4. Response for step 6: root@kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n N Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 124. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20230101 20552620230101 205526APCPL|AOCPL|AB39999000011418|ACterm1|BIN| READ: 101YNN20230101 205526AOCPL|AB39999000011418|AQCPL|AJProgramming Perl /|CRREF| 5. Response for step 8: root@kohadevbox:koha(bz32537)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000011418 -n Y Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 124. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'checkin' SEND: 09Y20230101 20561720230101 205617APCPL|AOCPL|AB39999000011418|ACterm1|BIN| Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 356, <GEN0> chunk 1. READ: -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 144935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144935&action=edit Bug 32537: (QA follow-up) Don't allow invalid no block values -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144895|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145945&action=edit Bug 32537: Add no-block option to SIP cli emulator This patch adds the option to pass a no-block option and use this in checkout/checkin/renew messages To test: 1 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 2 - Confirm out like: SEND: 09N20221227 20183920221227 201839APCPL|AOCPL|AB39999000010831|ACterm1|BIN| (Note the N after 09) 3 - Apply patch 4 - Restart SIP, repeat 1 5 - Confirm still an N 6 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 -n N 7 - Confirm still an N 8 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000010831 -n Y 9 - Confirm the send has a Y after 09 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144936|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145947&action=edit Bug 32537: (QA follow-up): Tidy code Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 --- Comment #11 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32537 Bug 32537 depends on bug 12225, which changed state. Bug 12225 Summary: SIP does not respect the "no block" flag https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.