[Bug 10141] New: Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Bug ID: 10141 Summary: Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au Currently, the marc21_field_008.xml populates many drop-down boxes in the marc21_field_008.pl plugin for editing the MARC 008 field. However, it doesn't populate the boxes for the 18-21 Illustrations of 24-27 Nature of contents, even though the XML file does have options available for these fields. -- I've only glanced at the code, but I imagine that part of the problem is that you can't really use a single drop-down box to fill 3-4 different positions that could have any combination of the single character options specified in the XML. I'm not sure what the optimal solution would be exactly, but the options should still be loaded from the XML file so that people can choose which code to fill each of the different positions for these parts of the MARC 008 control field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- One fast (albeit ugly) solution could be add in xml an individual entry for each position. xmlControlfield.js write a input text without options if description has a '-' (dash). Result in attached image. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17875&action=edit field 008 with decomposed Illustration options -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17876&action=edit field 008 with multiple options This image describe another possible solution, but this requires some JS wizardry to work. Something like this could also be used to dates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #2)
Created attachment 17875 [details] field 008 with decomposed Illustration options
Visually, I think that this [the decomposed options] might be the best option. It allows users to see the code and the description of the code, so as to easily make informed decisions. My only concern might be in the label for the positions. "18 - Illustrations - code 1" might be better than "18 - Illustrations position 1". It's not very optimal to have separate entries for 18, 19, 20, 21, but I assume it might not be possible to give one XML element several position attributes. I suppose the 18-21 and 24-27 positions might be special cases, so maybe having separate XML elements for each position within those ranges is acceptable...especially if it means that we're providing a validated list of options to users. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17891&action=edit Bug 10141 - Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Easy workaround This patch expands both options, Illustrations and Nature of.., so each position could be filled independently. To test: 1) edit or add a new recod 2) click on field 008 value builder, positions 18-21 and 24-27 only show an input text box 3) apply the patch 4) reload value_builder page, now each position (18-21,24-27) has it's own pulldown. A similar fix could be used in a similar problem in 006 value builder. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17891|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 18057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18057&action=edit [SIGNED OFF] Bug 10141 - Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Easy workaround This patch expands both options, Illustrations and Nature of.., so each position could be filled independently. To test: 1) edit or add a new recod 2) click on field 008 value builder, positions 18-21 and 24-27 only show an input text box 3) apply the patch 4) reload value_builder page, now each position (18-21,24-27) has it's own pulldown. A similar fix could be used in a similar problem in 006 value builder. Signed-off-by: David Cook <dcook@prosentient.com.au> I struggled with this test plan at first (until I cleared my memcache), but it works as described. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18057|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19033&action=edit Bug 10141 - Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Easy workaround This patch expands both options, Illustrations and Nature of.., so each position could be filled independently. To test: 1) edit or add a new recod 2) click on field 008 value builder, positions 18-21 and 24-27 only show an input text box 3) apply the patch 4) reload value_builder page, now each position (18-21,24-27) has it's own pulldown. A similar fix could be used in a similar problem in 006 value builder. Signed-off-by: David Cook <dcook@prosentient.com.au> I struggled with this test plan at first (until I cleared my memcache), but it works as described. Thanks, Bernardo! Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19033|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19034&action=edit Bug 10141 - Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Easy workaround This patch expands both options, Illustrations and Nature of.., so each position could be filled independently. To test: 1) edit or add a new recod 2) click on field 008 value builder, positions 18-21 and 24-27 only show an input text box 3) apply the patch 4) reload value_builder page, now each position (18-21,24-27) has it's own pulldown. A similar fix could be used in a similar problem in 006 value builder. Signed-off-by: David Cook <dcook@prosentient.com.au> I struggled with this test plan at first (until I cleared my memcache), but it works as described. Thanks, Bernardo! Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Bernardo, great job! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org